From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9332CC433F5 for ; Wed, 2 Mar 2022 23:50:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbiCBXv3 (ORCPT ); Wed, 2 Mar 2022 18:51:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229634AbiCBXv2 (ORCPT ); Wed, 2 Mar 2022 18:51:28 -0500 Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2435A42A34; Wed, 2 Mar 2022 15:50:44 -0800 (PST) Received: by mail-oo1-xc2c.google.com with SMTP id i6-20020a4ac506000000b0031c5ac6c078so3892078ooq.6; Wed, 02 Mar 2022 15:50:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Q5O31HUYjdscklXRXvmIo2a+KRrg+KbZekYyUmOBdlQ=; b=NMlh+In8hqJzm11n/pBAceHkhO4cKz+IQpIEEoxyH/w/Klg2dyhHX3ssfZYWonHRzY gpU3xjA6mVZZalgz5Is3Oq7Jdy/fnROfgT5X3nr4NkIWINDj1KnvpSdMxgE9jmOKoZmL RG1wVitWI6pA6ORD9X1JvqTI2oUyRd0NldwtysPIDhdrc8dKKLQ4jZOmslsv+avMZQjN PP7sFsW8rAVB+phBv+vNzV+5g7MOnqfey0bj3E8ny1obNVlJ1TePtqaYZaxabwUiG77W gv5/E970OV8yV1Ga9K/QlEZV1+ya9ymaggsGar316Q7vhPLMRV/k+YrshugeJf0XW3cE g9hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Q5O31HUYjdscklXRXvmIo2a+KRrg+KbZekYyUmOBdlQ=; b=rxOTrgHhp3DdIdr6uo13/I2Ebxodf66BjO5mrOrReWURHq1kyJ5Bx5ZxnTHx6DQQut OOmLpV/AI2M6gquvsqzLmDo6Q0pWyfg0jM1cEjpdq6yh6R0fs4dBi8Vvk/vhU+76TbJB 2H2lzfuPgPNZ8K9e4EzIQGnnjWUdCeYBOqT1sz73lePeHYfVKwROJ63E+6mKCAcEbG4M sAvEddNygG2fRci7JCLR2Sb+kvHvLbKQ/ANLve2UMz+vQW+Jf37QTOdCdMuMh6Yv/uDd EWxJG2xJZ9+RMj45DD3wJmxwaEmeu16iU8fo27CDemkQzyX6mE0tXdXEzuXfeWU8GvqE qbow== X-Gm-Message-State: AOAM531tf7GopZNSGVzCarSP3+4GP2eVCRzMqnFQTX4FZaaqKa7GfxF5 sIAssrRPnT6X/iJ4PMUbz3MRKh3gOm7odsk2jff0+pQEDHI= X-Google-Smtp-Source: ABdhPJwsJn9qaH2KXnNnxkinO/s/Gt3k6nIoSEEBwfC4GuE26Li2y7FVOO9kRLouMtJeKS/JPR+vB3d4kyg4ibTYRzA= X-Received: by 2002:a9d:5a06:0:b0:5af:b5fd:5b72 with SMTP id v6-20020a9d5a06000000b005afb5fd5b72mr17283446oth.200.1646263217608; Wed, 02 Mar 2022 15:20:17 -0800 (PST) MIME-Version: 1.0 References: <20220106122452.18719-1-wsa@kernel.org> <98ed8d6d16a3d472d9432eb169aa2da44b66b5cc.camel@yandex.ru> <4dfbee97-14c2-718b-9cbd-fdeeace96f59@yahoo.com> <6121a782-6927-f033-1c09-ffe4ad7700ae@yahoo.com> <363432688.323955.1642272250312@mail.yahoo.com> <297191986.3285872.1644002564779@mail.yahoo.com> In-Reply-To: From: Alex Deucher Date: Wed, 2 Mar 2022 18:20:06 -0500 Message-ID: Subject: Re: [PATCH] Revert "i2c: core: support bus regulator controlling in adapter" To: Wolfram Sang , "Tareque Md.Hanif" , Hsin-Yi Wang , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , Bibby Hsieh , Marek Szyprowski , Matthias Brugger Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 11, 2022 at 12:51 PM Wolfram Sang wrote: > > On Fri, Feb 04, 2022 at 07:22:44PM +0000, Tareque Md.Hanif wrote: > > The issue still exists. It takes very long time to suspend (10-12s). `DRI_PRIME=1 glxgears` is a black window. > > > > journalctl attached > > Looking forward to any testing. > > Any new ideas which Tareque could test? For some background, the GPU has multiple i2c buses attached to it which the driver uses for querying the EDID on monitors over i2c. Although in this case, the i2c buses are not used because there is no display controller on this particular GPU. I'm not even sure if the gpu driver exposes any i2c buses in this case. The i2c buses present are in a vbios table that the driver parses at load time. If there are none on your platform, then it's probably not the AMD GPU driver. Can you check if there are any i2c buses from the AMD GPU device in sysfs? I don't really see why this patch would change anything off hand on the GPU. Maybe the GPU is a red herring. No one reported any regressions on systems with AMD CPUs or even other Intel CPUs. This seems to be specific to a particular Intel CPU + AMD Topaz GPUs. The dGPU power is controlled by the platform via ACPI (it's usually a GPIO under the covers). I wonder if the issue is related to one of the i2c buses or devices on the intel platform? E.g., 00:15.0 Signal processing controller: Intel Corporation Sunrise Point-LP Serial IO I2C Controller #0 (rev 21) 00:15.1 Signal processing controller: Intel Corporation Sunrise Point-LP Serial IO I2C Controller #1 (rev 21) 00:1f.4 SMBus: Intel Corporation Sunrise Point-LP SMBus (rev 21) I'm not sure what those do, but maybe that is something to look at? Also there are some PCI AERs in the kernel log. Are those present without the patch? Alex