From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7461DC433DB for ; Fri, 26 Feb 2021 21:30:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45A3764DA3 for ; Fri, 26 Feb 2021 21:30:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230377AbhBZVaZ (ORCPT ); Fri, 26 Feb 2021 16:30:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbhBZVaU (ORCPT ); Fri, 26 Feb 2021 16:30:20 -0500 Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBB12C061574 for ; Fri, 26 Feb 2021 13:29:39 -0800 (PST) Received: by mail-oi1-x235.google.com with SMTP id z126so11211250oiz.6 for ; Fri, 26 Feb 2021 13:29:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T+XuI1x+8YDlt07TAQPA3xx8+2WYMMEBzo0uXxTMkC4=; b=mJlk0wqt+hovCyn5pQJ5lMizNw18al5kCVeYtx1FPDccDVE7hpeji7OHh9al4m/HAf Pxsnznei5j6RO9dyA23/LwklDtMFEo/dljBb7oKyGLlW8u7+g+XtIq8ySo6pXhdKwvbh jSxviSw42gDvyi3+A9tuXV/lIYwfPVLlZ4bgLvyVkdoM5grOxKP5GYFdXXpQmGVfoh2S fwwZT+mwfymQN2ZtjF9u5noz+qnIAc4DJvV5HB9l+TpV05wY2m6w9Zm4ChBqELnsTDT0 vkiPG+VuQpEDn6MPfwAzRwJ3uBMTC6msW7Qb8BFZLBBtTTsxj2k+pdnZQ/X2orhJio02 IsVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T+XuI1x+8YDlt07TAQPA3xx8+2WYMMEBzo0uXxTMkC4=; b=iSlq5pOjSL9rXiFNSvwsSJyW0zTwoEYAUR4bwz29OhMMbd4KmiZG6F44jZj46QBKgo zv6arDYeK9drMCTwCDVz/cV5ePGYVFsFKeM71QdBsl+YQ7ZQgRl+55MrgPAPzebFcQP+ FcydmwAYuHvcgvZnLd5n4OMk7cybwPqOe2Q58RwDwhjgH77Tl1/5ntKDvLloKul3l+DU XUggbc04ZlpR+cGi3CrsmfrHKTt1iEYb1a2dZ3VFJ4oPUBMRkS+zX/t25F0568OdYPXO 7/pmypLdNLQZQjHJK7GaUprRLaDmNsBfW/xRoH2439A9FYg9P+Ltl5NoU/NVLYSSFg3L U7qw== X-Gm-Message-State: AOAM533v1I3GVcMrR84tg3SZUzz3+ou5FcG7XEA9BoyABdU/nkxhS77P vdIE+7gLyUEx96Uau1l9ck2t9uuYEwsUip0iEK1RyGIy X-Google-Smtp-Source: ABdhPJzM/GD97FBNksX+qUYYCV5b+mBloW+GDX6JAIooMsjETRDa6/4gNIukKjRYSZ1ufHxF9fzRZbq2+cKYNgPZDsQ= X-Received: by 2002:aca:fccb:: with SMTP id a194mr3362138oii.5.1614374979385; Fri, 26 Feb 2021 13:29:39 -0800 (PST) MIME-Version: 1.0 References: <1614332527-5014-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: <1614332527-5014-1-git-send-email-jiapeng.chong@linux.alibaba.com> From: Alex Deucher Date: Fri, 26 Feb 2021 16:29:28 -0500 Message-ID: Subject: Re: [PATCH] drm/amd/display/dc/dce/dmub_psr: Remove unnecessary conversion to bool To: Jiapeng Chong Cc: "Wentland, Harry" , "Leo (Sunpeng) Li" , LKML , amd-gfx list , Dave Airlie , Maling list - DRI developers , "Deucher, Alexander" , Christian Koenig Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 26, 2021 at 4:42 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c:273:16-21: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c > index 69e34be..c13f967 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c > +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c > @@ -269,8 +269,7 @@ static bool dmub_psr_copy_settings(struct dmub_psr *dmub, > copy_settings_data->frame_cap_ind = psr_context->psrFrameCaptureIndicationReq; > copy_settings_data->init_sdp_deadline = psr_context->sdpTransmitLineNumDeadline; > copy_settings_data->debug.u32All = 0; > - copy_settings_data->debug.bitfields.visual_confirm = dc->dc->debug.visual_confirm == VISUAL_CONFIRM_PSR ? > - true : false; > + copy_settings_data->debug.bitfields.visual_confirm = dc->dc->debug.visual_confirm == VISUAL_CONFIRM_PSR; > copy_settings_data->debug.bitfields.use_hw_lock_mgr = 1; > > dc_dmub_srv_cmd_queue(dc->dmub_srv, &cmd); > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel