From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933091AbcFOV2N (ORCPT ); Wed, 15 Jun 2016 17:28:13 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:32778 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753361AbcFOV2K convert rfc822-to-8bit (ORCPT ); Wed, 15 Jun 2016 17:28:10 -0400 MIME-Version: 1.0 In-Reply-To: <5761BB7A.8080209@amd.com> References: <20160615201531.3346929-1-arnd@arndb.de> <5761BB7A.8080209@amd.com> From: Alex Deucher Date: Wed, 15 Jun 2016 17:28:07 -0400 Message-ID: Subject: Re: [PATCH] amdgpu: use NULL instead of 0 for pointer To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Arnd Bergmann , Alex Deucher , Rex Zhu , LKML , Maling list - DRI developers Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 4:32 PM, Christian König wrote: > Am 15.06.2016 um 22:15 schrieb Arnd Bergmann: >> >> In the AMD powerplay driver, a pointer is checked for validity by >> comparing against an integer '0', which causes a harmless warning >> when building with "make W=1": >> >> drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/processpptables.c:1502:16: >> error: ordered comparison of pointer with integer zero [-Werror=extra] >> >> This changes the code to the more conventional "if (pointer)" check. >> >> Signed-off-by: Arnd Bergmann > > > Reviewed-by: Christian König . Applied. thanks! Alex > >> --- >> drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c >> b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c >> index 2f1a14fe05b1..b64f42d2c3ae 100644 >> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c >> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/processpptables.c >> @@ -1499,7 +1499,7 @@ int get_number_of_vce_state_table_entries( >> const ATOM_PPLIB_VCE_State_Table *vce_table = >> get_vce_state_table(hwmgr, table); >> - if (vce_table > 0) >> + if (vce_table) >> return vce_table->numEntries; >> return 0; > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel