From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FDD8C4361B for ; Mon, 14 Dec 2020 21:50:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA88822210 for ; Mon, 14 Dec 2020 21:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731630AbgLNVuU (ORCPT ); Mon, 14 Dec 2020 16:50:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440050AbgLNVuB (ORCPT ); Mon, 14 Dec 2020 16:50:01 -0500 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C4F2C061794 for ; Mon, 14 Dec 2020 13:49:21 -0800 (PST) Received: by mail-oi1-x229.google.com with SMTP id 15so20949924oix.8 for ; Mon, 14 Dec 2020 13:49:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xwc4jX2cVzI9GAPOLZxtNDFTIGEsJRQAPMon6mB69F8=; b=fkIxSTKdBBFWS/VLhbLVQ0ym5+uNJi7s6sCD8mRohvztdY1RIvKuTMIYKVqZxXd5+t WUQnGa7VzoKOrHmP1BOvUGlKGxAFtgQnOG2BXTsIM4KEoB+xbtGxXAyNrv/hzmwRtHur gBLiWvJUyXWdK6cCE2mBXYUzEejBqavTjequZjv4xD4QCvIYdBbbKkeUXlHhiHeVYoAl 6SdJYy0vONpADtfO+YpbYFzknut4APElD6xxt57mqgcl2YVJKKvx9a0icbz5Ruaknt74 l4uchtdx+yBnK0Zwup/ewoZa1kyhHM0vmd5XG/EwoDCoAHMAAZssz8umouw5YqYJ99mQ kzJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xwc4jX2cVzI9GAPOLZxtNDFTIGEsJRQAPMon6mB69F8=; b=YjxLMFW2QHap9U6K4f6g4H3GySvePbLx7TJFebWkLE3lde8eCbR7d8aFtTz6iw5EvO Mkg7IVme0GvAg21Ooi+DXSGAWAAI5NkeTp9Ax9qiFy0Apeuoo2ETu1e03/WagiFodypf m+68+Ncg9hvKhyApR4yxmpoOs/d6/OAwcjHg/+v6ChT8L7oa5JxOhAaDIs2EqvZSuC9N pWYJOTPGnWHtHvIswmEtPc0k+bCeFINtWKhRRF0KcgArEgOlpKpxCl4Nd3vpzPHjtZpp lbnz0k8FUwRyB8Jq/S29P5Wn3eXj8TYuomn0HhY2Vsj51tr+L4CQB0mWMdRQghFgMfWN 4nzA== X-Gm-Message-State: AOAM531WNAe16Hcn53FLvhpkwzPZUVO2EExU+le3siULlCaDYjq0nYIR AFp0qjctbkXwdl5iutmEYbNCiSH1mm1FWqFfgMk= X-Google-Smtp-Source: ABdhPJwXTJY4vOyrXu0/kLhsMtwrSYzJagyhpKZBcswQMlbTtwatKXLLkTcMHL7fAndk4Q+k2gxjmvaCUzQd+b673nI= X-Received: by 2002:aca:4f97:: with SMTP id d145mr19595326oib.123.1607982560930; Mon, 14 Dec 2020 13:49:20 -0800 (PST) MIME-Version: 1.0 References: <20201211155553.GC25974@zn.tnic> In-Reply-To: <20201211155553.GC25974@zn.tnic> From: Alex Deucher Date: Mon, 14 Dec 2020 16:49:09 -0500 Message-ID: Subject: Re: 8353d30e747f ("drm/amd/display: disable stream if pixel clock changed with link active") To: Borislav Petkov , Harry Wentland , "Kazlauskas, Nicholas" Cc: Chiawen Huang , Alex Deucher , Rodrigo Siqueira , Tony Cheng , LKML , amd-gfx list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 11, 2020 at 11:49 AM Borislav Petkov wrote: > > Hi, > > patch in $Subject breaks booting on a laptop here, GPU details are > below. The machine stops booting right when it attempts to switch modes > during boot, to a higher mode than the default VGA one. Machine doesn't > ping and is otherwise unresponsive so that a hard reset is the only > thing that helps. > > Reverting that patch ontop of -rc7 fixes it and the machine boots just fine. + a few more display folks This patch looks like a correctness fix, but not critical. Unless anyone has a proper fix handy, I'll just revert it for now and we can revisit it properly. Alex > > Thx. > > [ 1.628086] ata1.00: supports DRM functions and may not be fully accessible > [ 1.632050] ata1.00: supports DRM functions and may not be fully accessible > [ 1.895818] [drm] amdgpu kernel modesetting enabled. > [ 1.897628] [drm] initializing kernel modesetting (CARRIZO 0x1002:0x9874 0x103C:0x807E 0xC4). > [ 1.898256] [drm] register mmio base: 0xD0C00000 > [ 1.898422] [drm] register mmio size: 262144 > [ 1.898583] [drm] add ip block number 0 > [ 1.898759] [drm] add ip block number 1 > [ 1.898931] [drm] add ip block number 2 > [ 1.899082] [drm] add ip block number 3 > [ 1.899241] [drm] add ip block number 4 > [ 1.899439] [drm] add ip block number 5 > [ 1.899573] [drm] add ip block number 6 > [ 1.899693] [drm] add ip block number 7 > [ 1.899827] [drm] add ip block number 8 > [ 1.911458] [drm] BIOS signature incorrect 5b 7 > [ 1.912551] [drm] UVD is enabled in physical mode > [ 1.912707] [drm] VCE enabled in physical mode > [ 1.912921] [drm] vm size is 64 GB, 2 levels, block size is 10-bit, fragment size is 9-bit > [ 1.913837] [drm] Detected VRAM RAM=512M, BAR=512M > [ 1.913998] [drm] RAM width 128bits UNKNOWN > [ 1.915149] [drm] amdgpu: 512M of VRAM memory ready > [ 1.915306] [drm] amdgpu: 3072M of GTT memory ready. > [ 1.915468] [drm] GART: num cpu pages 262144, num gpu pages 262144 > [ 1.916139] [drm] PCIE GART of 1024M enabled (table at 0x000000F400900000). > [ 1.918733] [drm] Found UVD firmware Version: 1.91 Family ID: 11 > [ 1.918950] [drm] UVD ENC is disabled > [ 1.919680] [drm] Found VCE firmware Version: 52.4 Binary ID: 3 > [ 1.925963] [drm] DM_PPLIB: values for Engine clock > [ 1.926106] [drm] DM_PPLIB: 300000 > [ 1.926205] [drm] DM_PPLIB: 360000 > [ 1.926304] [drm] DM_PPLIB: 423530 > [ 1.926404] [drm] DM_PPLIB: 514290 > [ 1.926516] [drm] DM_PPLIB: 626090 > [ 1.926629] [drm] DM_PPLIB: 720000 > [ 1.926743] [drm] DM_PPLIB: Validation clocks: > [ 1.926952] [drm] DM_PPLIB: engine_max_clock: 72000 > [ 1.927117] [drm] DM_PPLIB: memory_max_clock: 80000 > [ 1.927281] [drm] DM_PPLIB: level : 8 > [ 1.927435] [drm] DM_PPLIB: values for Display clock > [ 1.927594] [drm] DM_PPLIB: 300000 > [ 1.927708] [drm] DM_PPLIB: 400000 > [ 1.927822] [drm] DM_PPLIB: 496560 > [ 1.927936] [drm] DM_PPLIB: 626090 > [ 1.928048] [drm] DM_PPLIB: 685720 > [ 1.928161] [drm] DM_PPLIB: 757900 > [ 1.928275] [drm] DM_PPLIB: Validation clocks: > [ 1.928419] [drm] DM_PPLIB: engine_max_clock: 72000 > [ 1.928584] [drm] DM_PPLIB: memory_max_clock: 80000 > [ 1.928748] [drm] DM_PPLIB: level : 8 > [ 1.928901] [drm] DM_PPLIB: values for Memory clock > [ 1.929058] [drm] DM_PPLIB: 333000 > [ 1.929172] [drm] DM_PPLIB: 800000 > [ 1.929403] [drm] DM_PPLIB: Validation clocks: > [ 1.929549] [drm] DM_PPLIB: engine_max_clock: 72000 > [ 1.929716] [drm] DM_PPLIB: memory_max_clock: 80000 > [ 1.929919] [drm] DM_PPLIB: level : 8 > [ 1.930148] [drm] Display Core initialized with v3.2.104! > [ 2.003938] [drm] UVD initialized successfully. > [ 2.204023] [drm] VCE initialized successfully. > [ 2.206228] [drm] fb mappable at 0xA0EE4000 > [ 2.206375] [drm] vram apper at 0xA0000000 > [ 2.206514] [drm] size 14745600 > [ 2.206654] [drm] fb depth is 24 > [ 2.206760] [drm] pitch is 10240 > [ 2.207123] fbcon: amdgpudrmfb (fb0) is primary device > [ 2.301263] amdgpu 0000:00:01.0: [drm] fb0: amdgpudrmfb frame buffer device > [ 2.320735] [drm] Initialized amdgpu 3.40.0 20150101 for 0000:00:01.0 on minor 0 > > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx