linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the amdgpu tree
@ 2022-07-25 11:16 Stephen Rothwell
  2022-07-27 16:21 ` Rodrigo Siqueira Jordao
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2022-07-25 11:16 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Rodrigo Siqueira, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_crtc.c:297:26: error: 'amdgpu_dm_crtc_late_register' undeclared here (not in a function); did you mean 'amdgpu_umc_ras_late_init'?
  297 |         .late_register = amdgpu_dm_crtc_late_register,
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                          amdgpu_umc_ras_late_init

Caused by commit

  a6c0b96cb899 ("drm/amd/display: Create a file dedicated for CRTC")

I have applied the following hack for today (just to make it build).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 25 Jul 2022 20:48:29 +1000
Subject: [PATCH] fixup for "drm/amd/display: Create a file dedicated for CRTC"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
index 16b624828e0d..3eb6ea3709bc 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
@@ -293,7 +293,7 @@ static const struct drm_crtc_funcs amdgpu_dm_crtc_funcs = {
 	.enable_vblank = dm_enable_vblank,
 	.disable_vblank = dm_disable_vblank,
 	.get_vblank_timestamp = drm_crtc_vblank_helper_get_vblank_timestamp,
-#if defined(CONFIG_DEBUG_FS)
+#ifdef CONFIG_DRM_AMD_SECURE_DISPLAY
 	.late_register = amdgpu_dm_crtc_late_register,
 #endif
 };
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2024-02-13  4:00 Stephen Rothwell
  2024-02-13 14:00 ` Alex Deucher
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2024-02-13  4:00 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Alex Deucher, Mario Limonciello, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:42:
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1559:13: error: 'amdgpu_choose_low_power_state' defined but not used [-Werror=unused-function]
 1559 | static void amdgpu_choose_low_power_state(struct amdgpu_device *adev) { }
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

(and many, many more)

Caused by commit

  c77536b15b7a ("drm/amd: Stop evicting resources on APUs in suspend")

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 13 Feb 2024 14:41:05 +1100
Subject: [PATCH] fixup for "drm/amd: Stop evicting resources on APUs in suspend"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 2a3f12bae823..2cf4fb3f7751 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -1556,7 +1556,7 @@ void amdgpu_choose_low_power_state(struct amdgpu_device *adev);
 #else
 static inline bool amdgpu_acpi_is_s0ix_active(struct amdgpu_device *adev) { return false; }
 static inline bool amdgpu_acpi_is_s3_active(struct amdgpu_device *adev) { return false; }
-static void amdgpu_choose_low_power_state(struct amdgpu_device *adev) { }
+static inline void amdgpu_choose_low_power_state(struct amdgpu_device *adev) { }
 #endif
 
 #if defined(CONFIG_DRM_AMD_DC)
-- 
2.43.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2023-10-10  1:43 Stephen Rothwell
  2023-10-10 21:14 ` Rodrigo Siqueira Jordao
                   ` (2 more replies)
  0 siblings, 3 replies; 138+ messages in thread
From: Stephen Rothwell @ 2023-10-10  1:43 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Alex Deucher, Qingqing Zhuo, Rodrigo Siqueira, Roman Li,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c: In function 'dml_core_mode_support':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/display_mode_core.c:8229:1: error: the frame size of 2736 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
 8229 | } // dml_core_mode_support
      | ^
cc1: all warnings being treated as errors

Caused by commit

  7966f319c66d ("drm/amd/display: Introduce DML2")

(or maybe something later that changed storage size).

I have used the amdgpu tree from next-20231009 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2023-05-22  7:15 Stephen Rothwell
  2023-05-22 16:29 ` Nick Desaulniers
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2023-05-22  7:15 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Alex Deucher, Felix Kuehling, Harish Kasiviswanathan,
	Rajneesh Bhardwaj, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (arm allmodconfig
clang-17) failed like this:

drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c:146:54: error: format specifies type 'unsigned long long' but the argument has type 'dma_addr_t' (aka 'unsigned int') [-Werror,-Wformat]

Caused by commit

  d020a29b6b58 ("drm/amdgpu: Allocate GART table in RAM for AMD APU")

Reported by the kernelci.org bot.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2023-05-22  7:11 Stephen Rothwell
  2023-05-22  7:24 ` Lazar, Lijo
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2023-05-22  7:11 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Alex Deucher, Lijo Lazar, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig clang-17) failed like this:

(in function gfxhub_v1_2_xcp_resume)
drivers/gpu/drm/amd/amdgpu/gfxhub_v1_2.c:657:6: error: variable 'ret' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

Caused by commit

  c554a01e1c08 ("drm/amdgpu: Add GFXHUB v1.2 XCP funcs")

Reported by the kernelci.org bot.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2023-05-22  7:00 Stephen Rothwell
  2023-05-22  7:04 ` Zhang, Hawking
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2023-05-22  7:00 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Alex Deucher, Hawking Zhang, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig clang-17) failed like this:

drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c:704:23: error: variable 'mmhub_v1_8_mmea_err_status_reg' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]

Caused by commit

  fa90ca94dbda ("drm/amdgpu: Add query_ras_error_status for mmhub v1_8")

It is only used as "ARRAY_SIZE(mmhub_v1_8_mmea_err_status_reg)".

Reported by the kernerci.org bot.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2023-05-19  0:06 Stephen Rothwell
  2023-05-19  3:10 ` James Zhu
  2023-05-19 13:38 ` Alex Deucher
  0 siblings, 2 replies; 138+ messages in thread
From: Stephen Rothwell @ 2023-05-19  0:06 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Alex Deucher, James Zhu, Linux Kernel Mailing List,
	Linux Next Mailing List, Dave Airlie, DRI

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c: In function 'amdgpu_ctx_init':
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c:348:26: error: 'fpriv' undeclared (first use in this function)
  348 |         ctx->ctx_mgr = &(fpriv->ctx_mgr);
      |                          ^~~~~

Caused by commit

  2458393a4e98 ("drm/amdgpu: keep amdgpu_ctx_mgr in ctx structure")

I have used the amdgpu tree from next-20230518 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2023-01-30  1:20 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2023-01-30  1:20 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Dave Airlie, Harry Wentland, Lyude Paul,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2886 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_atomic_check':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9706:41: error: redeclaration of 'mgr' with no linkage
 9706 |         struct drm_dp_mst_topology_mgr *mgr;
      |                                         ^~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9697:41: note: previous declaration of 'mgr' with type 'struct drm_dp_mst_topology_mgr *'
 9697 |         struct drm_dp_mst_topology_mgr *mgr;
      |                                         ^~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9707:43: error: redeclaration of 'mst_state' with no linkage
 9707 |         struct drm_dp_mst_topology_state *mst_state;
      |                                           ^~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9698:43: note: previous declaration of 'mst_state' with type 'struct drm_dp_mst_topology_state *'
 9698 |         struct drm_dp_mst_topology_state *mst_state;
      |                                           ^~~~~~~~~

Caused by commit

  c689e1e362ea ("drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count assignments")

interacting with commits

  1119e1f9636b ("drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count assignments")
  f439a959dcfb ("amdgpu: fix build on non-DCN platforms.")

from Linus' tree.

Please can you guys think about your bug fixing process?

I have applied the following merge fix for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 30 Jan 2023 12:12:21 +1100
Subject: [PATCH] amdgpu: fix up for "drm/amdgpu/display/mst: Fix mst_state->pbn_div and slot count assignments"

This appears as a commit in Linus tree and again in the amdgpu tree,
but there is a following fix commit in Linus' tree.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 8965071f595b..e1d63826927a 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -9694,8 +9694,6 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
 	struct drm_connector_state *old_con_state, *new_con_state;
 	struct drm_crtc *crtc;
 	struct drm_crtc_state *old_crtc_state, *new_crtc_state;
-	struct drm_dp_mst_topology_mgr *mgr;
-	struct drm_dp_mst_topology_state *mst_state;
 	struct drm_plane *plane;
 	struct drm_plane_state *old_plane_state, *new_plane_state;
 	enum dc_status status;
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-10-31  0:13 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-10-31  0:13 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Kernel Mailing List, Linux Next Mailing List, Dave Airlie

[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c: In function 'amdgpu_firmware_info':
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c:353:9: error: duplicate case value
  353 |         case AMDGPU_INFO_FW_IMU:
      |         ^~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c:349:9: note: previously used here
  349 |         case AMDGPU_INFO_FW_IMU:
      |         ^~~~

Caused by commit

  22834837f8dd ("Merge branch 'drm-next' of https://gitlab.freedesktop.org/agd5f/linux")

because commits

  b72362962a66 ("drm/amd: Add IMU fw version to fw version queries")

from the amdgpu tree and

  68bc147363bd ("drm/amd: Add IMU fw version to fw version queries")

from Linus' tree are the same patch and git merged this hunk from
both :-(

I have applied the following merge fixup patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 31 Oct 2022 11:05:29 +1100
Subject: [PATCH] fixup for bad merge of "drm/amd: Add IMU fw version to fw version queries"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index 662704371756..4e42dcb1950f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -350,10 +350,6 @@ static int amdgpu_firmware_info(struct drm_amdgpu_info_firmware *fw_info,
 		fw_info->ver = adev->gfx.imu_fw_version;
 		fw_info->feature = 0;
 		break;
-	case AMDGPU_INFO_FW_IMU:
-		fw_info->ver = adev->gfx.imu_fw_version;
-		fw_info->feature = 0;
-		break;
 	default:
 		return -EINVAL;
 	}
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-08-30  1:41 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-08-30  1:41 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Alvin Lee, Linux Kernel Mailing List, Linux Next Mailing List,
	Jun Lei, Brian Chang, Daniel Wheeler

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c: In function 'commit_planes_for_stream':
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: error: this 'if' clause does not guard... [-Werror=misleading-indentation]
 3508 |         if (update_type != UPDATE_TYPE_FAST)
      |         ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
 3510 |                 if (update_type != UPDATE_TYPE_FAST)
      |                 ^~
cc1: all warnings being treated as errors

Caused by commit

  e990bd60716d ("drm/amd/display: Only commit SubVP state after pipe programming")

I have used the amdgpu tree from next-20220829 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-07-19  2:36 Stephen Rothwell
  2022-07-20  2:47 ` Stephen Rothwell
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2022-07-19  2:36 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'DISPCLKDPPCLKDCFCLKDeepSleepPrefetchParametersWatermarksAndPerformanceCalculation':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:1659:1: error: the frame size of 2144 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
 1659 | }
      | ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3799:1: error: the frame size of 2464 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
 3799 | } // ModeSupportAndSystemConfigurationFull
      | ^
cc1: all warnings being treated as errors

I can't see anything obvious that caused this.  The second one was
previously fixed by commit

  01cf387b1c7f ("drm/amdgpu/display: reduce stack size in dml32_ModeSupportAndSystemConfigurationFull()")

Usinf the amdgpu tree from next-20220718 fixes the problem, so I have
done that for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-06-23  6:07 Stephen Rothwell
  2022-06-23 11:01 ` Greg KH
  2022-06-27 14:40 ` Greg KH
  0 siblings, 2 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-06-23  6:07 UTC (permalink / raw)
  To: Alex Deucher, Greg KH
  Cc: Somalapuram Amaranath, Duoming Zhou, Greg Kroah-Hartman,
	Dave Airlie, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 4748 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/radix-tree.h:12,
                 from include/linux/idr.h:15,
                 from include/linux/kernfs.h:12,
                 from include/linux/sysfs.h:16,
                 from include/linux/kobject.h:20,
                 from include/linux/energy_model.h:7,
                 from include/linux/device.h:16,
                 from include/linux/power_supply.h:15,
                 from drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:28:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function 'amdgpu_reset_capture_coredumpm':
include/linux/gfp.h:337:25: error: passing argument 5 of 'dev_coredumpm' makes pointer from integer without a cast [-Werror=int-conversion]
  337 | #define GFP_KERNEL      (__GFP_RECLAIM | __GFP_IO | __GFP_FS)
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                         |
      |                         unsigned int
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4726:55: note: in expansion of macro 'GFP_KERNEL'
 4726 |         dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_KERNEL,
      |                                                       ^~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:35:
include/linux/devcoredump.h:59:30: note: expected 'ssize_t (*)(char *, loff_t,  size_t,  void *, size_t)' {aka 'long int (*)(char *, long long int,  long unsigned int,  void *, long unsigned int)'} but argument is of type 'unsigned int'
   59 |                    ssize_t (*read)(char *buffer, loff_t offset, size_t count,
      |                    ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   60 |                                    void *data, size_t datalen),
      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4727:23: error: passing argument 6 of 'dev_coredumpm' from incompatible pointer type [-Werror=incompatible-pointer-types]
 4727 |                       amdgpu_devcoredump_read, amdgpu_devcoredump_free);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~
      |                       |
      |                       ssize_t (*)(char *, loff_t,  size_t,  void *, size_t) {aka long int (*)(char *, long long int,  long unsigned int,  void *, long unsigned int)}
In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:35:
include/linux/devcoredump.h:61:27: note: expected 'void (*)(void *)' but argument is of type 'ssize_t (*)(char *, loff_t,  size_t,  void *, size_t)' {aka 'long int (*)(char *, long long int,  long unsigned int,  void *, long unsigned int)'}
   61 |                    void (*free)(void *data));
      |                    ~~~~~~~^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4726:9: error: too many arguments to function 'dev_coredumpm'
 4726 |         dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_KERNEL,
      |         ^~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:35:
include/linux/devcoredump.h:57:6: note: declared here
   57 | void dev_coredumpm(struct device *dev, struct module *owner,
      |      ^~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  3d8785f6c04a ("drm/amdgpu: adding device coredump support")

interacting with commit

  77515ebaf019 ("devcoredump: remove the useless gfp_t parameter in dev_coredumpv and dev_coredumpm")

from the driver-core tree.

I have applied the following merge resolution patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 23 Jun 2022 15:56:22 +1000
Subject: [PATCH] fix up for "devcoredump: remove the useless gfp_t parameter in dev_coredumpv and dev_coredumpm"

interacting with

  3d8785f6c04a ("drm/amdgpu: adding device coredump support")

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index f2a4c268ac72..9d6418bb963e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -4723,7 +4723,7 @@ static void amdgpu_reset_capture_coredumpm(struct amdgpu_device *adev)
 	struct drm_device *dev = adev_to_drm(adev);
 
 	ktime_get_ts64(&adev->reset_time);
-	dev_coredumpm(dev->dev, THIS_MODULE, adev, 0, GFP_KERNEL,
+	dev_coredumpm(dev->dev, THIS_MODULE, adev, 0,
 		      amdgpu_devcoredump_read, amdgpu_devcoredump_free);
 }
 #endif
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-06-15  4:37 Stephen Rothwell
  2022-06-15 18:17 ` Alex Deucher
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2022-06-15  4:37 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Harry Wentland, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1835:13: error: 'remove_hpo_dp_link_enc_from_ctx' defined but not used [-Werror=unused-function]
 1835 | static void remove_hpo_dp_link_enc_from_ctx(struct resource_context *res_ctx, 
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  4e1db0119c64 ("Revert "drm/amdgpu/display: Protect some functions with CONFIG_DRM_AMD_DC_DCN"")

That function is only used when CONFIG_DRM_AMD_DC_DCN is set.

I have reverted that commit for today.

Could you please add an x86_64 allmodconfig build to your CI?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-06-14  4:51 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-06-14  4:51 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Aurabindo Pillai, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_plane_format_mod_supported':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4941:13: error: unused variable 'i' [-Werror=unused-variable]
 4941 |         int i;
      |             ^
cc1: all warnings being treated as errors

Caused by commit

  d2d5adc87f69 ("drm/amd/display: ignore modifiers when checking for format support")

I have revertd that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-06-03  4:43 Stephen Rothwell
  2022-06-09  3:14 ` Stephen Rothwell
  2022-06-15  5:00 ` Stephen Rothwell
  0 siblings, 2 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-06-03  4:43 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Aurabindo Pillai, Linux Kernel Mailing List,
	Linux Next Mailing List, Dave Airlie

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c: In function 'dml32_ModeSupportAndSystemConfigurationFull':
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.c:3835:1: error: the frame size of 2752 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]
 3835 | } // ModeSupportAndSystemConfigurationFull
      | ^
cc1: all warnings being treated as errors
make[5]: *** [scripts/Makefile.build:250: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_32.o] Error 1
gcc: error: unrecognized command-line option '-msse'
gcc: error: unrecognized command-line option '-msse2'
make[5]: *** [scripts/Makefile.build:251: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_resource.o] Error 1
gcc: error: unrecognized command-line option '-msse'
gcc: error: unrecognized command-line option '-msse2'

Caused (probably) by commits

  5cbb369e32bd ("drm/amd/display: DML changes for DCN32/321")
  b5dbe04a9c8c ("drm/amd/display: add CLKMGR changes for DCN32/321")
  4f185390597e ("drm/amd/display: add DCN32/321 specific files for Display Core")

I have used the amdgpu tree from next-20220601 again for today.

Is this new stuff really for the current merge window?  If so, it has
arrived pretty late.  If not then it should not have been in linux-next
at all ...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-06-02  0:30 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-06-02  0:30 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Aurabindo Pillai, Dave Airlie, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1835:13: error: 'remove_hpo_dp_link_enc_from_ctx' defined but not used [-Werror=unused-function]
 1835 | static void remove_hpo_dp_link_enc_from_ctx(struct resource_context *res_ctx,
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  9b0e0d433f74 ("drm/amd/display: Add dependant changes for DCN32/321")

I have used the amdgpu tree from next-20220601 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-05-06  1:06 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-05-06  1:06 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Kenneth Feng, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 13787 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c: In function 'smu_v13_0_7_get_power_profile_mode':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1381:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1381 |         PRINT_DPM_MONITOR(Fclk_BoosterFreq);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1380:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1380 |         PRINT_DPM_MONITOR(Fclk_MinActiveFreq);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1379:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1379 |         PRINT_DPM_MONITOR(Fclk_BoosterFreqType);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1378:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1378 |         PRINT_DPM_MONITOR(Fclk_MinActiveFreqType);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1377:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1377 |         PRINT_DPM_MONITOR(Fclk_FPS);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1376:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1376 |         PRINT_DPM_MONITOR(Fclk_IdleHystLimit);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1375:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1375 |         PRINT_DPM_MONITOR(Fclk_ActiveHystLimit);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1374:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1374 |         PRINT_DPM_MONITOR(Gfx_BoosterFreq);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1373:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1373 |         PRINT_DPM_MONITOR(Gfx_MinActiveFreq);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1372:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1372 |         PRINT_DPM_MONITOR(Gfx_BoosterFreqType);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1371:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1371 |         PRINT_DPM_MONITOR(Gfx_MinActiveFreqType);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1370:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1370 |         PRINT_DPM_MONITOR(Gfx_FPS);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1369:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1369 |         PRINT_DPM_MONITOR(Gfx_IdleHystLimit);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1364:84: error: array subscript 8 is above array bounds of 'DpmActivityMonitorCoeffIntExternal_t[8]' [-Werror=array-bounds]
 1364 |                 size += sysfs_emit_at(buf, size, "%-16d", activity_monitor_external[i].DpmActivityMonitorCoeffInt.field);               \
      |                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~^~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1368:9: note: in expansion of macro 'PRINT_DPM_MONITOR'
 1368 |         PRINT_DPM_MONITOR(Gfx_ActiveHystLimit);
      |         ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0_7_ppt.c:1328:46: note: while referencing 'activity_monitor_external'
 1328 |         DpmActivityMonitorCoeffIntExternal_t activity_monitor_external[PP_SMC_POWER_PROFILE_COUNT];
      |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  878205b8c170 ("drm/amd/pm: enable workload type change on smu_v13_0_7")

I have used the amdgpu tree from next-20220505 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-05-05  9:47 Stephen Rothwell
  2022-05-05 18:12 ` Nathan Chancellor
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2022-05-05  9:47 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Jack Xiao, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 7139 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:26:
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c: In function 'mes_v11_0_mqd_init':
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:697:34: error: 'CP_HQD_PQ_CONTROL__ENDIAN_SWAP_MASK' undeclared (first use in this function); did you mean 'CP_HQD_PQ_CONTROL__PRIV_STATE_MASK'?
  697 |         tmp = REG_SET_FIELD(tmp, CP_HQD_PQ_CONTROL, ENDIAN_SWAP, 1);
      |                                  ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1177:36: note: in definition of macro 'REG_FIELD_MASK'
 1177 | #define REG_FIELD_MASK(reg, field) reg##__##field##_MASK
      |                                    ^~~
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:697:15: note: in expansion of macro 'REG_SET_FIELD'
  697 |         tmp = REG_SET_FIELD(tmp, CP_HQD_PQ_CONTROL, ENDIAN_SWAP, 1);
      |               ^~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:697:34: note: each undeclared identifier is reported only once for each function it appears in
  697 |         tmp = REG_SET_FIELD(tmp, CP_HQD_PQ_CONTROL, ENDIAN_SWAP, 1);
      |                                  ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1177:36: note: in definition of macro 'REG_FIELD_MASK'
 1177 | #define REG_FIELD_MASK(reg, field) reg##__##field##_MASK
      |                                    ^~~
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:697:15: note: in expansion of macro 'REG_SET_FIELD'
  697 |         tmp = REG_SET_FIELD(tmp, CP_HQD_PQ_CONTROL, ENDIAN_SWAP, 1);
      |               ^~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:697:34: error: 'CP_HQD_PQ_CONTROL__ENDIAN_SWAP__SHIFT' undeclared (first use in this function); did you mean 'CP_HQD_PQ_CONTROL__PRIV_STATE__SHIFT'?
  697 |         tmp = REG_SET_FIELD(tmp, CP_HQD_PQ_CONTROL, ENDIAN_SWAP, 1);
      |                                  ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1176:37: note: in definition of macro 'REG_FIELD_SHIFT'
 1176 | #define REG_FIELD_SHIFT(reg, field) reg##__##field##__SHIFT
      |                                     ^~~
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c:697:15: note: in expansion of macro 'REG_SET_FIELD'
  697 |         tmp = REG_SET_FIELD(tmp, CP_HQD_PQ_CONTROL, ENDIAN_SWAP, 1);
      |               ^~~~~~~~~~~~~
In file included from drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:28:
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c: In function 'gfx_v11_0_cp_gfx_resume':
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:3413:34: error: 'CP_RB0_CNTL__BUF_SWAP_MASK' undeclared (first use in this function); did you mean 'CP_RB0_CNTL__TMZ_STATE_MASK'?
 3413 |         tmp = REG_SET_FIELD(tmp, CP_RB0_CNTL, BUF_SWAP, 1);
      |                                  ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1177:36: note: in definition of macro 'REG_FIELD_MASK'
 1177 | #define REG_FIELD_MASK(reg, field) reg##__##field##_MASK
      |                                    ^~~
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:3413:15: note: in expansion of macro 'REG_SET_FIELD'
 3413 |         tmp = REG_SET_FIELD(tmp, CP_RB0_CNTL, BUF_SWAP, 1);
      |               ^~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:3413:34: note: each undeclared identifier is reported only once for each function it appears in
 3413 |         tmp = REG_SET_FIELD(tmp, CP_RB0_CNTL, BUF_SWAP, 1);
      |                                  ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1177:36: note: in definition of macro 'REG_FIELD_MASK'
 1177 | #define REG_FIELD_MASK(reg, field) reg##__##field##_MASK
      |                                    ^~~
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:3413:15: note: in expansion of macro 'REG_SET_FIELD'
 3413 |         tmp = REG_SET_FIELD(tmp, CP_RB0_CNTL, BUF_SWAP, 1);
      |               ^~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:3413:34: error: 'CP_RB0_CNTL__BUF_SWAP__SHIFT' undeclared (first use in this function); did you mean 'CP_RB0_CNTL__TMZ_STATE__SHIFT'?
 3413 |         tmp = REG_SET_FIELD(tmp, CP_RB0_CNTL, BUF_SWAP, 1);
      |                                  ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1176:37: note: in definition of macro 'REG_FIELD_SHIFT'
 1176 | #define REG_FIELD_SHIFT(reg, field) reg##__##field##__SHIFT
      |                                     ^~~
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:3413:15: note: in expansion of macro 'REG_SET_FIELD'
 3413 |         tmp = REG_SET_FIELD(tmp, CP_RB0_CNTL, BUF_SWAP, 1);
      |               ^~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c: In function 'gfx_v11_0_compute_mqd_init':
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:4063:34: error: 'CP_HQD_PQ_CONTROL__ENDIAN_SWAP_MASK' undeclared (first use in this function); did you mean 'CP_HQD_PQ_CONTROL__PRIV_STATE_MASK'?
 4063 |         tmp = REG_SET_FIELD(tmp, CP_HQD_PQ_CONTROL, ENDIAN_SWAP, 1);
      |                                  ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1177:36: note: in definition of macro 'REG_FIELD_MASK'
 1177 | #define REG_FIELD_MASK(reg, field) reg##__##field##_MASK
      |                                    ^~~
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:4063:15: note: in expansion of macro 'REG_SET_FIELD'
 4063 |         tmp = REG_SET_FIELD(tmp, CP_HQD_PQ_CONTROL, ENDIAN_SWAP, 1);
      |               ^~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:4063:34: error: 'CP_HQD_PQ_CONTROL__ENDIAN_SWAP__SHIFT' undeclared (first use in this function); did you mean 'CP_HQD_PQ_CONTROL__PRIV_STATE__SHIFT'?
 4063 |         tmp = REG_SET_FIELD(tmp, CP_HQD_PQ_CONTROL, ENDIAN_SWAP, 1);
      |                                  ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1176:37: note: in definition of macro 'REG_FIELD_SHIFT'
 1176 | #define REG_FIELD_SHIFT(reg, field) reg##__##field##__SHIFT
      |                                     ^~~
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:4063:15: note: in expansion of macro 'REG_SET_FIELD'
 4063 |         tmp = REG_SET_FIELD(tmp, CP_HQD_PQ_CONTROL, ENDIAN_SWAP, 1);
      |               ^~~~~~~~~~~~~

Caused by commit

  028c3fb37e70 ("drm/amdgpu/mes11: initiate mes v11 support")

This build has __BIG_ENDIAN set.

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 5 May 2022 19:14:25 +1000
Subject: [PATCH] mark CONFIG_DRM_AMDGPU as depending on CONFIG_CPU_LITTLE_ENDIAN

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index e88c497fa010..2aaa9ef1168d 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -244,6 +244,7 @@ source "drivers/gpu/drm/radeon/Kconfig"
 config DRM_AMDGPU
 	tristate "AMD GPU"
 	depends on DRM && PCI && MMU
+	depends on CPU_LITTLE_ENDIAN
 	select FW_LOADER
 	select DRM_DISPLAY_DP_HELPER
 	select DRM_DISPLAY_HDMI_HELPER
-- 
2.35.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
[parent not found: <BN9PR12MB5145ECB75120FF9AC1AA4CFB8DEC9@BN9PR12MB5145.namprd12.prod.outlook.com>]
* linux-next: build failure after merge of the amdgpu tree
@ 2022-04-13  2:32 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-04-13  2:32 UTC (permalink / raw)
  To: Alex Deucher
  Cc: David Zhang, Pavle Kotarac, Tom Chung, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c: In function 'is_psr_su_specific_panel':
drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:798:61: error: 'DP_PSR2_WITH_Y_COORD_ET_SUPPORTED' undeclared (first use in this function); did you mean 'DP_PSR2_WITH_Y_COORD_IS_SUPPORTED'?
  798 |                 if (link->dpcd_caps.psr_info.psr_version >= DP_PSR2_WITH_Y_COORD_ET_SUPPORTED)
      |                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                             DP_PSR2_WITH_Y_COORD_IS_SUPPORTED
drivers/gpu/drm/amd/amdgpu/../display/modules/power/power_helpers.c:798:61: note: each undeclared identifier is reported only once for each function it appears in

Caused by commit

  901029aa0017 ("drm/amd/display: implement shared PSR-SU sink validation helper")

Please start including an x86_64 allmodconfig build in your local testing.

I have used the amdgpu tree from next-20220412 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-04-08  4:46 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-04-08  4:46 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Yongqiang Sun, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c:28:10: fatal error: asm/hypervisor.h: No such file or directory
   28 | #include <asm/hypervisor.h>
      |          ^~~~~~~~~~~~~~~~~~

Caused by commit

  49aa98ca30cd ("drm/amd/amdgpu: Only reserve vram for firmware with vega9 MS_HYPERV host.")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-03-07  0:13 Stephen Rothwell
  2022-03-07  7:16 ` Uwe Kleine-König
  2022-03-07 13:04 ` Mark Brown
  0 siblings, 2 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-03-07  0:13 UTC (permalink / raw)
  To: Alex Deucher, Mark Brown
  Cc: Uwe Kleine-König, Maxime Ripard, Noralf Trønnes,
	Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/tiny/panel-mipi-dbi.c:391:19: error: initialization of 'void (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *)' [-Werror=incompatible-pointer-types]
  391 |         .remove = panel_mipi_dbi_spi_remove,
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  0e65e2e6abb0 ("drm/tiny: Add MIPI DBI compatible SPI driver")

interacting with commit

  a0386bba7093 ("spi: make remove callback a void function")

from the spi trees.

I have applied the following merge fix.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 7 Mar 2022 11:01:01 +1100
Subject: [PATCH] fix up for "spi: make remove callback a void function"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/tiny/panel-mipi-dbi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/tiny/panel-mipi-dbi.c b/drivers/gpu/drm/tiny/panel-mipi-dbi.c
index 7f8c6c51387f..c759ff9c2c87 100644
--- a/drivers/gpu/drm/tiny/panel-mipi-dbi.c
+++ b/drivers/gpu/drm/tiny/panel-mipi-dbi.c
@@ -336,14 +336,12 @@ static int panel_mipi_dbi_spi_probe(struct spi_device *spi)
 	return 0;
 }
 
-static int panel_mipi_dbi_spi_remove(struct spi_device *spi)
+static void panel_mipi_dbi_spi_remove(struct spi_device *spi)
 {
 	struct drm_device *drm = spi_get_drvdata(spi);
 
 	drm_dev_unplug(drm);
 	drm_atomic_helper_shutdown(drm);
-
-	return 0;
 }
 
 static void panel_mipi_dbi_spi_shutdown(struct spi_device *spi)
-- 
2.34.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-02-15  0:57 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-02-15  0:57 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Bas Nieuwenhuizen, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c: In function 'dc_construct':
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:991:17: error: implicit declaration of function 'DC_FP_START' [-Werror=implicit-function-declaration]
  991 |                 DC_FP_START();
      |                 ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:993:17: error: implicit declaration of function 'DC_FP_END' [-Werror=implicit-function-declaration]
  993 |                 DC_FP_END();
      |                 ^~~~~~~~~

Caused by commit

  af45a5fe4f0a ("drm/amd/display: Protect update_bw_bounding_box FPU code.")

I have used the amdgpu tree from next-20220214 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-02-01  3:32 Stephen Rothwell
  2022-02-01 18:32 ` Limonciello, Mario
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2022-02-01  3:32 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Mario Limonciello, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:43:
drivers/gpu/drm/amd/amdgpu/amdgpu.h: In function 'amdgpu_acpi_is_s3_active':
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1428:87: error: expected ';' before '}' token
 1428 | static inline bool amdgpu_acpi_is_s3_active(struct amdgpu_device *adev) { return false };
      |                                                                                       ^~
      |                                                                                       ;

(and many more)

Caused by commit

  11bc42ea179d ("drm/amd: add support to check whether the system is set to s3")

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 1 Feb 2022 14:24:40 +1100
Subject: [PATCH] drm/amd: fix semicolon positioning

Fixes: 11bc42ea179d ("drm/amd: add support to check whether the system is set to s3")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index e61078cec072..2931c8ff4cc6 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -1425,7 +1425,7 @@ bool amdgpu_acpi_is_s3_active(struct amdgpu_device *adev);
 bool amdgpu_acpi_is_s0ix_active(struct amdgpu_device *adev);
 #else
 static inline bool amdgpu_acpi_is_s0ix_active(struct amdgpu_device *adev) { return false; }
-static inline bool amdgpu_acpi_is_s3_active(struct amdgpu_device *adev) { return false };
+static inline bool amdgpu_acpi_is_s3_active(struct amdgpu_device *adev) { return false; }
 #endif
 
 int amdgpu_cs_find_mapping(struct amdgpu_cs_parser *parser,
-- 
2.34.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-01-26 23:42 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2022-01-26 23:42 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Tim Huang, Tim Huang, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_dmub_hw_init':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:1030:20: error: unused variable 'dc' [-Werror=unused-variable]
 1030 |         struct dc *dc = adev->dm.dc;
      |                    ^~

Caused by commit

  3b36f50d3a69 ("drm/amd/display: convert to DCE IP version checking")

I have used the amdgu tree from next-20220125 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2022-01-14  0:36 Stephen Rothwell
  2022-01-14 23:25 ` Stephen Rothwell
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2022-01-14  0:36 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linus Torvalds, Linux Kernel Mailing List,
	Linux Next Mailing List, Dave Airlie

[-- Attachment #1: Type: text/plain, Size: 1929 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c: In function 'program_timing_sync':
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:1409:17: error: 'struct dc_config' has no member named 'use_pipe_ctx_sync_logic'
 1409 |   if (dc->config.use_pipe_ctx_sync_logic) {
      |                 ^
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:1412:20: error: 'struct pipe_ctx' has no member named 'pipe_idx_syncd'
 1412 |     if (pipe_set[j]->pipe_idx_syncd == pipe_set[0]->pipe_idx_syncd) {
      |                    ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:1412:51: error: 'struct pipe_ctx' has no member named 'pipe_idx_syncd'
 1412 |     if (pipe_set[j]->pipe_idx_syncd == pipe_set[0]->pipe_idx_syncd) {
      |                                                   ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:1418:17: error: 'struct pipe_ctx' has no member named 'pipe_idx_syncd'
 1418 |      pipe_set[j]->pipe_idx_syncd = pipe_set[0]->pipe_idx_syncd;
      |                 ^~
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:1418:47: error: 'struct pipe_ctx' has no member named 'pipe_idx_syncd'
 1418 |      pipe_set[j]->pipe_idx_syncd = pipe_set[0]->pipe_idx_syncd;
      |                                               ^~

Caused by git doing a bad automatic merge with Linus' tree because commit

  75b950ef6166 ("Revert "drm/amd/display: Fix for otg synchronization logic"")

has been cherry-picked into the amdgpu tree and then a fixed version of
the reverted commit applied on top.  It would be easier if just a
fix up for the oriingal commit was added to the amdgpu tree, or Linus'
tree was merged into the amdgpu tree and then the fixed version applied.

I have used the amdgpu tree from next-20220113 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-12-03  1:11 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-12-03  1:11 UTC (permalink / raw)
  To: Alex Deucher, Dave Airlie, DRI
  Cc: Flora Cui, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 2206 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c: In function 'amdgpu_vkms_sw_fini':
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c:521:34: error: 'struct amdgpu_vkms_output' has no member named 'vblank_hrtimer'
  521 |   if (adev->amdgpu_vkms_output[i].vblank_hrtimer.function)
      |                                  ^
drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c:522:47: error: 'struct amdgpu_vkms_output' has no member named 'vblank_hrtimer'
  522 |    hrtimer_cancel(&adev->amdgpu_vkms_output[i].vblank_hrtimer);
      |                                               ^

Caused by commit

  deefd07eedb7 ("drm/amdgpu: fix vkms crtc settings")

interacting with commit

  3e467e478ed3 ("drm/amdgpu: cancel the correct hrtimer on exit")

from the drm-fixes tree.  The problem is that this latter patch also
appears in the amdgpu tree as a different commit and git resolves it
incorrectly in the presence of the former commit :-(

I have applied the following merge fix patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 3 Dec 2021 12:06:57 +1100
Subject: [PATCH] fix up for "drm/amdgpu: cancel the correct hrtimer on exit"

interacting with "drm/amdgpu: fix vkms crtc settings"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
index e07fc64b655e..6c62c45e3e3e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
@@ -518,8 +518,8 @@ static int amdgpu_vkms_sw_fini(void *handle)
 	int i = 0;
 
 	for (i = 0; i < adev->mode_info.num_crtc; i++)
-		if (adev->amdgpu_vkms_output[i].vblank_hrtimer.function)
-			hrtimer_cancel(&adev->amdgpu_vkms_output[i].vblank_hrtimer);
+		if (adev->mode_info.crtcs[i])
+			hrtimer_cancel(&adev->mode_info.crtcs[i]->vblank_timer);
 
 	kfree(adev->mode_info.bios_hardcoded_edid);
 	kfree(adev->amdgpu_vkms_output);
-- 
2.33.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-11-18  4:23 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-11-18  4:23 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Leo (Hanghong) Ma, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 720 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c: In function 'dp_retrieve_lttpr_cap':
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:4623:4: error: implicit declaration of function 'DC_LOG_DP2'; did you mean 'DC_LOG_DML'? [-Werror=implicit-function-declaration]
 4623 |    DC_LOG_DP2("%s: Read LTTPR caps data failed.\n", __func__);
      |    ^~~~~~~~~~
      |    DC_LOG_DML

Caused by commit

  9c0dc981c97d ("drm/amd/display: Reduce dmesg error to a debug print")

I have used the version of th amdgpu tree from next-20211117 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-10-08  0:31 Stephen Rothwell
  2021-10-08  6:27 ` Simon Ser
  2021-10-12  2:25 ` Stephen Rothwell
  0 siblings, 2 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-10-08  0:31 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Simon Ser, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "get_mm_exe_file" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

Caused by commit

  f4f80155e6e8 ("amd/display: only require overlay plane to cover whole CRTC on ChromeOS")

I have used the amdgpu tree from next-20211007 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-09-29  1:20 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-09-29  1:20 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Michael Strauss, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c: In function 'process_deferred_updates':
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:1808:21: error: 'struct dc' has no member named 'dcn_ip'
 1808 |   for (i = 0; i < dc->dcn_ip->max_num_dpp; i++)
      |                     ^~

Caused by commit

  bfd34644dedb ("drm/amd/display: Defer LUT memory powerdown until LUT bypass latches")

CONFIG_DRM_AMD_DC_DCN is not set for this build.

I have used the amdgpu tree from next-20210928 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-09-17  0:57 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-09-17  0:57 UTC (permalink / raw)
  To: Alex Deucher, Daniel Vetter
  Cc: Andrey Grodzovsky, Linux Kernel Mailing List,
	Linux Next Mailing List, DRI, Intel Graphics

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

In file included from include/drm/ttm/ttm_bo_driver.h:40,
                 from include/drm/drm_gem_ttm_helper.h:11,
                 from drivers/gpu/drm/drm_gem_ttm_helper.c:5:
include/drm/ttm/ttm_device.h:274:19: error: duplicate member 'pinned'
  274 |  struct list_head pinned;
      |                   ^~~~~~

Caused by commit

  59084e464297 ("drm/ttm: Create pinned list")

interacting with commit

  32eadf52d449 ("drm/ttm: Create pinned list")

from the drm-misc tree.

The automatic merge proved incorrect, so I have removed one of the
insertions.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: Build failure after merge of the amdgpu tree
@ 2021-08-02 15:55 Mark Brown
  0 siblings, 0 replies; 138+ messages in thread
From: Mark Brown @ 2021-08-02 15:55 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Alex Deucher, Linux Kernel Mailing List, Linux Next Mailing List,
	Eric Huang

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

Hi all,

Today's linux-next merge of the amdgpu tree failed to build an x86
allmodconfig due to:

/tmp/next/build/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In function 'amdgpu_amdkfd_gpuvm_map_memory_to_gpu':
/tmp/next/build/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1723:6: error: 'table_freed' undeclared (first use in this function); did you mean 'HPG_freed'?
  if (table_freed && (adev->asic_type != CHIP_ALDEBARAN))
      ^~~~~~~~~~~
      HPG_freed

Probably due to f451e2cab940791c1 (Revert "Revert "drm/amdkfd: Only
apply TLB flush optimization on ALdebaran"").

I will use the amdgpu tree from Friday instead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-07-28 12:34 Mark Brown
  0 siblings, 0 replies; 138+ messages in thread
From: Mark Brown @ 2021-07-28 12:34 UTC (permalink / raw)
  To: Alex Deucher, Christian König, Pan Xinhui, Leung Martin,
	Solomon Chiu, Mark Morra, Daniel Wheeler
  Cc: Linux Kernel Mailing List, Linux Next Mailing List, amd-gfx, dri-devel

Hi all,

After merging the amdgpu tree, today's linux-next build (x86
allmodconfig) failed like this:

ERROR: modpost: "dc_dsc_stream_bandwidth_in_kbps" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

Probably caused by commit

  b6b76b0315ed7b ("drm/amd/display: Fixed EdidUtility build errors")

I've reverted to Monday's tree.

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-05-27  5:58 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-05-27  5:58 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

ld: drivers/gpu/drm/amd/amdgpu/amdgpu_device.o:(.opd+0x408): multiple definition of `amdgpu_acpi_detect'; drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o:(.opd+0x1c8): first defined here
ld: drivers/gpu/drm/amd/amdgpu/amdgpu_device.o: in function `.amdgpu_acpi_detect':
amdgpu_device.c:(.text.amdgpu_acpi_detect+0x0): multiple definition of `.amdgpu_acpi_detect'; drivers/gpu/drm/amd/amdgpu/amdgpu_drv.o:amdgpu_drv.c:(.text.amdgpu_acpi_detect+0x0): first defined here

and many, many more.

Caused by commit

  753c7d6d85f5 ("drm/amdgpu/acpi: make ATPX/ATCS structures global")

The !defined(CONFIG_ACPI) version of amdgpu_acpi_detect() is missing
"static inline" ...

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-05-04 23:34 Stephen Rothwell
  2021-05-09 22:46 ` Stephen Rothwell
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2021-05-04 23:34 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Jude Shih, Hanghong Ma, Nicholas Kazlauskas, Daniel Wheeler,
	Linux Kernel Mailing List, Linux Next Mailing List, Dave Airlie

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_initialize_drm_device':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:3728:7: error: implicit declaration of function 'register_outbox_irq_handlers'; did you mean 'register_hpd_handlers'? [-Werror=implicit-function-declaration]
 3728 |   if (register_outbox_irq_handlers(dm->adev)) {
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |       register_hpd_handlers

Caused by commit

  77a49c458931 ("drm/amd/display: Support for DMUB AUX")

I have used the amdgpu tree from next-20210504 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-03-30  2:18 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-03-30  2:18 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Wesley Chalmers, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c: In function 'commit_planes_for_stream':
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2608:13: error: 'struct pipe_ctx' has no member named 'ttu_regs'
 2608 |     odm_pipe->ttu_regs.min_ttu_vblank = MAX_TTU;
      |             ^~

Caused by commit

  752106f5c5cd ("drm/amd/display: Set max TTU on DPG enable")

CONFIG_DRM_AMD_DC_DCN is not set in this build.

I have used the amdgpu tree from next-20210329 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-03-19  1:21 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-03-19  1:21 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Dillon Varone, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

ERROR: modpost: "dc_dsc_stream_bandwidth_in_kbps" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

Caused by commit

  a03f6c0e26b2 ("drm/amd/display: Add changes for dsc bpp in 16ths and unify bw calculations")

I have used the amdgpu tree from next-20210318 fot today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-02-23  1:11 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-02-23  1:11 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Qingqing Zhuo, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 5541 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/kernel.h:15,
                 from include/linux/list.h:9,
                 from include/linux/kprobes.h:21,
                 from include/linux/kgdb.h:19,
                 from drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:30,
                 from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:29,
                 from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:29:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5465:38: error: 'flags' undeclared (first use in this function)
 5465 |  spin_lock_irqsave(&dm->vblank_lock, flags);
      |                                      ^~~~~
include/linux/typecheck.h:11:9: note: in definition of macro 'typecheck'
   11 |  typeof(x) __dummy2; \
      |         ^
include/linux/spinlock.h:384:2: note: in expansion of macro 'raw_spin_lock_irqsave'
  384 |  raw_spin_lock_irqsave(spinlock_check(lock), flags); \
      |  ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5465:2: note: in expansion of macro 'spin_lock_irqsave'
 5465 |  spin_lock_irqsave(&dm->vblank_lock, flags);
      |  ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5465:38: note: each undeclared identifier is reported only once for each function it appears in
 5465 |  spin_lock_irqsave(&dm->vblank_lock, flags);
      |                                      ^~~~~
include/linux/typecheck.h:11:9: note: in definition of macro 'typecheck'
   11 |  typeof(x) __dummy2; \
      |         ^
include/linux/spinlock.h:384:2: note: in expansion of macro 'raw_spin_lock_irqsave'
  384 |  raw_spin_lock_irqsave(spinlock_check(lock), flags); \
      |  ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5465:2: note: in expansion of macro 'spin_lock_irqsave'
 5465 |  spin_lock_irqsave(&dm->vblank_lock, flags);
      |  ^~~~~~~~~~~~~~~~~
include/linux/typecheck.h:12:18: warning: comparison of distinct pointer types lacks a cast
   12 |  (void)(&__dummy == &__dummy2); \
      |                  ^~
include/linux/spinlock.h:251:3: note: in expansion of macro 'typecheck'
  251 |   typecheck(unsigned long, flags); \
      |   ^~~~~~~~~
include/linux/spinlock.h:384:2: note: in expansion of macro 'raw_spin_lock_irqsave'
  384 |  raw_spin_lock_irqsave(spinlock_check(lock), flags); \
      |  ^~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5465:2: note: in expansion of macro 'spin_lock_irqsave'
 5465 |  spin_lock_irqsave(&dm->vblank_lock, flags);
      |  ^~~~~~~~~~~~~~~~~
In file included from include/linux/rwsem.h:16,
                 from include/linux/notifier.h:15,
                 from include/linux/kprobes.h:22,
                 from include/linux/kgdb.h:19,
                 from drivers/gpu/drm/amd/amdgpu/../display/dc/os_types.h:30,
                 from drivers/gpu/drm/amd/amdgpu/../display/dc/dm_services_types.h:29,
                 from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:29:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5465:23: error: 'struct amdgpu_display_manager' has no member named 'vblank_lock'
 5465 |  spin_lock_irqsave(&dm->vblank_lock, flags);
      |                       ^~
include/linux/spinlock.h:252:34: note: in definition of macro 'raw_spin_lock_irqsave'
  252 |   flags = _raw_spin_lock_irqsave(lock); \
      |                                  ^~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5465:2: note: in expansion of macro 'spin_lock_irqsave'
 5465 |  spin_lock_irqsave(&dm->vblank_lock, flags);
      |  ^~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5466:6: error: 'struct amdgpu_display_manager' has no member named 'vblank_workqueue'; did you mean 'hdcp_workqueue'?
 5466 |  dm->vblank_workqueue->dm = dm;
      |      ^~~~~~~~~~~~~~~~
      |      hdcp_workqueue
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5467:6: error: 'struct amdgpu_display_manager' has no member named 'vblank_workqueue'; did you mean 'hdcp_workqueue'?
 5467 |  dm->vblank_workqueue->otg_inst = acrtc->otg_inst;
      |      ^~~~~~~~~~~~~~~~
      |      hdcp_workqueue
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5468:6: error: 'struct amdgpu_display_manager' has no member named 'vblank_workqueue'; did you mean 'hdcp_workqueue'?
 5468 |  dm->vblank_workqueue->enable = enable;
      |      ^~~~~~~~~~~~~~~~
      |      hdcp_workqueue
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5469:28: error: 'struct amdgpu_display_manager' has no member named 'vblank_lock'
 5469 |  spin_unlock_irqrestore(&dm->vblank_lock, flags);
      |                            ^~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5470:21: error: 'struct amdgpu_display_manager' has no member named 'vblank_workqueue'; did you mean 'hdcp_workqueue'?
 5470 |  schedule_work(&dm->vblank_workqueue->mall_work);
      |                     ^~~~~~~~~~~~~~~~
      |                     hdcp_workqueue

Caused by commit

  9d99a805a9a0 ("drm/amd/display: Fix system hang after multiple hotplugs")

I have used the amdgpu tree from next-20210222 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-02-05  2:12 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-02-05  2:12 UTC (permalink / raw)
  To: Alex Deucher, Dave Airlie, DRI
  Cc: Arnd Bergmann, Bhawanpreet Lakha, Linux Kernel Mailing List,
	Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 391 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:


Caused by commit

  13a75af50484 ("drm/amd/display: Fix unused variable warning")

interacting with commit

  4c3a3292730c ("drm/amd/display: fix unused variable warning")

from the drm tree.

I reverted the drm tree commit for now.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-01-15  5:35 Stephen Rothwell
  2021-01-15  5:57 ` Huang Rui
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2021-01-15  5:35 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Huang Rui, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function 'vangogh_get_smu_metrics_data':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:300:10: error: 'boot_cpu_data' undeclared (first use in this function); did you mean 'boot_cpuid'?
  300 |          boot_cpu_data.x86_max_cores * sizeof(uint16_t));
      |          ^~~~~~~~~~~~~
      |          boot_cpuid
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function 'vangogh_read_sensor':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1320:11: error: 'boot_cpu_data' undeclared (first use in this function); did you mean 'boot_cpuid'?
 1320 |   *size = boot_cpu_data.x86_max_cores * sizeof(uint16_t);
      |           ^~~~~~~~~~~~~
      |           boot_cpuid
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function 'vangogh_od_edit_dpm_table':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1460:19: error: 'boot_cpu_data' undeclared (first use in this function); did you mean 'boot_cpuid'?
 1460 |   if (input[0] >= boot_cpu_data.x86_max_cores) {
      |                   ^~~~~~~~~~~~~
      |                   boot_cpuid

Caused by commits

  517cb957c43b ("drm/amd/pm: implement the processor clocks which read by metric")
  0d90d0ddd10e ("drm/amd/pm: implement processor fine grain feature for vangogh (v3)")

The only thing I could do easily is to disable CONFIG_DRM_AMDGPU for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2021-01-08  1:17 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2021-01-08  1:17 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Bhawanpreet Lakha, Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'dm_set_vblank':
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5493:2: error: implicit declaration of function 'dc_allow_idle_optimizations' [-Werror=implicit-function-declaration]
 5493 |  dc_allow_idle_optimizations(
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  71338cb4a7c2 ("drm/amd/display: enable idle optimizations for linux (MALL stutter)")

I have used the amdgpu tree from next-20210107 for today.
dc_allow_idle_optimizations() is only declared when CONFIG_DRM_AMD_DC_DCN
is set.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2020-10-27  1:08 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2020-10-27  1:08 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Kernel Mailing List, Linux Next Mailing List

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:


Presumably caused by commit

  c03c025c87f2 ("drm/amdgpu: fold CONFIG_DRM_AMD_DC_DCN3* into CONFIG_DRM_AMD_DC_DCN")

I have used the amdgpu tree from next-20201026 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2020-06-17  0:26 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2020-06-17  0:26 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Lewis Huang,
	Aric Cyr, Qingqing Zhuo

[-- Attachment #1: Type: text/plain, Size: 584 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: modpost: "mod_color_is_table_init" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: modpost: "mod_color_get_table" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: modpost: "mod_color_set_table_init_state" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

Caused by commit

  4a9025f397c6 ("drm/amd/display: change global buffer to local buffer")

I have used the amdgpu tree from next-20200616 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2020-06-12  0:25 Stephen Rothwell
  2020-06-26  1:47 ` Stephen Rothwell
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2020-06-12  0:25 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Mukul Joshi,
	Christoph Hellwig, Andrew Morton

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c: In function 'kfd_sdma_activity_worker':
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:118:2: error: implicit declaration of function 'use_mm' [-Werror=implicit-function-declaration]
  118 |  use_mm(mm);
      |  ^~~~~~
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:145:2: error: implicit declaration of function 'unuse_mm' [-Werror=implicit-function-declaration]
  145 |  unuse_mm(mm);
      |  ^~~~~~~~

Caused by commit

  32cb59f31362 ("drm/amdkfd: Track SDMA utilization per process")

interacting with commit

  f5678e7f2ac3 ("kernel: better document the use_mm/unuse_mm API contract")

from Linus' tree.

I have applied the following merge fix for today (that was previously
part of the akpm tree).

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 28 May 2020 20:15:34 +1000
Subject: [PATCH] drm/amdkfd: fix up for {un}use_mm() rename

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
index db010c5da144..25636789f3d3 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
@@ -114,7 +114,7 @@ static void kfd_sdma_activity_worker(struct work_struct *work)
 		return;
 	}
 
-	use_mm(mm);
+	kthread_use_mm(mm);
 
 	dqm_lock(dqm);
 
@@ -141,7 +141,7 @@ static void kfd_sdma_activity_worker(struct work_struct *work)
 	}
 
 	dqm_unlock(dqm);
-	unuse_mm(mm);
+	kthread_unuse_mm(mm);
 	mmput(mm);
 }
 
-- 
2.26.2

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2020-02-11 22:48 Stephen Rothwell
  2020-02-12 16:14 ` Rodrigo Siqueira
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2020-02-11 22:48 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Dmytro Laktyushkin, Eric Yang, Michael Strauss, Rodrigo Siqueira

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "get_num_odm_splits" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

Presumably caused by commit

  5bf24270d1cc ("drm/amd/display: add odm split logic to scaling calculations")

I used the amdgpu tree from next-20200211 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2020-01-28  4:42 Stephen Rothwell
  2020-01-28 21:18 ` Alex Deucher
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2020-01-28  4:42 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Tianci.Yin

[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/psp_v11_0.c: In function 'psp_v11_0_memory_training':
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c:1047:9: error: implicit declaration of function 'vmalloc'; did you mean 'kvmalloc'? [-Werror=implicit-function-declaration]
 1047 |   buf = vmalloc(sz);
      |         ^~~~~~~
      |         kvmalloc
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c:1047:7: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
 1047 |   buf = vmalloc(sz);
      |       ^
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c:1057:4: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
 1057 |    vfree(buf);
      |    ^~~~~
      |    kvfree

Caused by commit

  240c811ccde4 ("drm/amdgpu: fix VRAM partially encroached issue in GDDR6 memory training(V2)")

I have applied this patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 28 Jan 2020 15:33:44 +1100
Subject: [PATCH] amdgpu: using vmalloc requires includeing vmalloc.h

Fixes: 240c811ccde4 ("drm/amdgpu: fix VRAM partially encroached issue in GDDR6 memory training(V2)")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
index ac173d2eb809..0829188c1a5c 100644
--- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
@@ -22,6 +22,7 @@
 
 #include <linux/firmware.h>
 #include <linux/module.h>
+#include <linux/vmalloc.h>
 
 #include "amdgpu.h"
 #include "amdgpu_psp.h"
-- 
2.24.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2020-01-08  2:18 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2020-01-08  2:18 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, David Francis

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "dcn20_add_dsc_to_stream_resource" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "dc_dsc_parse_dsc_dpcd" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "dc_dsc_get_policy_for_timing" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "dc_dsc_compute_bandwidth_range" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "dc_dsc_compute_config" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

I am not sure what caused this.

I have used the amdgpu tree from next-20200107 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2019-11-08  5:31 Stephen Rothwell
  2019-11-08 15:50 ` Grodzovsky, Andrey
  2019-11-08 15:59 ` Alex Deucher
  0 siblings, 2 replies; 138+ messages in thread
From: Stephen Rothwell @ 2019-11-08  5:31 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Andrey Grodzovsky, Christian König

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from <command-line>:
include/drm/gpu_scheduler.h:98:21: error: field 'entity_idle' has incomplete type
   98 |  struct completion  entity_idle;
      |                     ^~~~~~~~~~~

followed by lots of similar errors.

Caused by commit

  83a7772ba223 ("drm/sched: Use completion to wait for sched->thread idle v2.")

I added the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 8 Nov 2019 16:21:32 +1100
Subject: [PATCH] drm/sched: struct completion requires linux/completion.h
 inclusion

Fixes: 83a7772ba223 ("drm/sched: Use completion to wait for sched->thread idle v2.")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/drm/gpu_scheduler.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
index 6619d2ac6fa3..684692a8ed76 100644
--- a/include/drm/gpu_scheduler.h
+++ b/include/drm/gpu_scheduler.h
@@ -26,6 +26,7 @@
 
 #include <drm/spsc_queue.h>
 #include <linux/dma-fence.h>
+#include <linux/completion.h>
 
 #define MAX_WAIT_SCHED_ENTITY_Q_EMPTY msecs_to_jiffies(1000)
 
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2019-11-07  0:46 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2019-11-07  0:46 UTC (permalink / raw)
  To: Alex Deucher; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "dc_dsc_parse_dsc_dpcd" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: "dc_dsc_compute_config" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

I am not sure what caused this, but CONFIG_DRM_AMD_DC_DCN is not set
for this build.

I have used the amdgpu tree from next-20191106 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2019-08-13  8:10 Stephen Rothwell
  2019-08-13  8:21 ` Huang, Ray
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2019-08-13  8:10 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Aaron Liu, Huang Rui

[-- Attachment #1: Type: text/plain, Size: 1255 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/gpu/drm/amd/amdgpu/psp_v12_0.c:39:17: error: expected declaration specifiers or '...' before string constant
 MODULE_FIRMWARE("amdgpu/renoir_asd.bin");
                 ^~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  6a7a0bdbfa0c ("drm/amdgpu: add psp_v12_0 for renoir (v2)")

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 13 Aug 2019 18:03:16 +1000
Subject: [PATCH] drm/amdgpu: MODULE_FIRMWARE requires linux/module.h

Fixes: 6a7a0bdbfa0c ("drm/amdgpu: add psp_v12_0 for renoir (v2)")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/amd/amdgpu/psp_v12_0.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c
index f37b8af4b986..b474dfb79375 100644
--- a/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/psp_v12_0.c
@@ -21,6 +21,7 @@
  */
 
 #include <linux/firmware.h>
+#include <linux/module.h>
 #include "amdgpu.h"
 #include "amdgpu_psp.h"
 #include "amdgpu_ucode.h"
-- 
2.20.1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply related	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2019-06-26 11:22 Stephen Rothwell
  2019-06-27  3:35 ` Stephen Rothwell
  0 siblings, 1 reply; 138+ messages in thread
From: Stephen Rothwell @ 2019-06-26 11:22 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Hawking Zhang, Huang Rui

[-- Attachment #1: Type: text/plain, Size: 2342 bytes --]

Hi Alex,

After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) failed like this:

In file included from drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:25:
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c: In function 'gfx_v10_0_cp_gfx_resume':
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:2628:27: error: 'CP_RB1_CNTL__BUF_SWAP_MASK' undeclared (first use in this function); did you mean 'CP_RB_CNTL__BUF_SWAP_MASK'?
  tmp = REG_SET_FIELD(tmp, CP_RB1_CNTL, BUF_SWAP, 1);
                           ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1067:36: note: in definition of macro 'REG_FIELD_MASK'
 #define REG_FIELD_MASK(reg, field) reg##__##field##_MASK
                                    ^~~
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:2628:8: note: in expansion of macro 'REG_SET_FIELD'
  tmp = REG_SET_FIELD(tmp, CP_RB1_CNTL, BUF_SWAP, 1);
        ^~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:2628:27: note: each undeclared identifier is reported only once for each function it appears in
  tmp = REG_SET_FIELD(tmp, CP_RB1_CNTL, BUF_SWAP, 1);
                           ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1067:36: note: in definition of macro 'REG_FIELD_MASK'
 #define REG_FIELD_MASK(reg, field) reg##__##field##_MASK
                                    ^~~
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:2628:8: note: in expansion of macro 'REG_SET_FIELD'
  tmp = REG_SET_FIELD(tmp, CP_RB1_CNTL, BUF_SWAP, 1);
        ^~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:2628:27: error: 'CP_RB1_CNTL__BUF_SWAP__SHIFT' undeclared (first use in this function); did you mean 'CP_RB0_CNTL__BUF_SWAP__SHIFT'?
  tmp = REG_SET_FIELD(tmp, CP_RB1_CNTL, BUF_SWAP, 1);
                           ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/amdgpu.h:1066:37: note: in definition of macro 'REG_FIELD_SHIFT'
 #define REG_FIELD_SHIFT(reg, field) reg##__##field##__SHIFT
                                     ^~~
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:2628:8: note: in expansion of macro 'REG_SET_FIELD'
  tmp = REG_SET_FIELD(tmp, CP_RB1_CNTL, BUF_SWAP, 1);
        ^~~~~~~~~~~~~

Caused by commit

  a644d85a5cd4 ("drm/amdgpu: add gfx v10 implementation (v10)")

I have disabled that driver for today.  Please let me know when it is
fixed so that I can enable it again.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2019-06-24  4:24 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2019-06-24  4:24 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Kevin Wang,
	Huang Rui

[-- Attachment #1: Type: text/plain, Size: 3164 bytes --]

Hi Alex,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from include/linux/kernel.h:15,
                 from include/asm-generic/bug.h:18,
                 from arch/x86/include/asm/bug.h:83,
                 from include/linux/bug.h:5,
                 from include/linux/mmdebug.h:5,
                 from include/linux/gfp.h:5,
                 from include/linux/firmware.h:7,
                 from drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:23:
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c: In function 'smu_v11_0_irq_process':
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1542:5: error: implicit declaration of function 'PCI_BUS_NUM' [-Werror=implicit-function-declaration]
     PCI_BUS_NUM(adev->pdev->devfn),
     ^~~~~~~~~~~
include/linux/printk.h:306:37: note: in definition of macro 'pr_warning'
  printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
                                     ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1541:4: note: in expansion of macro 'pr_warn'
    pr_warn("GPU over temperature range detected on PCIe %d:%d.%d!\n",
    ^~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1542:27: error: dereferencing pointer to incomplete type 'struct pci_dev'
     PCI_BUS_NUM(adev->pdev->devfn),
                           ^~
include/linux/printk.h:306:37: note: in definition of macro 'pr_warning'
  printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
                                     ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1541:4: note: in expansion of macro 'pr_warn'
    pr_warn("GPU over temperature range detected on PCIe %d:%d.%d!\n",
    ^~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1543:5: error: implicit declaration of function 'PCI_SLOT'; did you mean 'CC_SET'? [-Werror=implicit-function-declaration]
     PCI_SLOT(adev->pdev->devfn),
     ^~~~~~~~
include/linux/printk.h:306:37: note: in definition of macro 'pr_warning'
  printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
                                     ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1541:4: note: in expansion of macro 'pr_warn'
    pr_warn("GPU over temperature range detected on PCIe %d:%d.%d!\n",
    ^~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1544:5: error: implicit declaration of function 'PCI_FUNC'; did you mean 'STT_FUNC'? [-Werror=implicit-function-declaration]
     PCI_FUNC(adev->pdev->devfn));
     ^~~~~~~~
include/linux/printk.h:306:37: note: in definition of macro 'pr_warning'
  printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
                                     ^~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../powerplay/smu_v11_0.c:1541:4: note: in expansion of macro 'pr_warn'
    pr_warn("GPU over temperature range detected on PCIe %d:%d.%d!\n",
    ^~~~~~~
cc1: some warnings being treated as errors

Caused by commit

  5e6d266573db ("drm/amd/powerplay: add thermal ctf support for navi10")

I have used the amdgu tree from next-20190621 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread
* linux-next: build failure after merge of the amdgpu tree
@ 2019-03-19  0:04 Stephen Rothwell
  0 siblings, 0 replies; 138+ messages in thread
From: Stephen Rothwell @ 2019-03-19  0:04 UTC (permalink / raw)
  To: Alex Deucher
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	David Francis, Harry Wentland, Leo Li, Nicholas Kazlauskas

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hi all,

After merging the amdgpu tree, today's linux-next build (x86_64
allmodconfig) failed like this:


ERROR: "get_vupdate_offset_from_vsync" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

Caused by commit

  67b112ed997b ("drm/amd/display: On DCN1, Wait for vupdate on cursor updates")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 138+ messages in thread

end of thread, other threads:[~2024-02-13 14:00 UTC | newest]

Thread overview: 138+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-25 11:16 linux-next: build failure after merge of the amdgpu tree Stephen Rothwell
2022-07-27 16:21 ` Rodrigo Siqueira Jordao
2022-07-27 16:23   ` Alex Deucher
  -- strict thread matches above, loose matches on Subject: below --
2024-02-13  4:00 Stephen Rothwell
2024-02-13 14:00 ` Alex Deucher
2023-10-10  1:43 Stephen Rothwell
2023-10-10 21:14 ` Rodrigo Siqueira Jordao
2023-10-16  0:39   ` Stephen Rothwell
2023-10-16 14:53     ` Rodrigo Siqueira Jordao
2023-10-16 20:59       ` Stephen Rothwell
2023-10-17  1:08         ` Stephen Rothwell
2023-10-16  0:18 ` Stephen Rothwell
2023-10-19  1:06 ` Stephen Rothwell
2023-10-24  0:59   ` Stephen Rothwell
2023-10-24 12:57     ` Alex Deucher
2023-10-24 19:52       ` Alex Deucher
2023-10-24 21:47       ` Stephen Rothwell
2023-05-22  7:15 Stephen Rothwell
2023-05-22 16:29 ` Nick Desaulniers
2023-05-22 16:35   ` Alex Deucher
2023-05-22 16:47     ` Nick Desaulniers
2023-05-22 19:14       ` Alex Deucher
2023-05-22  7:11 Stephen Rothwell
2023-05-22  7:24 ` Lazar, Lijo
2023-05-22  7:00 Stephen Rothwell
2023-05-22  7:04 ` Zhang, Hawking
2023-05-19  0:06 Stephen Rothwell
2023-05-19  3:10 ` James Zhu
2023-05-19 13:38 ` Alex Deucher
2023-01-30  1:20 Stephen Rothwell
2022-10-31  0:13 Stephen Rothwell
2022-08-30  1:41 Stephen Rothwell
2022-07-19  2:36 Stephen Rothwell
2022-07-20  2:47 ` Stephen Rothwell
2022-07-21  2:16   ` Stephen Rothwell
2022-07-22  2:52     ` Stephen Rothwell
2022-07-22 13:30       ` Alex Deucher
2022-06-23  6:07 Stephen Rothwell
2022-06-23 11:01 ` Greg KH
2022-06-27 14:40 ` Greg KH
2022-06-15  4:37 Stephen Rothwell
2022-06-15 18:17 ` Alex Deucher
2022-06-14  4:51 Stephen Rothwell
2022-06-03  4:43 Stephen Rothwell
2022-06-09  3:14 ` Stephen Rothwell
2022-06-15  5:00 ` Stephen Rothwell
2022-06-21  8:15   ` Stephen Rothwell
2022-06-21 15:02     ` Alex Deucher
2022-06-21 22:07       ` Stephen Rothwell
2022-06-22 14:48         ` Alex Deucher
2022-06-23  7:47           ` Stephen Rothwell
2022-06-02  0:30 Stephen Rothwell
2022-05-06  1:06 Stephen Rothwell
2022-05-05  9:47 Stephen Rothwell
2022-05-05 18:12 ` Nathan Chancellor
2022-05-05 18:46   ` Alex Deucher
2022-05-06  1:05     ` Stephen Rothwell
     [not found] <BN9PR12MB5145ECB75120FF9AC1AA4CFB8DEC9@BN9PR12MB5145.namprd12.prod.outlook.com>
2022-04-13 14:18 ` Alex Deucher
     [not found]   ` <BN9PR12MB5145D81F9978B656E9BB67C78DEF9@BN9PR12MB5145.namprd12.prod.outlook.com>
2022-04-14 14:23     ` Rodrigo Siqueira Jordao
2022-04-14 14:27       ` Alex Deucher
2022-04-14 14:31         ` Rodrigo Siqueira Jordao
2022-04-13  2:32 Stephen Rothwell
2022-04-08  4:46 Stephen Rothwell
2022-03-07  0:13 Stephen Rothwell
2022-03-07  7:16 ` Uwe Kleine-König
2022-03-07 13:04 ` Mark Brown
2022-03-08 11:15   ` Noralf Trønnes
2022-02-15  0:57 Stephen Rothwell
2022-02-01  3:32 Stephen Rothwell
2022-02-01 18:32 ` Limonciello, Mario
2022-02-01 18:53   ` Alex Deucher
2022-01-26 23:42 Stephen Rothwell
2022-01-14  0:36 Stephen Rothwell
2022-01-14 23:25 ` Stephen Rothwell
2021-12-03  1:11 Stephen Rothwell
2021-11-18  4:23 Stephen Rothwell
2021-10-08  0:31 Stephen Rothwell
2021-10-08  6:27 ` Simon Ser
2021-10-08  8:29   ` Stephen Rothwell
2021-10-08  9:22     ` Simon Ser
2021-10-08 14:11       ` Alex Deucher
2021-10-08 18:07         ` Simon Ser
2021-10-11  7:33           ` Christoph Hellwig
2021-10-11  7:39             ` Simon Ser
2021-10-11  7:43               ` Christoph Hellwig
2021-10-11  7:49                 ` Simon Ser
2021-10-11  7:51                   ` Christoph Hellwig
2021-10-11  7:57                     ` Simon Ser
2021-10-11  8:01                       ` Christoph Hellwig
2021-10-11  8:21                         ` Simon Ser
2021-10-09  4:57       ` Stephen Rothwell
2021-10-12  2:25 ` Stephen Rothwell
2021-10-12 13:32   ` Alex Deucher
2021-09-29  1:20 Stephen Rothwell
2021-09-17  0:57 Stephen Rothwell
2021-08-02 15:55 linux-next: Build " Mark Brown
2021-07-28 12:34 linux-next: build " Mark Brown
2021-05-27  5:58 Stephen Rothwell
2021-05-04 23:34 Stephen Rothwell
2021-05-09 22:46 ` Stephen Rothwell
2021-05-10 14:24   ` Alex Deucher
2021-05-10 22:18     ` Stephen Rothwell
2021-05-10 22:23       ` Alex Deucher
2021-05-10 23:02         ` Stephen Rothwell
2021-03-30  2:18 Stephen Rothwell
2021-03-19  1:21 Stephen Rothwell
2021-02-23  1:11 Stephen Rothwell
2021-02-05  2:12 Stephen Rothwell
2021-01-15  5:35 Stephen Rothwell
2021-01-15  5:57 ` Huang Rui
2021-01-15  8:46   ` Huang, Ray
2021-01-15 14:56     ` Alex Deucher
2021-01-08  1:17 Stephen Rothwell
2020-10-27  1:08 Stephen Rothwell
2020-06-17  0:26 Stephen Rothwell
2020-06-12  0:25 Stephen Rothwell
2020-06-26  1:47 ` Stephen Rothwell
2020-02-11 22:48 Stephen Rothwell
2020-02-12 16:14 ` Rodrigo Siqueira
2020-01-28  4:42 Stephen Rothwell
2020-01-28 21:18 ` Alex Deucher
2020-01-08  2:18 Stephen Rothwell
2019-11-08  5:31 Stephen Rothwell
2019-11-08 15:50 ` Grodzovsky, Andrey
2019-11-08 15:59 ` Alex Deucher
2019-11-07  0:46 Stephen Rothwell
2019-08-13  8:10 Stephen Rothwell
2019-08-13  8:21 ` Huang, Ray
2019-08-13 14:01   ` Alex Deucher
2019-08-16  0:21     ` Stephen Rothwell
2019-08-16  1:52       ` Alex Deucher
2019-08-16  2:43         ` Stephen Rothwell
2019-06-26 11:22 Stephen Rothwell
2019-06-27  3:35 ` Stephen Rothwell
2019-06-27 14:18   ` Alex Deucher
2019-06-27 22:01     ` Stephen Rothwell
2019-06-24  4:24 Stephen Rothwell
2019-03-19  0:04 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).