From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751468AbdBICHp (ORCPT ); Wed, 8 Feb 2017 21:07:45 -0500 Received: from mail-yb0-f196.google.com ([209.85.213.196]:35688 "EHLO mail-yb0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbdBICHn (ORCPT ); Wed, 8 Feb 2017 21:07:43 -0500 MIME-Version: 1.0 In-Reply-To: <20170203202342.13128-1-colin.king@canonical.com> References: <20170203202342.13128-1-colin.king@canonical.com> From: Alex Deucher Date: Wed, 8 Feb 2017 21:07:41 -0500 Message-ID: Subject: Re: [PATCH] drm/amdgpu/virt: fix double kfree on bo_va To: Colin King Cc: Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Monk Liu , Xiangliang Yu , amd-gfx list , Maling list - DRI developers , kernel-janitors@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 3, 2017 at 3:23 PM, Colin King wrote: > From: Colin Ian King > > bo_va is being kfree'd twice, once in the call to amdgpu_vm_bo_rmv > and then a short while later. Fix this double free by removing > the 2nd kfree. > > Detected by CoverityScan, CID#1399524 ("Double Free") > > Signed-off-by: Colin Ian King Applied. thanks! > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > index 3fd951c..dcfb7df 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > @@ -83,7 +83,6 @@ int amdgpu_map_static_csa(struct amdgpu_device *adev, struct amdgpu_vm *vm) > DRM_ERROR("failed to do bo_map on static CSA, err=%d\n", r); > amdgpu_vm_bo_rmv(adev, bo_va); > ttm_eu_backoff_reservation(&ticket, &list); > - kfree(bo_va); > return r; > } > > -- > 2.10.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel