From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C26F4C388F7 for ; Tue, 10 Nov 2020 22:00:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78EE620809 for ; Tue, 10 Nov 2020 22:00:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j2cdkNt2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732209AbgKJWAF (ORCPT ); Tue, 10 Nov 2020 17:00:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732199AbgKJWAD (ORCPT ); Tue, 10 Nov 2020 17:00:03 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D195FC0613D1; Tue, 10 Nov 2020 14:00:02 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id 10so4713027wml.2; Tue, 10 Nov 2020 14:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kQXXRFyXwxRS/I2RgZpEGIowDOXzMpZPv5s9Y3k7QhI=; b=j2cdkNt2/4bsAh1RBkbd/u0wSdArQ78T4xxdeBsW+/M6f6LD/81+RHepLgSU8jEJ9c f9WemXa2FyA/zxrsTylztAKXuq0YJuj9cxdDPXcF7kjC/E/wnutNAoTNsa9/fRwyPiWc +78MWhXNIm57moM4vMRvWf1DcGUnsFSno5zHoldcv7YKQV4FGO0ZtFk2dcIByjtQAluG A1AXBA7Dw8JTOoDYGL3iJ5mulzzCccTJTlyU+yBela+/iTpOeOh4bAXiakRfdECIEnLG 1LS6PeRzptHzcsSiTkg+tTBbKxjaYaB3ughnn3vmOkXcH4rq3iY2DLIXN3VvS84y2WHj K6PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kQXXRFyXwxRS/I2RgZpEGIowDOXzMpZPv5s9Y3k7QhI=; b=X1Bh8GyxLUyYypWMtHSgJYlKd8HGsPB753k0yBgG4iKo3YIU2uPRPg5ehZYGovTx17 nQIdJJAq63aF8eXNiQ1tk4+cVbTpxDLMUSgpbKtj5X4G0GYKa9TL10vT+wu7BV/W4VD7 Qicywt36K0waTQzkKzP6Rg8YvSQk1V7THpnoKTsurtoXNmT6ceLarcGOVA72b0bypD8l qTEDPKzNT9oSllMqHBoZZsGmm8Zb4hMK/PLoEOAjg2vqeByKKJQc3GHU1dnXcwIws7bT 7vsxtucJ1MTCtHDWNQFyKOolOlDvEFENKEplkxBjwcegbI9Oz1nFvsgxpV1Grw+PDosm ozVA== X-Gm-Message-State: AOAM530kU0CKxEaosbXFkPAQ95LHDy6u4Dh2MPrSZZ1aiDZAhwXg/hLM AeNRxljl7cQkqnBIrk3sPGBbLlF+0aJO3lg+0Yw= X-Google-Smtp-Source: ABdhPJyA6KMQLGspxDQuMB3AJjwy1n4N6vTF1NTBv7oDFWmt8buswnwQw/m1E/kYfC65a/uWB9XotDCuHrLZ3DbVAI0= X-Received: by 2002:a1c:46c6:: with SMTP id t189mr192270wma.79.1605045601646; Tue, 10 Nov 2020 14:00:01 -0800 (PST) MIME-Version: 1.0 References: <20201106214949.2042120-1-lee.jones@linaro.org> <20201106214949.2042120-16-lee.jones@linaro.org> In-Reply-To: <20201106214949.2042120-16-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 16:59:50 -0500 Message-ID: Subject: Re: [PATCH 15/19] drm/radeon: Move prototypes to shared header To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , =?UTF-8?Q?Christian_K=C3=B6nig?= , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Maling list - DRI developers , Alex Deucher , linux-media Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_kms.c:756:5: warning: no previous prototyp= e for =E2=80=98radeon_get_vblank_counter_kms=E2=80=99 [-Wmissing-prototypes= ] > 756 | u32 radeon_get_vblank_counter_kms(struct drm_crtc *crtc) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/radeon_kms.c:826:5: warning: no previous prototyp= e for =E2=80=98radeon_enable_vblank_kms=E2=80=99 [-Wmissing-prototypes] > 826 | int radeon_enable_vblank_kms(struct drm_crtc *crtc) > | ^~~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/radeon_kms.c:853:6: warning: no previous prototyp= e for =E2=80=98radeon_disable_vblank_kms=E2=80=99 [-Wmissing-prototypes] > 853 | void radeon_disable_vblank_kms(struct drm_crtc *crtc) > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/radeon.h | 6 ++++++ > drivers/gpu/drm/radeon/radeon_display.c | 4 ---- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/rad= eon.h > index e1132d86d2507..961a31b8805c2 100644 > --- a/drivers/gpu/drm/radeon/radeon.h > +++ b/drivers/gpu/drm/radeon/radeon.h > @@ -2832,6 +2832,12 @@ extern void radeon_program_register_sequence(struc= t radeon_device *rdev, > const u32 array_size); > struct radeon_device *radeon_get_rdev(struct ttm_bo_device *bdev); > > +/* KMS */ > + > +u32 radeon_get_vblank_counter_kms(struct drm_crtc *crtc); > +int radeon_enable_vblank_kms(struct drm_crtc *crtc); > +void radeon_disable_vblank_kms(struct drm_crtc *crtc); > + > /* > * vm > */ > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/ra= deon/radeon_display.c > index b79686cf8bdbd..bd60f16fd0d78 100644 > --- a/drivers/gpu/drm/radeon/radeon_display.c > +++ b/drivers/gpu/drm/radeon/radeon_display.c > @@ -45,10 +45,6 @@ > #include "atom.h" > #include "radeon.h" > > -u32 radeon_get_vblank_counter_kms(struct drm_crtc *crtc); > -int radeon_enable_vblank_kms(struct drm_crtc *crtc); > -void radeon_disable_vblank_kms(struct drm_crtc *crtc); > - > static void avivo_crtc_load_lut(struct drm_crtc *crtc) > { > struct radeon_crtc *radeon_crtc =3D to_radeon_crtc(crtc); > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel