From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60FA7C6FA86 for ; Wed, 7 Sep 2022 14:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbiIGO5O (ORCPT ); Wed, 7 Sep 2022 10:57:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230242AbiIGO4y (ORCPT ); Wed, 7 Sep 2022 10:56:54 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CC6B9F76D for ; Wed, 7 Sep 2022 07:56:48 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id q39-20020a056830442700b0063889adc0ddso10456916otv.1 for ; Wed, 07 Sep 2022 07:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=R18/KkvI0bwN1Yb6uOYkzfgE4nW++3c9UPmBBYxx7CU=; b=QB8Ku1JNOE1BUAopdNjlcDp1puobGOzHlyUhKR6CWlFP15tejy6UAgQs1GfZwKadDs a0gyp3nB4XZrd9rchWz256RHIKDl9/5krwM7UNHlfD50LKybxsC9CnfE4pZPYmK+4Ts5 t4Z9wLe8CfXRL0bSpxGpdhk2xl6jIu6MqoUrmLSWyu0NIl6qvHzY/sAigyQ4uP+A/tpi YRTM4RATMRutuA03smGNmntwEwWKGWyKBcL3ggj9qxpTDBXnTQs+yn3qViuHbNXWvDLV zE2vGQlvDUFm9ZR38UdkiSpxEla5mWnaJMNzf2L6bYPonYsiJkE2lFOtc+qR1Gr7Lcup w2Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=R18/KkvI0bwN1Yb6uOYkzfgE4nW++3c9UPmBBYxx7CU=; b=DwuxRHZdv6jWS4R9GZliH36I35kQ/9xcZORrEVuTwmWTe/OYa59/ELkJ9cMd0DMLY0 UWe4pzLfa+B6H1i70Y9OWgN+5nTrv+Md3AfAOAzMmQb/qMHhcQJYo3kG0bUrgdoxlh21 PD/GuUsqnWiRoQRWRo2TDDJcsCsghMzyBw/iDG3PjN2dz4cmY94xAjvyv1oJtB9UFqvy 20t103xQNxfQFle3xw5cRw5HWtEsB/AJmoO+umgtIPpuCS8DWrapevngL8DvYpN8zEau fplao9sB6yKJu8GjM+cTjaGVSfh1yp+TyO3ehFAmAZdmThl8IJt5gItYloJxv9Kovld4 G+TQ== X-Gm-Message-State: ACgBeo2uVRVRajV5VF3PphQ31KRRDs2hp2xAEMjdwZNz7SUrPFi7Ga4J nxCTxOucWki5McqJ2g67H4lmulFNrHVGXgP5kd4= X-Google-Smtp-Source: AA6agR7IWbHn3lhZ/ot+C85/TxO/QN9z4ndtsTAyaJfaazgJGihOPTdsepxkn6HDUffxyIi1P+btvKVCBiP4iT8yQic= X-Received: by 2002:a05:6830:54b:b0:636:eecb:1196 with SMTP id l11-20020a056830054b00b00636eecb1196mr1623273otb.123.1662562607723; Wed, 07 Sep 2022 07:56:47 -0700 (PDT) MIME-Version: 1.0 References: <20220907112657.25150-1-yuanjilin@cdjrlc.com> In-Reply-To: From: Alex Deucher Date: Wed, 7 Sep 2022 10:56:36 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: fix repeated words in comments To: Robin Murphy Cc: Jilin Yuan , airlied@linux.ie, daniel@ffwll.ch, isabbasso@riseup.net, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 7, 2022 at 10:50 AM Robin Murphy wrote: > > On 2022-09-07 12:26, Jilin Yuan wrote: > > Delete the redundant word 'we'. > > FWIW, to me it's not redundant because while indeed it is not correct, > it looks exactly like the kind of typo I might make of "if we", and > parsing it as *that* does make sense. The sentence you end up with here > can hardly be considered an improvement since it is still ungrammatical > nonsense. Yes, I believe this was supposed to say "if we" rather than "we we". Alex > > Robin. > > > Signed-off-by: Jilin Yuan > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c > > index 02cb3a12dd76..6d6cc4637d41 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c > > @@ -694,7 +694,7 @@ static int amdgpu_vce_cs_reloc(struct amdgpu_cs_parser *p, struct amdgpu_ib *ib, > > * @allocated: allocated a new handle? > > * > > * Validates the handle and return the found session index or -EINVAL > > - * we we don't have another free session index. > > + * we don't have another free session index. > > */ > > static int amdgpu_vce_validate_handle(struct amdgpu_cs_parser *p, > > uint32_t handle, uint32_t *allocated)