From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D16C5519F for ; Thu, 12 Nov 2020 21:25:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83CE2216C4 for ; Thu, 12 Nov 2020 21:25:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kD08hxSi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727245AbgKLVZ5 (ORCPT ); Thu, 12 Nov 2020 16:25:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbgKLVZ4 (ORCPT ); Thu, 12 Nov 2020 16:25:56 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2393C0613D1; Thu, 12 Nov 2020 13:25:56 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id h62so6726068wme.3; Thu, 12 Nov 2020 13:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hUyTNFSy+FKV2Opdiuolyr8HGiYLytnqVqPxhLY1PsU=; b=kD08hxSi7dEp2gX1wV+W3BVTsipcNzE87u1fHldICACt9NRM++rnO1Hd7tRRf5VAMQ rdqjZuDm5uJYSfj/vUMW0ONk7aMVuQD9N/ojEGkK9ExmtnsP+bgynZPXRyHYyQU62Tdu 3Obpvs43rMIF+l85GBGeeAsgt+6Xybyc9BZ3oQxK+tuwKtJ4YX6JIBCzrNfeIeSAPMpp +dwBr8SrhSIPab60tdJzleMGRT5Ad2vGIl3U+hhcKR8GONvbwWUJW5I/xgRqUIOPMoaJ E5fn/rxPjEOALrsWwpiVkTbcE1UJyD7tMktb5o/YEX+1K6gmQjXlrgEtlgo6C5+9Lnyc 1iHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hUyTNFSy+FKV2Opdiuolyr8HGiYLytnqVqPxhLY1PsU=; b=pXC4BZuBmaTVKl2jQnnFo3e9hSxCS5GZhijR4jACb+saSKxliluzW+WlOQ5PbID4kj n6z7YaOBHw+fWT+jAjyidmHghX9IvVzZfP0HcS1wuwZZe/gJOZHkRpRvOFs1/DALAUJK 6ACfPiyQeoLwSsYKiCaeMYCRfYPfEFYhe9yttkuEtf+JP4+WngtKyv18utCkjQNsRK6+ +E+LzVcEqUVG2YOu8jmFyUAK3+yud/bqjHhkLfDgmt/vZO+1v1oOL1yNArozTz650nJS Yau8PiDH3+H5XljoRw68qN7jx9KVh4/zmERdYRw4gi4a/svKkwWcKSDlhbGmYOeqm/Jz RggA== X-Gm-Message-State: AOAM5302DfwZnBiS2IKvujxznuUg1siLGbeP+gBqcPfwaBqA4fYd4b4d jOKCP9udcmk1XWbYHcqVb1SH7m2AQ7zj3jKHTpw= X-Google-Smtp-Source: ABdhPJxip1JaKfSFfumui+igR6N8zzYdt0OgATgfFWedhqfU/YYwwC5bN0VbM2VvOmJUJ2cj4foLG4KTcR0Z4hdacpw= X-Received: by 2002:a1c:8150:: with SMTP id c77mr1677726wmd.26.1605216345970; Thu, 12 Nov 2020 13:25:45 -0800 (PST) MIME-Version: 1.0 References: <20201112190039.2785914-1-lee.jones@linaro.org> <20201112190039.2785914-15-lee.jones@linaro.org> In-Reply-To: <20201112190039.2785914-15-lee.jones@linaro.org> From: Alex Deucher Date: Thu, 12 Nov 2020 16:25:33 -0500 Message-ID: Subject: Re: [PATCH 14/30] drm/amd/amdgpu/amdgpu_ring: Fix a bunch of function misdocumentation To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , =?UTF-8?Q?Christian_K=C3=B6nig?= , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Maling list - DRI developers , Alex Deucher , linux-media Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 2:01 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:63: warning: Excess function pa= rameter 'adev' description in 'amdgpu_ring_alloc' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:122: warning: Excess function p= arameter 'adev' description in 'amdgpu_ring_commit' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:167: warning: Function paramete= r or member 'max_dw' not described in 'amdgpu_ring_init' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:167: warning: Function paramete= r or member 'irq_src' not described in 'amdgpu_ring_init' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:167: warning: Function paramete= r or member 'irq_type' not described in 'amdgpu_ring_init' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:167: warning: Function paramete= r or member 'hw_prio' not described in 'amdgpu_ring_init' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:167: warning: Excess function p= arameter 'max_ndw' description in 'amdgpu_ring_init' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:167: warning: Excess function p= arameter 'nop' description in 'amdgpu_ring_init' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:285: warning: Excess function p= arameter 'adev' description in 'amdgpu_ring_fini' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:325: warning: Function paramete= r or member 'ring' not described in 'amdgpu_ring_emit_reg_write_reg_wait_he= lper' > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c:325: warning: Excess function p= arameter 'adev' description in 'amdgpu_ring_emit_reg_write_reg_wait_helper' > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/drm/a= md/amdgpu/amdgpu_ring.c > index 2697b250dc326..a23b2079696a1 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > @@ -52,7 +52,6 @@ > /** > * amdgpu_ring_alloc - allocate space on the ring buffer > * > - * @adev: amdgpu_device pointer > * @ring: amdgpu_ring structure holding ring information > * @ndw: number of dwords to allocate in the ring buffer > * > @@ -95,7 +94,8 @@ void amdgpu_ring_insert_nop(struct amdgpu_ring *ring, u= int32_t count) > amdgpu_ring_write(ring, ring->funcs->nop); > } > > -/** amdgpu_ring_generic_pad_ib - pad IB with NOP packets > +/** > + * amdgpu_ring_generic_pad_ib - pad IB with NOP packets > * > * @ring: amdgpu_ring structure holding ring information > * @ib: IB to add NOP packets to > @@ -112,7 +112,6 @@ void amdgpu_ring_generic_pad_ib(struct amdgpu_ring *r= ing, struct amdgpu_ib *ib) > * amdgpu_ring_commit - tell the GPU to execute the new > * commands on the ring buffer > * > - * @adev: amdgpu_device pointer > * @ring: amdgpu_ring structure holding ring information > * > * Update the wptr (write pointer) to tell the GPU to > @@ -156,7 +155,9 @@ void amdgpu_ring_undo(struct amdgpu_ring *ring) > * @adev: amdgpu_device pointer > * @ring: amdgpu_ring structure holding ring information > * @max_ndw: maximum number of dw for ring alloc > - * @nop: nop packet for this ring > + * @irq_src: interrupt source to use for this ring > + * @irq_type: interrupt type to use for this ring > + * @hw_prio: ring priority (NORMAL/HIGH) > * > * Initialize the driver information for the selected ring (all asics). > * Returns 0 on success, error on failure. > @@ -276,7 +277,6 @@ int amdgpu_ring_init(struct amdgpu_device *adev, stru= ct amdgpu_ring *ring, > /** > * amdgpu_ring_fini - tear down the driver ring struct. > * > - * @adev: amdgpu_device pointer > * @ring: amdgpu_ring structure holding ring information > * > * Tear down the driver information for the selected ring (all asics). > @@ -310,7 +310,7 @@ void amdgpu_ring_fini(struct amdgpu_ring *ring) > /** > * amdgpu_ring_emit_reg_write_reg_wait_helper - ring helper > * > - * @adev: amdgpu_device pointer > + * @ring: ring to write to > * @reg0: register to write > * @reg1: register to wait on > * @ref: reference value to write/wait on > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel