From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F26C4CED1 for ; Fri, 4 Oct 2019 12:57:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BBAE222BE for ; Fri, 4 Oct 2019 12:57:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CfZutqK2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388056AbfJDM5l (ORCPT ); Fri, 4 Oct 2019 08:57:41 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40410 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387440AbfJDM5k (ORCPT ); Fri, 4 Oct 2019 08:57:40 -0400 Received: by mail-wr1-f66.google.com with SMTP id l3so7066683wru.7; Fri, 04 Oct 2019 05:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XS9aaZMpGytggDjroiubtOG48XIjudiIkkyqLu//BAo=; b=CfZutqK2eyhMj4QYH5dAeTwCvDuMu78hH8sOobkZWo8qm2svsb/q3QV1/JgEXFDxGI IfMzm9/TKepsFaqC+XIMnMc53GndMFWcvcRVpn9GIrAE2Vigoe9F3HgbfiiI0GmjToSr QYwHPu4pKKmB2Yy44qgzJ/vVp4fhAjRDPHcDCNqAiEpjErKrRnuWiGmOMMuYUC63Gcms Eo0vKKBjllg2yG3BisOSgS/iyJ4SL5O32xzSyMNOfRq+GCR60760jAHQHjLKIlqVfGkT xpax/gUZeX1CBKAxoKUvnTx18iR6xS6JeVhl3BzeYiqqO9KCiRKlmdztxNZ1uV2ucsFo pHbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XS9aaZMpGytggDjroiubtOG48XIjudiIkkyqLu//BAo=; b=TNKag1jqVCCvRDnJ7O7H6/rY7IToTx+uhzJ6kKBZXb3Qgw7hZagQl/aNfxWiRK2Nx3 j7UF4OWLW7by/m7uYPykW0eUhErR1l3OE2zW4rpBaRnwCc/iLKwR8L370RzR5jYblKf+ YaWJLgIefthvpbyg1WjQwcih/pM+0Eto4O0lou851KQUptGAfqXRdMUEBT8NSXYZ8rUp Gt/XJfiTYvwFGBTmp+/Ai0fFTsubFOv8cJHPrw1TbcRwn4x+Iu4NxPppbe2b5ms0exDV Z1hAerQjV8rTPccs5HtdBZSi11ENEFRRFzw9V/hUjamEojSPYGtf1EbgB1TyaOiItJNQ k6hw== X-Gm-Message-State: APjAAAWIvFGFj9voSLVWf0iYgcM89dBtSd3DxlCl8fQp6+4Yh17qgOm6 zwe0MRttQwws0/K9KPz3Ibelfbv0MiuaeiI8ag4= X-Google-Smtp-Source: APXvYqw7a5NYS3b3BeLyQBXREKlOHjBFTJXthurPJdQ7nhyePsMLRV3NcpO1oI+myJ7I+eZ/HhBO3tS0mQBjuPunC0g= X-Received: by 2002:adf:d08b:: with SMTP id y11mr12064059wrh.50.1570193857802; Fri, 04 Oct 2019 05:57:37 -0700 (PDT) MIME-Version: 1.0 References: <20191003214049.23067-1-colin.king@canonical.com> <70c50fec-7ab7-3ac9-3f49-d5f2651554e4@amd.com> In-Reply-To: <70c50fec-7ab7-3ac9-3f49-d5f2651554e4@amd.com> From: Alex Deucher Date: Fri, 4 Oct 2019 08:57:25 -0400 Message-ID: Subject: Re: [PATCH][next] drm/amdgpu: remove redundant variable r and redundant return statement To: "Koenig, Christian" Cc: Colin King , "Deucher, Alexander" , "Zhou, David(ChunMing)" , David Airlie , Daniel Vetter , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 4, 2019 at 3:29 AM Koenig, Christian wrote: > > Am 03.10.19 um 23:40 schrieb Colin King: > > From: Colin Ian King > > > > There is a return statement that is not reachable and a variable that > > is not used. Remove them. > > > > Addresses-Coverity: ("Structurally dead code") > > Fixes: de7b45babd9b ("drm/amdgpu: cleanup creating BOs at fixed locatio= n (v2)") > > Signed-off-by: Colin Ian King > > Reviewed-by: Christian K=C3=B6nig Applied. Thanks! Alex > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_ttm.c > > index 481e4c381083..814159f15633 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > @@ -1636,7 +1636,6 @@ static void amdgpu_ttm_fw_reserve_vram_fini(struc= t amdgpu_device *adev) > > static int amdgpu_ttm_fw_reserve_vram_init(struct amdgpu_device *adev= ) > > { > > uint64_t vram_size =3D adev->gmc.visible_vram_size; > > - int r; > > > > adev->fw_vram_usage.va =3D NULL; > > adev->fw_vram_usage.reserved_bo =3D NULL; > > @@ -1651,7 +1650,6 @@ static int amdgpu_ttm_fw_reserve_vram_init(struct= amdgpu_device *adev) > > AMDGPU_GEM_DOMAIN_VRAM, > > &adev->fw_vram_usage.reserved_b= o, > > &adev->fw_vram_usage.va); > > - return r; > > } > > > > /** > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel