From: Alex Deucher <alexdeucher@gmail.com>
To: Harry Wentland <harry.wentland@amd.com>
Cc: Hariprasad Kelam <hariprasad.kelam@gmail.com>,
Chunming Zhou <David1.Zhou@amd.com>,
"Leo (Sunpeng) Li" <sunpeng.li@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Nikola Cornij <nikola.cornij@amd.com>,
Dave Airlie <airlied@linux.ie>,
Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
Colin Ian King <colin.king@canonical.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: Add number of slices per line to DSC parameter validation
Date: Tue, 6 Aug 2019 15:04:36 -0400 [thread overview]
Message-ID: <CADnq5_NLTOQ31XXhw3o8aoJkRmzq6guurgUz13cxKD6U6M90Cw@mail.gmail.com> (raw)
In-Reply-To: <20190806174549.7856-1-harry.wentland@amd.com>
On Tue, Aug 6, 2019 at 1:45 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
> From: Nikola Cornij <nikola.cornij@amd.com>
>
> [why]
> Number of slices per line was mistakenly left out
>
> Cc: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> Signed-off-by: Nikola Cornij <nikola.cornij@amd.com>
> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>
> Thanks, Hariprasad, for your patch. The second condition should actually check
> for num_slices_h.
>
> Harry
>
> drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c
> index e870caa8d4fa..adb69c038efb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dsc.c
> @@ -302,7 +302,7 @@ static bool dsc_prepare_config(struct display_stream_compressor *dsc, const stru
> dsc_cfg->dc_dsc_cfg.linebuf_depth == 0)));
> ASSERT(96 <= dsc_cfg->dc_dsc_cfg.bits_per_pixel && dsc_cfg->dc_dsc_cfg.bits_per_pixel <= 0x3ff); // 6.0 <= bits_per_pixel <= 63.9375
>
> - if (!dsc_cfg->dc_dsc_cfg.num_slices_v || !dsc_cfg->dc_dsc_cfg.num_slices_v ||
> + if (!dsc_cfg->dc_dsc_cfg.num_slices_v || !dsc_cfg->dc_dsc_cfg.num_slices_h ||
> !(dsc_cfg->dc_dsc_cfg.version_minor == 1 || dsc_cfg->dc_dsc_cfg.version_minor == 2) ||
> !dsc_cfg->pic_width || !dsc_cfg->pic_height ||
> !((dsc_cfg->dc_dsc_cfg.version_minor == 1 && // v1.1 line buffer depth range:
> --
> 2.22.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2019-08-06 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 17:32 [PATCH] gpu: drm: amd: display: dc: dcn20: Remove redudant condition Hariprasad Kelam
2019-08-06 14:04 ` Alex Deucher
2019-08-06 17:45 ` [PATCH] drm/amd/display: Add number of slices per line to DSC parameter validation Harry Wentland
2019-08-06 19:04 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_NLTOQ31XXhw3o8aoJkRmzq6guurgUz13cxKD6U6M90Cw@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=David1.Zhou@amd.com \
--cc=Dmytro.Laktyushkin@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=colin.king@canonical.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hariprasad.kelam@gmail.com \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nikola.cornij@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).