From: Alex Deucher <alexdeucher@gmail.com>
To: cgel.zte@gmail.com
Cc: alexander.deucher@amd.com, Jack.Xiao@amd.com, airlied@linux.ie,
Zeal Robot <zealci@zte.com.cn>,
Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org, ray.huang@amd.com,
Stanley.Yang@amd.com, dri-devel@lists.freedesktop.org,
Likun.Gao@amd.com, zhang.songyi@zte.com.cn,
christian.koenig@amd.com, Hawking.Zhang@amd.com
Subject: Re: [PATCH linux-next] drm/amdgpu: Remove the unneeded result variable
Date: Fri, 9 Sep 2022 16:46:57 -0400 [thread overview]
Message-ID: <CADnq5_NQByVi1dnxzc4jdPX+sKtA6OtU9j-L9M+uGXqvrJP+kA@mail.gmail.com> (raw)
In-Reply-To: <20220902080401.320050-1-zhang.songyi@zte.com.cn>
Applied. Thanks!
Alex
On Fri, Sep 2, 2022 at 4:04 AM <cgel.zte@gmail.com> wrote:
>
> From: zhang songyi <zhang.songyi@zte.com.cn>
>
> Return the sdma_v6_0_start() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
> index 2bc1407e885e..2cc2d851b4eb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c
> @@ -1373,12 +1373,9 @@ static int sdma_v6_0_sw_fini(void *handle)
>
> static int sdma_v6_0_hw_init(void *handle)
> {
> - int r;
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> - r = sdma_v6_0_start(adev);
> -
> - return r;
> + return sdma_v6_0_start(adev);
> }
>
> static int sdma_v6_0_hw_fini(void *handle)
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2022-09-09 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 8:04 [PATCH linux-next] drm/amdgpu: Remove the unneeded result variable cgel.zte
2022-09-09 20:46 ` Alex Deucher [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-26 7:23 cgel.zte
2022-08-26 20:38 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_NQByVi1dnxzc4jdPX+sKtA6OtU9j-L9M+uGXqvrJP+kA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jack.Xiao@amd.com \
--cc=Likun.Gao@amd.com \
--cc=Stanley.Yang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=cgel.zte@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.huang@amd.com \
--cc=zealci@zte.com.cn \
--cc=zhang.songyi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).