From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E191C4363A for ; Mon, 26 Oct 2020 20:33:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE627207E8 for ; Mon, 26 Oct 2020 20:33:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fgGtA4dZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732534AbgJZUd3 (ORCPT ); Mon, 26 Oct 2020 16:33:29 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:55961 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732481AbgJZUdT (ORCPT ); Mon, 26 Oct 2020 16:33:19 -0400 Received: by mail-wm1-f67.google.com with SMTP id a72so12979159wme.5 for ; Mon, 26 Oct 2020 13:33:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/O8B5tDsbMKoWPbr5etGrG3WN9TQf/YvulQxtm1JNqc=; b=fgGtA4dZkC7fJbJEp77T2zNmJPL+rQzgZ1HlLKVt9cz6ql8n6Ew8NtQxmH48a25heT lkDvFDx9tZgelHI68g+i3kcvouujmjmCv6AQVtHFRvt07YjyP2EZmGVBm8Wt56o2cORX wRO+5ZqpFhdG6Ac53AX7WPmPeLDNH2bucLyVDtdurw0THcKB7xgZ0qdUjmnAhov8y8E4 xSEIBjkL944sHXH0benknMyN3QHAffKFDnglOwcPQUYcAr32JBvTBWqT/5UXf0dnsww+ 1f8kFHIKp3KuUV2ogMZyU++YgUpCB4zQs0wa7WvtqQBO+mf3QgBdjrAb2KkzSy3M9uJf 0QwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/O8B5tDsbMKoWPbr5etGrG3WN9TQf/YvulQxtm1JNqc=; b=mHvnk73W01/gF2SXmyyWOvrbTdcJ6hWR9dRDmAaVFPf4V07MYhYL7MenIolnNjLsON loychQ9xVhW/YzJv76eI7oyO/xabryVEhtRvlUa15iYzuah9mbMxUBtpDTIKt6D4JHV1 +beDpl4p60MJgIUQH/GJuMwbfL/omD1CYI46Bl2SUiIF5piKAKcWzEN+771w0i/9njrq FfZy6GwSCWrWLNQ9ay/wEAUDcBvO2zOja7SixypfThO3Eatbd7od4P3Tcu/o+tA1wNtU UL0Csjk5mYq7K9DprtRDCWVetbKbLX4mBwFOZn+xv/BSlnGGqQnMax0h7CrlvxVmhECT Lbkw== X-Gm-Message-State: AOAM531Mr2qTgRwB66AyDeiFmbQY+TZiGi+QiR06K15Hyql+Osa1Jv08 aRTMv2T5EKcdwNuV3TFngmy5mGew+7fWCZHeIII= X-Google-Smtp-Source: ABdhPJwMDiAiLRKHlrvYhOBxCY24XJ9FgKn7gwnrmpvOmcovyvuheNcYl6kswwxOccE6N3E2mp6N1hUoQVyoAadJXtE= X-Received: by 2002:a05:600c:25a:: with SMTP id 26mr17442752wmj.39.1603744397278; Mon, 26 Oct 2020 13:33:17 -0700 (PDT) MIME-Version: 1.0 References: <20201023074656.11855-1-tiwai@suse.de> <1d3e22ef-a301-f557-79ca-33d6520bb64e@amd.com> <22ab9117-0281-2ff3-8328-d7780e353643@amd.com> In-Reply-To: <22ab9117-0281-2ff3-8328-d7780e353643@amd.com> From: Alex Deucher Date: Mon, 26 Oct 2020 16:33:06 -0400 Message-ID: Subject: Re: [PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint To: "Kazlauskas, Nicholas" Cc: Luben Tuikov , Takashi Iwai , amd-gfx list , LKML , Maling list - DRI developers Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Mon, Oct 26, 2020 at 4:22 PM Kazlauskas, Nicholas wrote: > > Reviewed-by: Nicholas Kazlauskas > > Looks fine to me. Feel free to apply. > > Regards, > Nicholas Kazlauskas > > On 2020-10-26 3:34 p.m., Alex Deucher wrote: > > Yes, looks good to me as well. Series is: > > Acked-by: Alex Deucher > > I'll give the display guys a few more days to look this over, but if > > there are no objections, I'll apply them. > > > > Thanks! > > > > Alex > > > > On Fri, Oct 23, 2020 at 7:16 PM Luben Tuikov wrote: > >> > >> On 2020-10-23 03:46, Takashi Iwai wrote: > >>> Hi, > >>> > >>> the amdgpu driver's ASSERT_CRITICAL() macro calls the > >>> kgdb_breakpoing() even if no debug option is set, and this leads to a > >>> kernel panic on distro kernels. The first two patches are the > >>> oneliner fixes for those, while the last one is the cleanup of those > >>> debug macros. > >> > >> This looks like good work and solid. Hopefully it gets picked up. > >> > >> Regards, > >> Luben > >> > >>> > >>> > >>> Takashi > >>> > >>> === > >>> > >>> Takashi Iwai (3): > >>> drm/amd/display: Fix kernel panic by dal_gpio_open() error > >>> drm/amd/display: Don't invoke kgdb_breakpoint() unconditionally > >>> drm/amd/display: Clean up debug macros > >>> > >>> drivers/gpu/drm/amd/display/Kconfig | 1 + > >>> drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c | 4 +-- > >>> drivers/gpu/drm/amd/display/dc/os_types.h | 33 +++++++++---------------- > >>> 3 files changed, 15 insertions(+), 23 deletions(-) > >>> > >> > >> _______________________________________________ > >> amd-gfx mailing list > >> amd-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > >