From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102E3C2D0A3 for ; Mon, 16 Nov 2020 19:59:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AAB24208C7 for ; Mon, 16 Nov 2020 19:59:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G1YxsTRf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730954AbgKPT67 (ORCPT ); Mon, 16 Nov 2020 14:58:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727393AbgKPT67 (ORCPT ); Mon, 16 Nov 2020 14:58:59 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB2BCC0613CF for ; Mon, 16 Nov 2020 11:58:58 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id a3so451213wmb.5 for ; Mon, 16 Nov 2020 11:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bFL+h4NXuPoSuSMvtv0Sg7oT+u3rDrgDjKbEx0xnOLQ=; b=G1YxsTRfhadIWkJ35dpSnDqo9LWwhKdQaIcnejb5DfAD3AGyGCkiA1gGKURMrO+5Jc GMG7C/jJycfm1zeZSewyhBV51dcL1Ln42HJAv7J6WjUCtMQmx8ikqHHoe4aOj0+QqZv8 UmfIV5B0BfgOXts130m9E3XKCBDHKqUojNvTpy3Y5maklWnKr9SkmjBYizAZAe9AsRx/ Y5kBs3NKdH1H9tlgO8U6dAZ0PKLK2s1VaGUTpNkIyhqAjBTm05sjQ9tPQK/pYvmOr49a RZWZy8jBhwNSeSl3dYYnVb4579Im27sDjp+kEG8eZwNG4taQlchcH3Lt2R+BnVWprLc3 8qpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bFL+h4NXuPoSuSMvtv0Sg7oT+u3rDrgDjKbEx0xnOLQ=; b=Q2d5uATJk1KnH2VKK9pJ8Mw0XBEP6Zx/CzdJ+Xll5+MSfkUL4aSYVj3NFfuRbvbhpI JWBgxLlGAszr3r1B3sc/w4xEqYIh/y82psIqFQ8vETeyozAaMx4tVbLh4SwqwCqSRUBO VzukSF/ftDCBnSMCmRmuYKOui6J91vPJxkv/42YMKvCKahVRpvi7hw38rWfx+Xn+cynB YBbLqFIG4K7PxQ/7Wtk+v9wXf43UREbeq7SYxV1H0/1QqxLkY8o24hDeYbvdywd3ATVA DwOOu4UY2tLVPPrruw3kpE9Or5Zw7AurubApS3OmUyM0C5HaX2kuc8V2pk04FopLqryQ JR0Q== X-Gm-Message-State: AOAM530qyIul9qijL8EFNgLtOhhRpD6UJNg7EkwwjFUKU3JfUWO4KV89 Fjj4+Z4wwWyvZ/yhI8UvfzJDBmO3/ENxXqlVJBRNVqum X-Google-Smtp-Source: ABdhPJwvYa7TiNdPz5rwvx37IifScNSPxNr4dkzrIRfYkQxxOqkKIIaP+wFQQNwGFK5z8itO4binMJvelPffV/FoIms= X-Received: by 2002:a7b:c157:: with SMTP id z23mr570479wmi.70.1605556737507; Mon, 16 Nov 2020 11:58:57 -0800 (PST) MIME-Version: 1.0 References: <20201116173700.1830487-1-lee.jones@linaro.org> <20201116173700.1830487-17-lee.jones@linaro.org> In-Reply-To: <20201116173700.1830487-17-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 16 Nov 2020 14:58:46 -0500 Message-ID: Subject: Re: [PATCH 16/43] drm/radeon/radeon_gem: Move 'radeon_gem_prime_*()'s prototypes to shared header To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 16, 2020 at 12:37 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/radeon/radeon_prime.c:34:18: warning: no previous protot= ype for =E2=80=98radeon_gem_prime_get_sg_table=E2=80=99 [-Wmissing-prototyp= es] > 34 | struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_objec= t *obj) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/radeon_prime.c:42:7: warning: no previous prototy= pe for =E2=80=98radeon_gem_prime_vmap=E2=80=99 [-Wmissing-prototypes] > 42 | void *radeon_gem_prime_vmap(struct drm_gem_object *obj) > | ^~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/radeon_prime.c:55:6: warning: no previous prototy= pe for =E2=80=98radeon_gem_prime_vunmap=E2=80=99 [-Wmissing-prototypes] > 55 | void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vadd= r) > | ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/radeon_prime.c:62:24: warning: no previous protot= ype for =E2=80=98radeon_gem_prime_import_sg_table=E2=80=99 [-Wmissing-proto= types] > 62 | struct drm_gem_object *radeon_gem_prime_import_sg_table(struct drm_= device *dev, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/radeon_prime.c:86:5: warning: no previous prototy= pe for =E2=80=98radeon_gem_prime_pin=E2=80=99 [-Wmissing-prototypes] > 86 | int radeon_gem_prime_pin(struct drm_gem_object *obj) > | ^~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/radeon_prime.c:104:6: warning: no previous protot= ype for =E2=80=98radeon_gem_prime_unpin=E2=80=99 [-Wmissing-prototypes] > 104 | void radeon_gem_prime_unpin(struct drm_gem_object *obj) > | ^~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/radeon_prime.c:120:17: warning: no previous proto= type for =E2=80=98radeon_gem_prime_export=E2=80=99 [-Wmissing-prototypes] > 120 | struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gob= j, > | ^~~~~~~~~~~~~~~~~~~~~~~ > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied with minor changes. Thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_gem.c | 1 + > drivers/gpu/drm/radeon/radeon_prime.c | 1 + > drivers/gpu/drm/radeon/radeon_prime.h | 39 +++++++++++++++++++++++++++ > 3 files changed, 41 insertions(+) > create mode 100644 drivers/gpu/drm/radeon/radeon_prime.h > > diff --git a/drivers/gpu/drm/radeon/radeon_gem.c b/drivers/gpu/drm/radeon= /radeon_gem.c > index d2876ce3bc9e2..b6b21d2e72624 100644 > --- a/drivers/gpu/drm/radeon/radeon_gem.c > +++ b/drivers/gpu/drm/radeon/radeon_gem.c > @@ -35,6 +35,7 @@ > #include > > #include "radeon.h" > +#include "radeon_prime.h" > > struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj, > int flags); > diff --git a/drivers/gpu/drm/radeon/radeon_prime.c b/drivers/gpu/drm/rade= on/radeon_prime.c > index 088d39a51c0d2..dd482edc819c5 100644 > --- a/drivers/gpu/drm/radeon/radeon_prime.c > +++ b/drivers/gpu/drm/radeon/radeon_prime.c > @@ -30,6 +30,7 @@ > #include > > #include "radeon.h" > +#include "radeon_prime.h" > > struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *ob= j) > { > diff --git a/drivers/gpu/drm/radeon/radeon_prime.h b/drivers/gpu/drm/rade= on/radeon_prime.h > new file mode 100644 > index 0000000000000..11b7f80987834 > --- /dev/null > +++ b/drivers/gpu/drm/radeon/radeon_prime.h > @@ -0,0 +1,39 @@ > +/* radeon_prime.h -- Private header for radeon driver -*- linux-c -*- > + * > + * Copyright 1999 Precision Insight, Inc., Cedar Park, Texas. > + * Copyright 2000 VA Linux Systems, Inc., Fremont, California. > + * All rights reserved. > + * > + * Permission is hereby granted, free of charge, to any person obtaining= a > + * copy of this software and associated documentation files (the "Softwa= re"), > + * to deal in the Software without restriction, including without limita= tion > + * the rights to use, copy, modify, merge, publish, distribute, sublicen= se, > + * and/or sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following conditions: > + * > + * The above copyright notice and this permission notice (including the = next > + * paragraph) shall be included in all copies or substantial portions of= the > + * Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRE= SS OR > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILI= TY, > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SH= ALL > + * PRECISION INSIGHT AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAG= ES OR > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR= OTHER > + * DEALINGS IN THE SOFTWARE. > + * > + */ > + > +#ifndef __RADEON_PRIME_H__ > +#define __RADEON_PRIME_H__ > + > +struct dma_buf *radeon_gem_prime_export(struct drm_gem_object *gobj, > + int flags); > +struct sg_table *radeon_gem_prime_get_sg_table(struct drm_gem_object *ob= j); > +int radeon_gem_prime_pin(struct drm_gem_object *obj); > +void radeon_gem_prime_unpin(struct drm_gem_object *obj); > +void *radeon_gem_prime_vmap(struct drm_gem_object *obj); > +void radeon_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr); > + > +#endif /* __RADEON_PRIME_H__ */ > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel