From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CA2FC433DB for ; Fri, 15 Jan 2021 14:57:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FDCE23772 for ; Fri, 15 Jan 2021 14:57:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729655AbhAOO52 (ORCPT ); Fri, 15 Jan 2021 09:57:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726402AbhAOO52 (ORCPT ); Fri, 15 Jan 2021 09:57:28 -0500 Received: from mail-oo1-xc2d.google.com (mail-oo1-xc2d.google.com [IPv6:2607:f8b0:4864:20::c2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7546C061757; Fri, 15 Jan 2021 06:56:47 -0800 (PST) Received: by mail-oo1-xc2d.google.com with SMTP id x203so2253086ooa.9; Fri, 15 Jan 2021 06:56:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NO0K0dXCtZelpuNUhec8CuaDzfXTrQY8G8j/RO4RKUQ=; b=FmdnjoGeom+NzYjZMF8xspzWt7P4wbaYEKKf4CoWFs3Kdkd0A87H5cVKvHJ0Bte5sR RBoMKG6eibhcoufqOS9aUBHTUScKunWrFdK73ZroK4w/fgwm64bAWF680q3D5t4uH69j Pz7K5AlL8RflekVrpU5iwcyz8uhTibWljAJ9HJOHIRD1JuY8isVS9AesQAt4K+zpoonY naozFAfBXLDWh/l6aLqCxrLMZ3TuWwEe0zESi4qRkY12Plo5Kx4MkaHW9Y8lf6QWMd0E LbUtjaqLnBBtFQC+iLKe5UaVEBAVJV1o72PeVwDDCLsJr2nJzNJPGA5MScBQ+ZcmyC1/ DeYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NO0K0dXCtZelpuNUhec8CuaDzfXTrQY8G8j/RO4RKUQ=; b=n2o1N2DmJzRlC/6mfJqorOF8K/K8AeVoqVBYcFKViRE8pwGeinjrY+R9FvX7gW/Ezh zF/WnfYq/d2dUBCMtZk25PEvkvRbacI39PyopcPh3ukXjVbYI/2fk9D/q25Bmf+cOFCS 3LPxnE8akHgj8JUZqoDsBveWyo5MWYhbPX2vk3OkbQc8zsQoTAgAvHbV+dsEWt6BTK9o urWcUyWpV/uyt7bJV+IfP+NUGmt7ZgSyNmvVT/LBiWxopm0aGDlKKwGOM39f9NcVH6ZM vvjihAwF/CDxlTAwB1vchx2niwSw3cVjrRxMPNx616tBXVFCXTwNkH/HbLiXxufAWpxa t8zw== X-Gm-Message-State: AOAM531D6a9kiSpDtMjJT1SQUEu5YHQQFg2PWzfxQnl9g1Mboy51f8bn 8ZA2UJ5PayWuV4GHu/OnVdHJ7enCE+7gjD1OZVk= X-Google-Smtp-Source: ABdhPJzgaiG/3gsS8pa90VDlTf938WbevA6Pure/5BnlbJkOOiwQbElE6ZbMNYsLwSg7BYtcN/GEmRXgm2aCIvqR4R4= X-Received: by 2002:a4a:a2c5:: with SMTP id r5mr8405442ool.72.1610722606624; Fri, 15 Jan 2021 06:56:46 -0800 (PST) MIME-Version: 1.0 References: <20210115163505.4132a5b3@canb.auug.org.au> <20210115055703.GA1258199@hr-amd> In-Reply-To: From: Alex Deucher Date: Fri, 15 Jan 2021 09:56:35 -0500 Message-ID: Subject: Re: linux-next: build failure after merge of the amdgpu tree To: "Huang, Ray" Cc: Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 15, 2021 at 3:46 AM Huang, Ray wrote: > > [AMD Public Use] > > Could you please help to check whether this patch can fix the issue? Looks good. Might want to add a comment where you set cpu_core_num that this is only used on APUs which are x86 only. Reviewed-by: Alex Deucher > > Thanks, > Ray > > -----Original Message----- > From: Huang, Ray > Sent: Friday, January 15, 2021 1:57 PM > To: Stephen Rothwell > Cc: Alex Deucher ; Linux Kernel Mailing List ; Linux Next Mailing List > Subject: Re: linux-next: build failure after merge of the amdgpu tree > > On Fri, Jan 15, 2021 at 01:35:05PM +0800, Stephen Rothwell wrote: > > Hi all, > > > > After merging the amdgpu tree, today's linux-next build (powerpc > > allyesconfig) failed like this: > > > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function 'vangogh_get_smu_metrics_data': > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:300:10: error: 'boot_cpu_data' undeclared (first use in this function); did you mean 'boot_cpuid'? > > Ah, vangogh is an x86 cpu, let me look at this issue. > > Could you share me the config file you tested? > > Thanks, > Ray > > > 300 | boot_cpu_data.x86_max_cores * sizeof(uint16_t)); > > | ^~~~~~~~~~~~~ > > | boot_cpuid > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function 'vangogh_read_sensor': > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1320:11: error: 'boot_cpu_data' undeclared (first use in this function); did you mean 'boot_cpuid'? > > 1320 | *size = boot_cpu_data.x86_max_cores * sizeof(uint16_t); > > | ^~~~~~~~~~~~~ > > | boot_cpuid > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function 'vangogh_od_edit_dpm_table': > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:1460:19: error: 'boot_cpu_data' undeclared (first use in this function); did you mean 'boot_cpuid'? > > 1460 | if (input[0] >= boot_cpu_data.x86_max_cores) { > > | ^~~~~~~~~~~~~ > > | boot_cpuid > > > > Caused by commits > > > > 517cb957c43b ("drm/amd/pm: implement the processor clocks which read by metric") > > 0d90d0ddd10e ("drm/amd/pm: implement processor fine grain feature for vangogh (v3)") > > > > The only thing I could do easily is to disable CONFIG_DRM_AMDGPU for today. > > > > -- > > Cheers, > > Stephen Rothwell >