From: Alex Deucher <alexdeucher@gmail.com>
To: yuehaibing@huawei.com
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
Chunming Zhou <David1.Zhou@amd.com>,
Dave Airlie <airlied@linux.ie>, Shaoyun Liu <Shaoyun.Liu@amd.com>,
David Francis <David.Francis@amd.com>,
Huang Rui <ray.huang@amd.com>, Feifei Xu <Feifei.Xu@amd.com>,
Likun Gao <Likun.Gao@amd.com>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2 -next] drm/amdgpu: remove set but not used variable 'ring'
Date: Thu, 15 Nov 2018 15:36:57 -0500 [thread overview]
Message-ID: <CADnq5_Ns03NWNzmgnXS-vm9TG_YW-V2HLRmEctJLdMcP3PoqqA@mail.gmail.com> (raw)
In-Reply-To: <20181115120035.4328-1-yuehaibing@huawei.com>
On Thu, Nov 15, 2018 at 11:12 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c: In function 'psp_v10_0_ring_stop':
> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c:230:19: warning:
> variable 'ring' set but not used [-Wunused-but-set-variable]
>
> drivers/gpu/drm/amd/amdgpu/psp_v3_1.c: In function 'psp_v3_1_ring_stop':
> drivers/gpu/drm/amd/amdgpu/psp_v3_1.c:359:19: warning:
> variable ‘ring’ set but not used [-Wunused-but-set-variable]
>
> It not used since commit
> 4ef72453311a ("drm/amdgpu: added api for stopping psp ring (v2)")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Reviewed-by: Huang Rui <ray.huang@amd.com>
Applied. thanks!
> ---
> v2:also remove it in psp_v3_1_ring_stop
> ---
> drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 3 ---
> drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> index 295c220..d78b430 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v10_0.c
> @@ -240,12 +240,9 @@ static int psp_v10_0_ring_stop(struct psp_context *psp,
> enum psp_ring_type ring_type)
> {
> int ret = 0;
> - struct psp_ring *ring;
> unsigned int psp_ring_reg = 0;
> struct amdgpu_device *adev = psp->adev;
>
> - ring = &psp->km_ring;
> -
> /* Write the ring destroy command to C2PMSG_64 */
> psp_ring_reg = 3 << 16;
> WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_64, psp_ring_reg);
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> index e1ebf77..cc5e3ac 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
> @@ -356,12 +356,9 @@ static int psp_v3_1_ring_stop(struct psp_context *psp,
> enum psp_ring_type ring_type)
> {
> int ret = 0;
> - struct psp_ring *ring;
> unsigned int psp_ring_reg = 0;
> struct amdgpu_device *adev = psp->adev;
>
> - ring = &psp->km_ring;
> -
> /* Write the ring destroy command to C2PMSG_64 */
> psp_ring_reg = 3 << 16;
> WREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_64, psp_ring_reg);
> --
> 2.7.0
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2018-11-15 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 12:00 [PATCH v2 -next] drm/amdgpu: remove set but not used variable 'ring' YueHaibing
2018-11-15 20:36 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_Ns03NWNzmgnXS-vm9TG_YW-V2HLRmEctJLdMcP3PoqqA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=David.Francis@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Feifei.Xu@amd.com \
--cc=Likun.Gao@amd.com \
--cc=Shaoyun.Liu@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.huang@amd.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).