From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53794C55ABD for ; Fri, 13 Nov 2020 17:18:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA17F20A8B for ; Fri, 13 Nov 2020 17:18:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cNu+U8Jz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726429AbgKMRRz (ORCPT ); Fri, 13 Nov 2020 12:17:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726166AbgKMRRz (ORCPT ); Fri, 13 Nov 2020 12:17:55 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62293C0613D1 for ; Fri, 13 Nov 2020 09:18:08 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id k2so10770734wrx.2 for ; Fri, 13 Nov 2020 09:18:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MGDV1m39Q0RpjWz9porpS9WltATtsX2nbsrGwBakBoI=; b=cNu+U8JzWYov9+pOuR15lmt9jJN7mU15Fct9ujeB8OBZYHXJijUkou+Rbp9bEgJkzg vxa9qAnS4Grf/3uzQvgJqQIbo1wvji0mABrMYjia8ZfwxiKoEiEPiKdH7c6W9LrEysK2 h8fzkxnD/3UbZD6iqHYdBRwFk9NwubRM9VFsCPkqbg4pl7oRssQ6VIcGdRr1qvcQxrvM fsuUgOEWDejY9NGe7DO1reHM/rt5qlrUu0k5P7I85l/LLpEh8SbKiak4YWKRCHXie5cg 955XfNbnmsskkY8HF1eXKAChkyaWiZsRqy5E3lNLEq/bkG+IGAW4WaGHFFDuEBxRBt6V ssbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MGDV1m39Q0RpjWz9porpS9WltATtsX2nbsrGwBakBoI=; b=Pix37qnTGwIcije7PnDksGEsv1KogW08Kv4bszIBO/r7PJUMci8isoIYrc6zY0T4Uk yXpMpQaaJf+vKrpu5fRv5eYJEWdFcM1/4bBHKvWhjiqnQwvfUOpY3y4jdNxcpcL67vlR gKB/bzFCIIzLLFTaifBEwmrjxgGVI0D+l/PLylTeSkQp6fJ2+GqTrec2UimG6Pw+0xkV dB6cqqoDrHG4QpPUnH/DmfKzDXZqUyf27te4lgKNsOeGAb9vg2GayhvhVw5ccN1wpN1i /DM4fnMRSwgmR4f0yTY7uUYEEczLfrNHwSt/O/Xzpdt1E309/Yz6Of6rIRMmTNtCeNRt +NNg== X-Gm-Message-State: AOAM531QkZJ5r93keDrBiOqKWqD8lD4qkuNHb1hOgeJZ8ytm7lV86IQO aPWkfSNk3vlEj5p+00En1ypJA6doY08Pzmwz93E= X-Google-Smtp-Source: ABdhPJyc+LFP+psa3kZ9XXFFTBsO7MMYF0HBYfo22CWlrebU7Zt7G1eB3hJqkmoT0bo6m/ImkA8fBnM1ja1uK8dwDkk= X-Received: by 2002:adf:8028:: with SMTP id 37mr4635256wrk.111.1605287884168; Fri, 13 Nov 2020 09:18:04 -0800 (PST) MIME-Version: 1.0 References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-12-lee.jones@linaro.org> In-Reply-To: <20201113134938.4004947-12-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 13 Nov 2020 12:17:52 -0500 Message-ID: Subject: Re: [PATCH 11/40] drm/amd/amdgpu/amdgpu_pll: Fix kernel-doc formatting, missing and extra params To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter= or member 'freq' not described in 'amdgpu_pll_compute' > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter= or member 'fb_div_p' not described in 'amdgpu_pll_compute' > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter= or member 'frac_fb_div_p' not described in 'amdgpu_pll_compute' > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter= or member 'ref_div_p' not described in 'amdgpu_pll_compute' > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:121: warning: Function parameter= or member 'post_div_p' not described in 'amdgpu_pll_compute' > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:317: warning: Excess function pa= rameter 'encoder' description in 'amdgpu_pll_get_shared_nondp_ppll' > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c b/drivers/gpu/drm/am= d/amdgpu/amdgpu_pll.c > index 1f2305b7bd135..f2e20666c9c1b 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c > @@ -102,11 +102,12 @@ static void amdgpu_pll_get_fb_ref_div(unsigned nom,= unsigned den, unsigned post_ > * amdgpu_pll_compute - compute PLL paramaters > * > * @pll: information about the PLL > + * @freq: requested frequency > * @dot_clock_p: resulting pixel clock > - * fb_div_p: resulting feedback divider > - * frac_fb_div_p: fractional part of the feedback divider > - * ref_div_p: resulting reference divider > - * post_div_p: resulting reference divider > + * @fb_div_p: resulting feedback divider > + * @frac_fb_div_p: fractional part of the feedback divider > + * @ref_div_p: resulting reference divider > + * @post_div_p: resulting reference divider > * > * Try to calculate the PLL parameters to generate the given frequency: > * dot_clock =3D (ref_freq * feedback_div) / (ref_div * post_div) > @@ -308,7 +309,6 @@ int amdgpu_pll_get_shared_dp_ppll(struct drm_crtc *cr= tc) > * amdgpu_pll_get_shared_nondp_ppll - return the PPLL used by another no= n-DP crtc > * > * @crtc: drm crtc > - * @encoder: drm encoder > * > * Returns the PPLL (Pixel PLL) used by another non-DP crtc/encoder whic= h can > * be shared (i.e., same clock). > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel