From: Alex Deucher <alexdeucher@gmail.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: "Wentland, Harry" <harry.wentland@amd.com>,
"Leo (Sunpeng) Li" <sunpeng.li@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Dave Airlie <airlied@linux.ie>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: Remove unnecessary conversion to bool
Date: Wed, 17 Mar 2021 23:11:45 -0400 [thread overview]
Message-ID: <CADnq5_O+3EQHN8uw14HsPNm9rijveXd=W1Q+18sS_4cGNvA_3w@mail.gmail.com> (raw)
In-Reply-To: <1616035012-88614-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Wed, Mar 17, 2021 at 10:37 PM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warnings:
>
> ./drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb_cm.c:220:65-70:
> WARNING: conversion to bool not needed here.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Applied. Thanks. In general, you can just roll up most these bool
conversion patches into larger patches; no need to fix them all one at
a time.
Alex
> ---
> drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb_cm.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb_cm.c
> index 8593145..3fe9e41 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb_cm.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_dwb_cm.c
> @@ -217,7 +217,7 @@ static bool dwb3_program_ogam_lut(
> else
> next_mode = LUT_RAM_A;
>
> - dwb3_configure_ogam_lut(dwbc30, next_mode == LUT_RAM_A ? true : false);
> + dwb3_configure_ogam_lut(dwbc30, next_mode == LUT_RAM_A);
>
> if (next_mode == LUT_RAM_A)
> dwb3_program_ogam_luta_settings(dwbc30, params);
> --
> 1.8.3.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-03-18 3:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 2:36 [PATCH] drm/amd/display: Remove unnecessary conversion to bool Jiapeng Chong
2021-03-18 3:11 ` Alex Deucher [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-22 2:22 Jiapeng Chong
2021-03-16 8:08 Jiapeng Chong
2021-03-18 3:09 ` Alex Deucher
2021-03-15 8:22 Jiapeng Chong
2021-03-15 18:27 ` Alex Deucher
2021-03-09 8:02 Jiapeng Chong
2021-03-08 3:00 Jiapeng Chong
2021-03-08 21:56 ` Alex Deucher
2021-03-05 6:40 Jiapeng Chong
2021-03-05 19:14 ` Alex Deucher
2021-03-01 6:49 Jiapeng Chong
2021-03-02 18:21 ` Alex Deucher
2021-02-25 9:19 [PATCH] drm/amd/display: remove " Jiapeng Chong
2021-02-25 21:30 ` Alex Deucher
2021-02-23 6:13 [PATCH] drm/amd/display: Remove " Jiapeng Chong
2021-02-23 16:02 ` Alex Deucher
2021-02-20 7:40 Jiapeng Chong
2020-01-10 7:16 [PATCH] drm/amd/display: remove " Chen Zhou
2020-01-10 21:41 ` Harry Wentland
2020-01-11 0:17 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_O+3EQHN8uw14HsPNm9rijveXd=W1Q+18sS_4cGNvA_3w@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).