From: Alex Deucher <alexdeucher@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "David Airlie" <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 18/30] drm/radeon/evergreen_cs: Fix misnaming issues surrounding 'p' param
Date: Tue, 10 Nov 2020 18:57:05 -0500 [thread overview]
Message-ID: <CADnq5_OH9n+7gVUhUXJ5gHPtAMpimDLY8QmjNyDS0S+h=Q3xRw@mail.gmail.com> (raw)
In-Reply-To: <20201110193112.988999-19-lee.jones@linaro.org>
On Tue, Nov 10, 2020 at 2:31 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/radeon/evergreen_cs.c:1026: warning: Function parameter or member 'p' not described in 'evergreen_cs_packet_parse_vline'
> drivers/gpu/drm/radeon/evergreen_cs.c:1026: warning: Excess function parameter 'parser' description in 'evergreen_cs_packet_parse_vline'
> drivers/gpu/drm/radeon/evergreen_cs.c:1095: warning: Function parameter or member 'p' not described in 'evergreen_cs_handle_reg'
> drivers/gpu/drm/radeon/evergreen_cs.c:1095: warning: Excess function parameter 'parser' description in 'evergreen_cs_handle_reg'
> drivers/gpu/drm/radeon/evergreen_cs.c:1757: warning: Function parameter or member 'p' not described in 'evergreen_is_safe_reg'
> drivers/gpu/drm/radeon/evergreen_cs.c:1757: warning: Excess function parameter 'parser' description in 'evergreen_is_safe_reg'
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/radeon/evergreen_cs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
> index c410cad28f19f..53b75cf201958 100644
> --- a/drivers/gpu/drm/radeon/evergreen_cs.c
> +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
> @@ -1015,7 +1015,7 @@ static int evergreen_cs_track_check(struct radeon_cs_parser *p)
>
> /**
> * evergreen_cs_packet_parse_vline() - parse userspace VLINE packet
> - * @parser: parser structure holding parsing context.
> + * @p: parser structure holding parsing context.
> *
> * This is an Evergreen(+)-specific function for parsing VLINE packets.
> * Real work is done by r600_cs_common_vline_parse function.
> @@ -1087,7 +1087,7 @@ static int evergreen_cs_parse_packet0(struct radeon_cs_parser *p,
>
> /**
> * evergreen_cs_handle_reg() - process registers that need special handling.
> - * @parser: parser structure holding parsing context
> + * @p: parser structure holding parsing context
> * @reg: register we are testing
> * @idx: index into the cs buffer
> */
> @@ -1747,7 +1747,7 @@ static int evergreen_cs_handle_reg(struct radeon_cs_parser *p, u32 reg, u32 idx)
>
> /**
> * evergreen_is_safe_reg() - check if register is authorized or not
> - * @parser: parser structure holding parsing context
> + * @p: parser structure holding parsing context
> * @reg: register we are testing
> *
> * This function will test against reg_safe_bm and return true
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-10 23:57 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 19:30 [PATCH 00/30] [Set 4] Rid W=1 warnings from GPU Lee Jones
2020-11-10 19:30 ` [PATCH 01/30] drm/radeon/evergreen: Add comment for 'evergreen_page_flip()'s 'async' param Lee Jones
2020-11-10 22:52 ` Alex Deucher
2020-11-11 7:16 ` Lee Jones
2020-11-10 19:30 ` [PATCH 02/30] drm/radeon/evergreen: Remove set but unused variable 'mc_shared_chmap' Lee Jones
2020-11-10 22:50 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 03/30] drm/radeon/ni: Demote vague attempt at function header doc Lee Jones
2020-11-10 23:32 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 04/30] drm/radeon/si: Remove set but unused variable 'mc_shared_chmap' Lee Jones
2020-11-10 22:53 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 05/30] drm/radeon/cik: " Lee Jones
2020-11-10 23:33 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 06/30] drm/radeon/trinity_dpm: Remove some defined but never used arrays Lee Jones
2020-11-10 23:38 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 07/30] drm/radeon/kv_dpm: Strip out unused functions and their tables Lee Jones
2020-11-10 23:37 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 08/30] drm/radeon/ci_dpm: Remove set but unused variable 'dpm_event_src' Lee Jones
2020-11-10 23:42 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 09/30] drm/radeon/radeon_vm: Fix some function parameter documentation Lee Jones
2020-11-10 23:36 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 10/30] drm/radeon/radeon_sync: Add description for function param 'rdev' Lee Jones
2020-11-10 23:40 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 11/30] drm/radeon/radeon_ib: Supply description for 'radeon_ib_get's get param Lee Jones
2020-11-10 23:41 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 12/30] drm/radeon/radeon_dp_mst: Remove unused variable 'ret' from radeon_mst_encoder_dpms() Lee Jones
2020-11-10 23:39 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 13/30] drm/radeon/radeon_mn: Supply description for 'cur_seq' even if it is unused Lee Jones
2020-11-10 23:52 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 14/30] drm/radeon/evergreen_dma: Fix doc-rot of function parameter 'resv' Lee Jones
2020-11-10 23:57 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 15/30] drm/radeon/cik_sdma: Demote vague attempt at kernel-doc Lee Jones
2020-11-10 23:56 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 16/30] drm/radeon/r100: Fix some kernel-doc formatting, misnaming and missing issues Lee Jones
2020-11-10 23:54 ` Alex Deucher
2020-11-10 19:30 ` [PATCH 17/30] drm/radeon/r600_cs: Fix some doc-rot and supply missing function param docs Lee Jones
2020-11-10 23:55 ` Alex Deucher
2020-11-10 19:31 ` [PATCH 18/30] drm/radeon/evergreen_cs: Fix misnaming issues surrounding 'p' param Lee Jones
2020-11-10 23:57 ` Alex Deucher [this message]
2020-11-10 19:31 ` [PATCH 19/30] drm/radeon/radeon_drv: Move 'radeon_mmap()'s prototype to shared header Lee Jones
2020-11-10 19:31 ` [PATCH 20/30] drm/radeon/radeon_drv: Move 'radeon_driver_irq_handler_kms's prototype into " Lee Jones
2020-11-10 19:31 ` [PATCH 21/30] drm/radeon/atom: Move 'radeon_atom_hw_i2c_*()'s prototypes " Lee Jones
2020-11-10 19:31 ` [PATCH 22/30] drm/radeon/radeon_gem: Move 'radeon_gem_prime_*()'s prototypes to " Lee Jones
2020-11-10 19:31 ` [PATCH 23/30] drm/radeon/evergreen_hdmi: Move 'evergreen_*()' and 'dce4_*()' HDMI " Lee Jones
2020-11-10 19:31 ` [PATCH 24/30] drm/radeon/rv770: Move 'rv770_get_*()'s " Lee Jones
2020-11-10 19:31 ` [PATCH 25/30] drm/radeon/sumo_dpm: Move 'sumo_get_pi()'s prototype into " Lee Jones
2020-11-11 0:05 ` Alex Deucher
2020-11-10 19:31 ` [PATCH 26/30] drm/radeon/ni_dpm: Move 'ni_get_{pi,ps}()'s " Lee Jones
2020-11-10 19:31 ` [PATCH 27/30] drm/radeon/ni: Remove set but unused variable 'mc_shared_chmap' Lee Jones
2020-11-11 0:03 ` Alex Deucher
2020-11-10 19:31 ` [PATCH 28/30] drm/radeon/evergreen: Move 'cayman_*()'s prototypes to shared header Lee Jones
2020-11-10 19:31 ` [PATCH 29/30] drm/radeon/r600_dma: Move 'r600_gpu_check_soft_reset()'s prototype to shared location Lee Jones
2020-11-10 19:31 ` [PATCH 30/30] drm/radeon/cik: Move 'r600_ih_ring_{alloc,fini}()'s prototypes to shared header Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_OH9n+7gVUhUXJ5gHPtAMpimDLY8QmjNyDS0S+h=Q3xRw@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).