From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5C75C61DD8 for ; Fri, 13 Nov 2020 17:26:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AE0021D1A for ; Fri, 13 Nov 2020 17:26:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gvcwXsFd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726394AbgKMR0u (ORCPT ); Fri, 13 Nov 2020 12:26:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726156AbgKMR0t (ORCPT ); Fri, 13 Nov 2020 12:26:49 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E56EC0613D1; Fri, 13 Nov 2020 09:26:49 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id u12so3540609wrt.0; Fri, 13 Nov 2020 09:26:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8iS1C8UHBhMpLbbDu7TV/SpqEICX1ZS5TAuJhzzyFG8=; b=gvcwXsFdEOv/znI10i5jHI+3by1YLLsrRKnb3c7JXoRdbwpVMUsrdS8IHWU8SeWBLU AnX330YexS19lfyz2Wz7Zm+LfhRUiD7kJdUnGMeOPjjkjDmxyQa+wG24PbM8TG/EwjKk TUpB+KVvegwARH5HnMUN0/DrD6ON/NlFK0zYTDw1bfH6jj5JtA6NyhGIIVX/grVIMpIG +Q7WKUaNlq43db6/3HWvtHWgkETat2wfsp3d7NDtIp7+pSkEYDN5vacUEb9Lz9YHzFsE o93Vf1IGs0GgdxTTdOZ7dw0IOtPx4KNM96W0tPSxMnrkWQDJWki+r1JMbFugRwIp4jSd N1ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8iS1C8UHBhMpLbbDu7TV/SpqEICX1ZS5TAuJhzzyFG8=; b=kUAx1CV3LN2Gn1LT9KQwiV6BHt6P7NY0qLTorg7ATiGnGlFJbVy+vXMsCeEvDT8Mik 7/mebDwIM1QmueRJDIse/PQzoV4DykkQEQq5240SV7W/x2VwTosfW1yNnDf+n7NTY1pf 4nDGcq4lwCqMJmjC1SlIcQzUWq4lI03th1EuM/q7tahN+iMbcW5tfdVNlLhg3ZXw+Vyt xwB5/HDZXaUYKW+CttrFqcONfcaj6katKJ+3VtyVJFQl4B3XGf/MKiTDoUIg361DR8F5 P4/MwR/2daZIfFLtm1gSLf+EhaByfi8Ol2atyyHNwIsTMpOvYGPhSVtDSspEe3cnqHbW zygQ== X-Gm-Message-State: AOAM530GyifbaZih+av/r67PtlRMS4Q1gy/M7nxoE6Ug/cSWax/JKlhU NLtFrGyTnL8nh+66m8ZQw2/h101rraKHBD1L8rc= X-Google-Smtp-Source: ABdhPJw2y+1b413Jn+9zmNl1pSTWBVJVbiN4CtaDcHcoAKp0WI5kqKs1HII5R7BSA3JX8BC/e5jFUhTzaT4i/cboQ1c= X-Received: by 2002:adf:e350:: with SMTP id n16mr4962082wrj.419.1605288403359; Fri, 13 Nov 2020 09:26:43 -0800 (PST) MIME-Version: 1.0 References: <20201113134938.4004947-1-lee.jones@linaro.org> <20201113134938.4004947-25-lee.jones@linaro.org> In-Reply-To: <20201113134938.4004947-25-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 13 Nov 2020 12:26:32 -0500 Message-ID: Subject: Re: [PATCH 24/40] drm/amd/amdgpu/amdgpu_ids: Supply missing docs for 'id' and 'vmhub' To: Lee Jones Cc: David Airlie , Felix Kuehling , LKML , amd-gfx list , =?UTF-8?Q?Christian_K=C3=B6nig?= , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Maling list - DRI developers , Alex Deucher , linux-media Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2020 at 8:50 AM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:271: warning: Function parameter= or member 'id' not described in 'amdgpu_vmid_grab_reserved' > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:523: warning: Function parameter= or member 'vmhub' not described in 'amdgpu_vmid_reset' > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: Felix Kuehling > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c b/drivers/gpu/drm/am= d/amdgpu/amdgpu_ids.c > index 6e9a9e5dbea07..61a1331f482c5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c > @@ -259,6 +259,7 @@ static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm= , > * @sync: sync object where we add dependencies > * @fence: fence protecting ID from reuse > * @job: job who wants to use the VMID > + * @id: resulting VMID > * > * Try to assign a reserved VMID. > */ > @@ -514,6 +515,7 @@ void amdgpu_vmid_free_reserved(struct amdgpu_device *= adev, > * amdgpu_vmid_reset - reset VMID to zero > * > * @adev: amdgpu device structure > + * @vmhub: vmhub type > * @vmid: vmid number to use > * > * Reset saved GDW, GWS and OA to force switch on next flush. > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel