From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A29D3C4363A for ; Fri, 30 Oct 2020 03:45:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33EAA21534 for ; Fri, 30 Oct 2020 03:45:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NfiTO9tO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726424AbgJ3DpB (ORCPT ); Thu, 29 Oct 2020 23:45:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726365AbgJ3DpA (ORCPT ); Thu, 29 Oct 2020 23:45:00 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66B1AC0613CF for ; Thu, 29 Oct 2020 20:45:00 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id k10so3609460wrw.13 for ; Thu, 29 Oct 2020 20:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CqRQo1k+LyBootWHIaIxWjANkP7ifh1D8uGLNtgxfI4=; b=NfiTO9tOxd9P308/HhlATOrmcqAD62BLyB79f+18OkTCEA10hoCvxR7zLfUXi5/+kp KldGo5NtKuI+jcxjVy8Gqr02bkHtRt9CHRs4hiiazCClbDwj+ENrxo4mvlry36WvX2XG Hfc9cuTHpbt6ectqZUDDpS0EPNxCUjTISiweYb4ETvTml0blH6j96nYm9au7/26Sndje sof5VpViWl/mpTMcsb0obaLPyri3JwFbPh21iSHQHUVLkIqCZXI2MuwteDJOD6YHS4Uh +rZtkkm6S0uUzkjSruu0NHg0Ac0fjVw5fIbTeTtUOzLHPGcjaMC4qA3CN6xaTp9fwL+9 ZDag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CqRQo1k+LyBootWHIaIxWjANkP7ifh1D8uGLNtgxfI4=; b=U4784cBpj0NoCeBDZvpsjGc4lsgZYMMmFG/3GxkhGu9VSzwNm9WRXQbrsi/9REiekP HzHFzRxmZYzJ8Z1xonKFcYyiLaC0Lu2nZ0J38Sgk2TsP98pFBPUjdyXUVecYB3l9nDJn R/RLV/u9BsOnpeAk/UZdVDGW6QnALjM5XZu1sGIcA5K1mmVebCqypVCCMfsslNFvih4f rBEomtYWFc+bEMUVPumnJo5FZ+AesAHKXheSUnAAvZVMo2d2wsD1LWzFlJbJKhQkyEEk YpCjaH6VKswkavIW4DqSzWA+sd0dS7oiH65QlpKq0jLhEDSNtfihFbUKyVDVrwabLQhh OPQA== X-Gm-Message-State: AOAM5329+IDIPtClVznsQkzrnOa9vTm7BLTzUGKyb9+rs7zgD6sOUI2V VkX7XdLlu4uZqu+gFi/mgHxn0BZ2uVz9iDl6Pbw= X-Google-Smtp-Source: ABdhPJyZsaTRPa6cjCtyjtMW3tmQylPLGZh/UEBXCyh2htGgoNYKtpTOtToxkbQ8qz6xDinhIr5w6dbXejWAKDUGNhw= X-Received: by 2002:adf:dd8f:: with SMTP id x15mr401458wrl.124.1604029499181; Thu, 29 Oct 2020 20:44:59 -0700 (PDT) MIME-Version: 1.0 References: <20201026210039.3884312-1-arnd@kernel.org> <20201026210039.3884312-2-arnd@kernel.org> In-Reply-To: <20201026210039.3884312-2-arnd@kernel.org> From: Alex Deucher Date: Thu, 29 Oct 2020 23:44:47 -0400 Message-ID: Subject: Re: [PATCH 2/5] drm/amdgpu: fix incorrect enum type To: Arnd Bergmann Cc: Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Daniel Vetter , David Galiffi , Jun Lei , Martin Tsai , Arnd Bergmann , Rodrigo Siqueira , Wenjing Liu , LKML , amd-gfx list , Hersen Wu , Maling list - DRI developers , abdoulaye berthe , jinlong zhang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Mon, Oct 26, 2020 at 5:01 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > core_link_write_dpcd() returns enum dc_status, not ddc_result: > > display/dc/core/dc_link_dp.c: In function 'dp_set_panel_mode': > display/dc/core/dc_link_dp.c:4237:11: warning: implicit conversion from 'enum dc_status' to 'enum ddc_result' > [-Wenum-conversion] > > Avoid the warning by using the correct enum in the caller. > > Fixes: 0b226322434c ("drm/amd/display: Synchronous DisplayPort Link Training") > Signed-off-by: Arnd Bergmann > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > index ff1e9963ec7a..98464886341f 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > @@ -4230,7 +4230,7 @@ void dp_set_panel_mode(struct dc_link *link, enum dp_panel_mode panel_mode) > > if (edp_config_set.bits.PANEL_MODE_EDP > != panel_mode_edp) { > - enum ddc_result result = DDC_RESULT_UNKNOWN; > + enum dc_status result = DC_ERROR_UNEXPECTED; > > edp_config_set.bits.PANEL_MODE_EDP = > panel_mode_edp; > @@ -4240,7 +4240,7 @@ void dp_set_panel_mode(struct dc_link *link, enum dp_panel_mode panel_mode) > &edp_config_set.raw, > sizeof(edp_config_set.raw)); > > - ASSERT(result == DDC_RESULT_SUCESSFULL); > + ASSERT(result == DC_OK); > } > } > DC_LOG_DETECTION_DP_CAPS("Link: %d eDP panel mode supported: %d " > -- > 2.27.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel