From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753149AbdKIRxW (ORCPT ); Thu, 9 Nov 2017 12:53:22 -0500 Received: from mail-yw0-f178.google.com ([209.85.161.178]:54086 "EHLO mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753008AbdKIRxU (ORCPT ); Thu, 9 Nov 2017 12:53:20 -0500 X-Google-Smtp-Source: ABhQp+TcETLUbGoP8U+bj+WWOMc401XpIC7klBWX6Tdel6vDRvwYPDOurEU2htTaaju5qeqz76dAMrMBDpfaXQ4Co5A= MIME-Version: 1.0 In-Reply-To: <20171109113500.19593-1-colin.king@canonical.com> References: <20171109113500.19593-1-colin.king@canonical.com> From: Alex Deucher Date: Thu, 9 Nov 2017 12:53:18 -0500 Message-ID: Subject: Re: [PATCH] drm/amd/powerplay: fix copy-n-paste error on vddci_buf index To: Colin King Cc: Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , David Airlie , Rex Zhu , "Edward O'Callaghan" , Huang Rui , amd-gfx list , Maling list - DRI developers , kernel-janitors@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 9, 2017 at 6:35 AM, Colin King wrote: > From: Colin Ian King > > The index to vddci_buf is using profile->ucElbVDDC_Num rather > than profile->ucElbVDDCI_Num; this looks like a copy-n-paste > error from previous code for the vddc_buf array and I'm pretty > sure this is incorrect. Fix this by using the correct variable. > > Detected by CoverityScan, CID#1457172 ("Copy-paste error") > > Fixes: 970d9804b00d ("drm/amd/powerplay: Add support functions for CI to ppatomctrl.c") > Signed-off-by: Colin Ian King Applied. thanks! Alex > --- > drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c b/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c > index a129bc5b1844..c6febbf0bf69 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/ppatomctrl.c > @@ -1486,7 +1486,7 @@ int atomctrl_get_leakage_vddc_base_on_leakage(struct pp_hwmgr *hwmgr, > if (vddci_id_buf[i] == virtual_voltage_id) { > for (j = 0; j < profile->ucLeakageBinNum; j++) { > if (efuse_voltage_id <= leakage_bin[j]) { > - *vddci = vddci_buf[j * profile->ucElbVDDC_Num + i]; > + *vddci = vddci_buf[j * profile->ucElbVDDCI_Num + i]; > break; > } > } > -- > 2.14.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel