From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FD9C64E90 for ; Mon, 30 Nov 2020 23:54:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B99F206E9 for ; Mon, 30 Nov 2020 23:54:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KMbj3Zpz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730613AbgK3XyE (ORCPT ); Mon, 30 Nov 2020 18:54:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730448AbgK3XyE (ORCPT ); Mon, 30 Nov 2020 18:54:04 -0500 Received: from mail-oo1-xc41.google.com (mail-oo1-xc41.google.com [IPv6:2607:f8b0:4864:20::c41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFBBFC0613CF for ; Mon, 30 Nov 2020 15:53:23 -0800 (PST) Received: by mail-oo1-xc41.google.com with SMTP id l10so3106840oom.6 for ; Mon, 30 Nov 2020 15:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NHHcPwGriN5gHC4uSv5ls7SmKd9BGTWdDkFbwUWhYHQ=; b=KMbj3ZpzPjtCxxrCy1rf2XAqnoS5tGfvloqMyxIZu7d/bO3nCrEpXaPPqoP1cSyxmF Due2qTxk9wpZKPXPQOlNJ7/S4+gdp1TWyYNeAjHg3VZfiebFC1AXNtSe0GgD6aaHw1yv Go0Dd5Db0geF3H9E8LzyI5AKHGoLzKmOv5XcejNR29JsDo4/7tleJ7NzNgnNlKIPIkOs rKfq9JjmMc8s6KRJzxluDFkJZNukYL44S/r484klPg3g4qCqcmWOjiz4BxfQv0Iwwjku 9SAonQ34OCzSVrMoMmfeYkAr3WJCVUvV52wobbYw8dWX77Qr8MRabqYSVdKR8YJFptEy bvNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NHHcPwGriN5gHC4uSv5ls7SmKd9BGTWdDkFbwUWhYHQ=; b=P6ZUdSholpNaeYdz99sxdlr+D45oyDX+Mnapf+qctWTfIV4hsDVGHnqM5zM469A0bK eSaYaSDjRTW0vawkPLNhsnYmjRehh437TX7tjL87Q9n1GUP37BEGeJ3qU3k5xuKM8Ea/ UjBbtXN7IPbiFulSPjUHTtSCtaeIumfIbR1mdFa3xjbr3tzVfnuHgv8rtFdxkGGd4kg+ iNqRNosuIj6QJF9OQN32Fy9M2bvtOKH1EJ7pJOaoSIpKswuCx4194jfGEyF3U/kSHpo1 W5k720QVomYRSiUnO+R/0+bhVNIXh8o+j2o+H1Bmhr1JM1zLr+ejlYUY8ac3I8HZjTMH g7ng== X-Gm-Message-State: AOAM5311XG3cV1MPHIWbng3CXJU0HQIZ8KbFlf0TqUuOcidzPvqOUyrS ohxPZEmbpvpzXUVKgXsT7wd8kUu173AqsjiwEk4= X-Google-Smtp-Source: ABdhPJxBO01WNQ9ZTWgBQkpP9dCnXQzmSPjr5/phSUeAOmUvsKbi/eQ+8nhS2f9yaLFpkSwKV6g5l8M1fbgcVSU01Wk= X-Received: by 2002:a4a:e0ce:: with SMTP id e14mr60877oot.72.1606780403439; Mon, 30 Nov 2020 15:53:23 -0800 (PST) MIME-Version: 1.0 References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-30-lee.jones@linaro.org> In-Reply-To: <20201126134240.3214176-30-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 30 Nov 2020 18:53:11 -0500 Message-ID: Subject: Re: [PATCH 29/40] drm/amd/pm/powerplay/hwmgr/vega20_thermal: Fix some outdated function documentation To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:217: w= arning: Function parameter or member 'hwmgr' not described in 'vega20_therm= al_get_temperature' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:242: w= arning: Function parameter or member 'hwmgr' not described in 'vega20_therm= al_set_temperature_range' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:242: w= arning: Function parameter or member 'range' not described in 'vega20_therm= al_set_temperature_range' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:278: w= arning: Function parameter or member 'hwmgr' not described in 'vega20_therm= al_enable_alert' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:296: w= arning: Function parameter or member 'hwmgr' not described in 'vega20_therm= al_disable_alert' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:310: w= arning: Function parameter or member 'hwmgr' not described in 'vega20_therm= al_stop_thermal_controller' > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega20_thermal.c:326: w= arning: Function parameter or member 'hwmgr' not described in 'vega20_therm= al_setup_fan_table' > > Cc: Evan Quan > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > .../amd/pm/powerplay/hwmgr/vega20_thermal.c | 54 +++++++++---------- > 1 file changed, 24 insertions(+), 30 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_thermal.c b/dr= ivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_thermal.c > index 364162ddaa9c6..269dd7e95a445 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_thermal.c > +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_thermal.c > @@ -209,10 +209,10 @@ int vega20_fan_ctrl_set_fan_speed_rpm(struct pp_hwm= gr *hwmgr, uint32_t speed) > } > > /** > -* Reads the remote temperature from the SIslands thermal controller. > -* > -* @param hwmgr The address of the hardware manager. > -*/ > + * vega20_thermal_get_temperature - Reads the remote temperature from th= e SIslands thermal controller. > + * > + * @hwmgr: The address of the hardware manager. > + */ > int vega20_thermal_get_temperature(struct pp_hwmgr *hwmgr) > { > struct amdgpu_device *adev =3D hwmgr->adev; > @@ -230,13 +230,12 @@ int vega20_thermal_get_temperature(struct pp_hwmgr = *hwmgr) > } > > /** > -* Set the requested temperature range for high and low alert signals > -* > -* @param hwmgr The address of the hardware manager. > -* @param range Temperature range to be programmed for > -* high and low alert signals > -* @exception PP_Result_BadInput if the input data is not valid. > -*/ > + * vega20_thermal_set_temperature_range - Set the requested temperature = range for high and low alert signals > + * > + * @hwmgr: The address of the hardware manager. > + * @range: Temperature range to be programmed for high and low alert sig= nals > + * Exception: PP_Result_BadInput if the input data is not valid. > + */ > static int vega20_thermal_set_temperature_range(struct pp_hwmgr *hwmgr, > struct PP_TemperatureRange *range) > { > @@ -270,10 +269,10 @@ static int vega20_thermal_set_temperature_range(str= uct pp_hwmgr *hwmgr, > } > > /** > -* Enable thermal alerts on the RV770 thermal controller. > -* > -* @param hwmgr The address of the hardware manager. > -*/ > + * vega20_thermal_enable_alert - Enable thermal alerts on the RV770 ther= mal controller. > + * > + * @hwmgr: The address of the hardware manager. > + */ > static int vega20_thermal_enable_alert(struct pp_hwmgr *hwmgr) > { > struct amdgpu_device *adev =3D hwmgr->adev; > @@ -289,9 +288,9 @@ static int vega20_thermal_enable_alert(struct pp_hwmg= r *hwmgr) > } > > /** > -* Disable thermal alerts on the RV770 thermal controller. > -* @param hwmgr The address of the hardware manager. > -*/ > + * vega20_thermal_disable_alert - Disable thermal alerts on the RV770 th= ermal controller. > + * @hwmgr: The address of the hardware manager. > + */ > int vega20_thermal_disable_alert(struct pp_hwmgr *hwmgr) > { > struct amdgpu_device *adev =3D hwmgr->adev; > @@ -302,10 +301,10 @@ int vega20_thermal_disable_alert(struct pp_hwmgr *h= wmgr) > } > > /** > -* Uninitialize the thermal controller. > -* Currently just disables alerts. > -* @param hwmgr The address of the hardware manager. > -*/ > + * vega20_thermal_stop_thermal_controller - Uninitialize the thermal con= troller. > + * Currently just disables alerts. > + * @hwmgr: The address of the hardware manager. > + */ > int vega20_thermal_stop_thermal_controller(struct pp_hwmgr *hwmgr) > { > int result =3D vega20_thermal_disable_alert(hwmgr); > @@ -314,14 +313,9 @@ int vega20_thermal_stop_thermal_controller(struct pp= _hwmgr *hwmgr) > } > > /** > -* Set up the fan table to control the fan using the SMC. > -* @param hwmgr the address of the powerplay hardware manager. > -* @param pInput the pointer to input data > -* @param pOutput the pointer to output data > -* @param pStorage the pointer to temporary storage > -* @param Result the last failure code > -* @return result from set temperature range routine > -*/ > + * vega20_thermal_setup_fan_table - Set up the fan table to control the = fan using the SMC. > + * @hwmgr: the address of the powerplay hardware manager. > + */ > static int vega20_thermal_setup_fan_table(struct pp_hwmgr *hwmgr) > { > int ret; > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel