From: Alex Deucher <alexdeucher@gmail.com>
To: CGEL <cgel.zte@gmail.com>
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
Dave Airlie <airlied@linux.ie>, Zeal Robot <zealci@zte.com.cn>,
xinhui pan <Xinhui.Pan@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Christian Koenig <christian.koenig@amd.com>,
Minghao Chi <chi.minghao@zte.com.cn>
Subject: Re: [PATCH] drm/amdgpu: simplify the return expression of iceland_ih_hw_init
Date: Fri, 29 Apr 2022 11:16:52 -0400 [thread overview]
Message-ID: <CADnq5_Oo4KM+Jjiy8b+42UAP5PhaEMp76zS7gi3iRua2jTyUPQ@mail.gmail.com> (raw)
In-Reply-To: <20220429054841.3851915-1-chi.minghao@zte.com.cn>
Applied. Thanks!
On Fri, Apr 29, 2022 at 1:48 AM <cgel.zte@gmail.com> wrote:
>
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> drivers/gpu/drm/amd/amdgpu/iceland_ih.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/iceland_ih.c b/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
> index ddfe4eaeea05..aecad530b10a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/iceland_ih.c
> @@ -308,14 +308,9 @@ static int iceland_ih_sw_fini(void *handle)
>
> static int iceland_ih_hw_init(void *handle)
> {
> - int r;
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> - r = iceland_ih_irq_init(adev);
> - if (r)
> - return r;
> -
> - return 0;
> + return iceland_ih_irq_init(adev);
> }
>
> static int iceland_ih_hw_fini(void *handle)
> --
> 2.25.1
>
>
prev parent reply other threads:[~2022-04-29 15:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 5:48 [PATCH] drm/amdgpu: simplify the return expression of iceland_ih_hw_init cgel.zte
2022-04-29 15:16 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_Oo4KM+Jjiy8b+42UAP5PhaEMp76zS7gi3iRua2jTyUPQ@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).