From: Alex Deucher <alexdeucher@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "David Airlie" <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 36/38] drm/amd/amdgpu/vcn_v1_0: Fix some function naming disparity
Date: Thu, 20 May 2021 15:25:32 -0400 [thread overview]
Message-ID: <CADnq5_OpCwYAJOX1wDSpkYFg8wt9VroU0PmPstcgSe=h7cw60A@mail.gmail.com> (raw)
In-Reply-To: <20210520120248.3464013-37-lee.jones@linaro.org>
Applied. Thanks!
On Thu, May 20, 2021 at 8:03 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:775: warning: expecting prototype for vcn_v1_0_start(). Prototype was for vcn_v1_0_start_spg_mode() instead
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1111: warning: expecting prototype for vcn_v1_0_stop(). Prototype was for vcn_v1_0_stop_spg_mode() instead
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> index 0c1beefa3e498..2c9af18683feb 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> @@ -765,7 +765,7 @@ static void vcn_1_0_enable_static_power_gating(struct amdgpu_device *adev)
> }
>
> /**
> - * vcn_v1_0_start - start VCN block
> + * vcn_v1_0_start_spg_mode - start VCN block
> *
> * @adev: amdgpu_device pointer
> *
> @@ -1101,7 +1101,7 @@ static int vcn_v1_0_start(struct amdgpu_device *adev)
> }
>
> /**
> - * vcn_v1_0_stop - stop VCN block
> + * vcn_v1_0_stop_spg_mode - stop VCN block
> *
> * @adev: amdgpu_device pointer
> *
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-05-20 19:25 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 12:02 [PATCH 00/38] Rid W=1 warnings from GPU Lee Jones
2021-05-20 12:02 ` [PATCH 01/38] drm/mediatek/mtk_disp_color: Strip incorrect doc and demote header Lee Jones
2021-05-20 12:02 ` [PATCH 02/38] drm/mediatek/mtk_disp_gamma: Strip and demote non-conformant kernel-doc header Lee Jones
2021-05-20 12:02 ` [PATCH 03/38] drm/radeon/radeon_cs: Fix incorrectly documented function 'radeon_cs_parser_fini' Lee Jones
2021-05-20 12:04 ` Christian König
2021-05-20 19:07 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 04/38] drm/mediatek/mtk_disp_ovl: Strip and demote non-conformant header Lee Jones
2021-05-20 12:02 ` [PATCH 05/38] drm/mediatek/mtk_disp_rdma: Strip and demote non-conformant kernel-doc header Lee Jones
2021-05-20 12:02 ` [PATCH 06/38] drm/sti/sti_hdmi_tx3g4c28phy: Provide function names for kernel-doc headers Lee Jones
2021-05-20 12:02 ` [PATCH 07/38] drm/sti/sti_hda: Provide missing function names Lee Jones
2021-05-20 14:47 ` Fabien DESSENNE
2021-05-20 12:02 ` [PATCH 08/38] drm/sti/sti_tvout: Provide a bunch of " Lee Jones
2021-05-20 12:02 ` [PATCH 09/38] drm/sti/sti_hqvdp: Fix incorrectly named function 'sti_hqvdp_vtg_cb()' Lee Jones
2021-05-20 14:48 ` Fabien DESSENNE
2021-05-20 12:02 ` [PATCH 10/38] drm/amd/amdgpu/amdgpu_ids: Correct some function name disparity Lee Jones
2021-05-20 12:04 ` Christian König
2021-05-20 19:08 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 11/38] drm/amd/amdgpu/amdgpu_debugfs: Fix a couple of misnamed functions Lee Jones
2021-05-20 19:10 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 12/38] drm/amd/amdgpu/amdgpu_gmc: Fix a little naming related doc-rot Lee Jones
2021-05-20 19:10 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 13/38] drm/amd/amdgpu/cik_sdma: Fix a few incorrectly named functions Lee Jones
2021-05-20 19:12 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 14/38] drm/amd/amdgpu/gfx_v7_0: Repair function names in the documentation Lee Jones
2021-05-20 19:13 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 15/38] drm/msm/disp/dpu1/dpu_encoder_phys_cmd: Remove unused variable 'cmd_enc' Lee Jones
2021-05-20 12:02 ` [PATCH 16/38] drm/amd/amdgpu/si_dma: Fix some function name disparity Lee Jones
2021-05-20 19:14 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 17/38] drm/amd/amdgpu/dce_v6_0: Repair function name of 'si_get_number_of_dram_channels()' Lee Jones
2021-05-20 19:15 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 18/38] drm/msm/disp/dpu1/dpu_hw_interrupts: Demote a bunch of kernel-doc abuses Lee Jones
2021-05-20 12:02 ` [PATCH 19/38] drm/radeon/cik: Fix incorrectly named function 'cik_irq_suspend()' Lee Jones
2021-05-20 19:15 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 20/38] drm/radeon/radeon_vm: Fix function naming disparities Lee Jones
2021-05-20 12:05 ` Christian König
2021-05-20 19:16 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 21/38] drm/amd/include/aldebaran_ip_offset: Mark top-level IP_BASE as __maybe_unused Lee Jones
2021-05-20 19:17 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 22/38] drm/msm/disp/dpu1/dpu_plane: Fix a couple of naming issues Lee Jones
2021-05-20 12:02 ` [PATCH 23/38] drm/amd/amdgpu/gmc_v7_0: Fix potential copy/paste issue Lee Jones
2021-05-20 19:18 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 24/38] drm/amd/amdgpu/mmhub_v9_4: Fix naming disparity with 'mmhub_v9_4_set_fault_enable_default()' Lee Jones
2021-05-20 19:19 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 25/38] drm/msm/msm_gem: Demote kernel-doc abuses Lee Jones
2021-05-20 12:02 ` [PATCH 26/38] drm/amd/amdgpu/gmc_v10_0: Fix potential copy/paste issue Lee Jones
2021-05-20 19:20 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 27/38] drm/msm/dp/dp_catalog: Correctly document param 'dp_catalog' Lee Jones
2021-05-21 22:58 ` Stephen Boyd
2021-05-20 12:02 ` [PATCH 28/38] drm/msm/dp/dp_link: Fix some potential doc-rot Lee Jones
2021-05-20 12:02 ` [PATCH 29/38] drm/radeon/r100: Realign doc header with function 'r100_cs_packet_parse_vline()' Lee Jones
2021-05-20 19:20 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 30/38] drm/amd/amdgpu/gfx_v9_4_2: Mark functions called by reference as static Lee Jones
2021-05-20 19:21 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 31/38] drm/amd/amdgpu/sdma_v2_4: Correct misnamed function 'sdma_v2_4_ring_emit_hdp_flush()' Lee Jones
2021-05-20 19:22 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 32/38] drm/amd/amdgpu/sdma_v4_0: Realign functions with their headers Lee Jones
2021-05-20 19:23 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 33/38] drm/amd/amdgpu/sdma_v5_0: Fix typo in function name Lee Jones
2021-05-20 19:23 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 34/38] drm/amd/amdgpu/amdgpu_vce: Fix a few incorrectly named functions Lee Jones
2021-05-20 19:27 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 35/38] drm/amd/amdgpu/sdma_v5_2: Repair typo in function name Lee Jones
2021-05-20 19:24 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 36/38] drm/amd/amdgpu/vcn_v1_0: Fix some function naming disparity Lee Jones
2021-05-20 19:25 ` Alex Deucher [this message]
2021-05-20 12:02 ` [PATCH 37/38] drm/amd/amdgpu/gfx_v10_0: Demote kernel-doc abuse Lee Jones
2021-05-20 19:26 ` Alex Deucher
2021-05-20 12:02 ` [PATCH 38/38] drm/amd/amdgpu/smuio_v13_0: Realign 'smuio_v13_0_is_host_gpu_xgmi_supported()' header Lee Jones
2021-05-20 19:26 ` Alex Deucher
2021-05-21 7:10 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_OpCwYAJOX1wDSpkYFg8wt9VroU0PmPstcgSe=h7cw60A@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).