From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932635AbcISRZu (ORCPT ); Mon, 19 Sep 2016 13:25:50 -0400 Received: from mail-yw0-f194.google.com ([209.85.161.194]:33936 "EHLO mail-yw0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932261AbcISRZs (ORCPT ); Mon, 19 Sep 2016 13:25:48 -0400 MIME-Version: 1.0 In-Reply-To: <976bba66-8e9b-d5ee-a266-d291986e63d7@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <8d614254-1cba-0379-cf84-52ad9bd9f3a7@users.sourceforge.net> <976bba66-8e9b-d5ee-a266-d291986e63d7@users.sourceforge.net> From: Alex Deucher Date: Mon, 19 Sep 2016 13:25:46 -0400 Message-ID: Subject: Re: [PATCH 1/5] drm/amdgpu: Use kmalloc_array() in amdgpu_debugfs_gca_config_read() To: SF Markus Elfring Cc: Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , Chunming Zhou , David Airlie , Monk Liu , Tom St Denis , Julia Lawall , kernel-janitors@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 18, 2016 at 12:50 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 18 Sep 2016 17:00:52 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Applied. thanks. > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > index df7ab245..2709ebd 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -2438,7 +2438,7 @@ static ssize_t amdgpu_debugfs_gca_config_read(struct file *f, char __user *buf, > if (size & 0x3 || *pos & 0x3) > return -EINVAL; > > - config = kmalloc(256 * sizeof(*config), GFP_KERNEL); > + config = kmalloc_array(256, sizeof(*config), GFP_KERNEL); > if (!config) > return -ENOMEM; > > -- > 2.10.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel