From: Alex Deucher <alexdeucher@gmail.com>
To: pengfuyuan <pengfuyuan@kylinos.cn>
Cc: "Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>, "xinhui pan" <Xinhui.Pan@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"David Airlie" <airlied@linux.ie>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm/amd/display: Remove macro DC_DEFAULT_LOG_MASK
Date: Fri, 13 May 2022 12:55:15 -0400 [thread overview]
Message-ID: <CADnq5_P+ibMk_z69CxH_Q60YL259US9f7uv3MDnMgU7pX47MuQ@mail.gmail.com> (raw)
In-Reply-To: <20220513062045.840780-1-pengfuyuan@kylinos.cn>
On Fri, May 13, 2022 at 3:20 AM pengfuyuan <pengfuyuan@kylinos.cn> wrote:
>
> [Why]
> The DC_DEFAULT_LOG_MASK macro has not been used for a long time, so remove it.
I'm sure there are lots of macros in the driver that are not used at
the moment. Any particular reason to remove it? DC_MIN_LOG_MASK
doesn't appear to be used at the moment either.
Alex
>
> Signed-off-by: pengfuyuan <pengfuyuan@kylinos.cn>
> ---
> .../drm/amd/display/include/logger_types.h | 33 -------------------
> 1 file changed, 33 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/include/logger_types.h b/drivers/gpu/drm/amd/display/include/logger_types.h
> index f093b49c5e6e..1b38cfc41718 100644
> --- a/drivers/gpu/drm/amd/display/include/logger_types.h
> +++ b/drivers/gpu/drm/amd/display/include/logger_types.h
> @@ -131,37 +131,4 @@ enum dc_log_type {
> #define DC_MIN_LOG_MASK ((1 << LOG_ERROR) | \
> (1 << LOG_DETECTION_EDID_PARSER))
>
> -#define DC_DEFAULT_LOG_MASK ((1ULL << LOG_ERROR) | \
> - (1ULL << LOG_WARNING) | \
> - (1ULL << LOG_EVENT_MODE_SET) | \
> - (1ULL << LOG_EVENT_DETECTION) | \
> - (1ULL << LOG_EVENT_LINK_TRAINING) | \
> - (1ULL << LOG_EVENT_LINK_LOSS) | \
> - (1ULL << LOG_EVENT_UNDERFLOW) | \
> - (1ULL << LOG_RESOURCE) | \
> - (1ULL << LOG_FEATURE_OVERRIDE) | \
> - (1ULL << LOG_DETECTION_EDID_PARSER) | \
> - (1ULL << LOG_DC) | \
> - (1ULL << LOG_HW_HOTPLUG) | \
> - (1ULL << LOG_HW_SET_MODE) | \
> - (1ULL << LOG_HW_RESUME_S3) | \
> - (1ULL << LOG_HW_HPD_IRQ) | \
> - (1ULL << LOG_SYNC) | \
> - (1ULL << LOG_BANDWIDTH_VALIDATION) | \
> - (1ULL << LOG_MST) | \
> - (1ULL << LOG_DETECTION_DP_CAPS) | \
> - (1ULL << LOG_BACKLIGHT)) | \
> - (1ULL << LOG_I2C_AUX) | \
> - (1ULL << LOG_IF_TRACE) | \
> - (1ULL << LOG_HDMI_FRL) | \
> - (1ULL << LOG_SCALER) | \
> - (1ULL << LOG_DTN) /* | \
> - (1ULL << LOG_DEBUG) | \
> - (1ULL << LOG_BIOS) | \
> - (1ULL << LOG_SURFACE) | \
> - (1ULL << LOG_DML) | \
> - (1ULL << LOG_HW_LINK_TRAINING) | \
> - (1ULL << LOG_HW_AUDIO)| \
> - (1ULL << LOG_BANDWIDTH_CALCS)*/
> -
> #endif /* __DAL_LOGGER_TYPES_H__ */
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-05-13 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 6:20 [PATCH] drm/amd/display: Remove macro DC_DEFAULT_LOG_MASK pengfuyuan
2022-05-13 16:55 ` Alex Deucher [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-12 8:48 pengfuyuan
2022-05-12 17:59 ` kernel test robot
2022-05-13 7:58 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_P+ibMk_z69CxH_Q60YL259US9f7uv3MDnMgU7pX47MuQ@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pengfuyuan@kylinos.cn \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).