From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88DAEC63777 for ; Mon, 30 Nov 2020 23:16:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF79A2076C for ; Mon, 30 Nov 2020 23:16:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pmy0R54X" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728107AbgK3XQ6 (ORCPT ); Mon, 30 Nov 2020 18:16:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726737AbgK3XQ5 (ORCPT ); Mon, 30 Nov 2020 18:16:57 -0500 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61EA5C0613CF for ; Mon, 30 Nov 2020 15:16:17 -0800 (PST) Received: by mail-ot1-x342.google.com with SMTP id n12so13080573otk.0 for ; Mon, 30 Nov 2020 15:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WoziKHC+v4Z3OAENXM/ouuGFrIDPeNU+vHY9PKFX1EM=; b=Pmy0R54X8eY3knO6XtefsNf8EC9w4xiJxLjtgN5Tp6Vhq/RY8OyUihEHnHGfSTxzqX JPqwtrF2ZdRDapeZMAiWyQ2Dysy9uI1WoxNHoGszY5iXvKvUOx9GQOWAjMUpo6IITdBN ynHDBk2ntelaAUmkczLDpSO1I/niJf8Ceg1taGPQ/xhpMZisbzpqjHKkZ2zHilkTH9iR 9dtmLZfbWbJvFDVkHnBwmxkvr/xzSLiyMrzAPUpvqBv47gNYJyyhy2eJYrLkwhO8mEjA lLQeoC5TWcxbRPXziaOI8q63Omvxx0xhgDyJHnYjThuDwMFby1GNLfD+ZCElOvyeUXKT qskw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WoziKHC+v4Z3OAENXM/ouuGFrIDPeNU+vHY9PKFX1EM=; b=CUh0XcxWsT1gW2LgWto1P2UYKAs6DZl08IXkhK7baJiZiXYAKH0I1SwbvcE7vpWSgk jCwh19j4/CwxfjsesoVzqyBHRET46mltE5I9r8elahDRup+Mk5qVtPGCNZWfpTbUOFLz fYJnuBTkHvI37trs/wFAjZPhk6QAt7OvKzk/i/yfJhM2iGeSdxxRJRquwfFAZPv97xTd X1R/Ggj0FatOLvjR6YSSazniUOq/BJ5mORTkTdGzhu/Vi5LIlFBEkKb1GFQYx14Z+9Bf T51+yZoM8Z6is5/QdJWXnG0XNVAsNKpQUT9RMjCR7+VhkY0FoN1YyWly4Nz4rDNnaQuN QN0A== X-Gm-Message-State: AOAM531hDVS2cLmdeW2uDZNAg3abGeI7zifjaTCpMr9vv5QOSrWinq26 gMi/qI002yXWIvMci0lFMAcaCSge2Ds4K8I7Q2c= X-Google-Smtp-Source: ABdhPJzppF+6OtMTgVzZ9oC0mWh6FYFcWr0qeCVxeAKLpnIGdZmnV2XdLi5F60mTJbI9WFpvP4nD9Tj8gx2MTKQXwEA= X-Received: by 2002:a9d:4713:: with SMTP id a19mr19346501otf.132.1606778176787; Mon, 30 Nov 2020 15:16:16 -0800 (PST) MIME-Version: 1.0 References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-5-lee.jones@linaro.org> In-Reply-To: <20201126134240.3214176-5-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 30 Nov 2020 18:16:05 -0500 Message-ID: Subject: Re: [PATCH 04/40] drm/amd/pm/powerplay/smumgr/iceland_smumgr: Make function called by reference static To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Huang Rui , Maling list - DRI developers , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c:2085:= 5: warning: no previous prototype for =E2=80=98iceland_thermal_setup_fan_ta= ble=E2=80=99 [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c: In f= unction =E2=80=98iceland_thermal_setup_fan_table=E2=80=99: > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/iceland_smumgr.c:2093:= 6: warning: variable =E2=80=98res=E2=80=99 set but not used [-Wunused-but-s= et-variable] > > Cc: Evan Quan > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Huang Rui > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c b/d= rivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c > index 431ad2fd38df1..6a0f581de999b 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c > +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/iceland_smumgr.c > @@ -2082,7 +2082,7 @@ static int iceland_init_smc_table(struct pp_hwmgr *= hwmgr) > return 0; > } > > -int iceland_thermal_setup_fan_table(struct pp_hwmgr *hwmgr) > +static int iceland_thermal_setup_fan_table(struct pp_hwmgr *hwmgr) > { > struct smu7_smumgr *smu7_data =3D (struct smu7_smumgr *)(hwmgr->s= mu_backend); > SMU71_Discrete_FanTable fan_table =3D { FDO_MODE_HARDWARE }; > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel