From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22DF8C63777 for ; Mon, 30 Nov 2020 23:35:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFAC6207BB for ; Mon, 30 Nov 2020 23:35:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ryNpJxgG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388990AbgK3Xet (ORCPT ); Mon, 30 Nov 2020 18:34:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388951AbgK3Xes (ORCPT ); Mon, 30 Nov 2020 18:34:48 -0500 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7F8CC0613CF for ; Mon, 30 Nov 2020 15:34:07 -0800 (PST) Received: by mail-ot1-x343.google.com with SMTP id z23so9434086oti.13 for ; Mon, 30 Nov 2020 15:34:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PeewXy7NC7XXblYMxEWdawjkTVhWy4LJb2cZR8KPRgU=; b=ryNpJxgGgmPAR25f2mBd4A2HVAqiC4jjs1MlZnbBf9PfQn2NiNQLGpMA0a7MSZewPq d3CBIhmvc2Exao/qyM9B/GNxyo1GrnuxJ7gW21ZirtiXN3dkdXt+tqfjaVuTIHPZUv6j Nd3MyEHmNHFZCh+MkWJklXOnhcGxp0esx4qnFaOteCsB6IFOoDWgcsmffm/aCJpsMc2V jpZWX5VD1x4cZYigjtG/ktXhbwmn1lUx0jLEq2SSK76rniR+tDSVH0kn4/KsdbLtXzM9 TmZhVWpWZ3L22hf1Bwv5fYKlwMjSvy0R0lJ7wqb5JQiQcoDzQybwFpoZGTSCnVyEzLvY opSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PeewXy7NC7XXblYMxEWdawjkTVhWy4LJb2cZR8KPRgU=; b=o6zfKfpFv1mvb+I2LSnD1m2OzrGT2UZ8NkuY44CBOFdHWIEHRuIiWYvu1B8yo8/cGO VjMRTchW8t/HVD3CWaG0lFRahGr5fyLmfkJlH5cd72B/8L3Pe7Xe0rhD5YHfs71PBTH1 uNghB3mcBhVXMqlsDRM17LQOCF2aEGprqam89GJ63/sdVacoOEKra+Kw+pq/9U0j5SSL Lb+cGPW8PZFRZTstzlzkpMzLvO+6B4JsIOsrbdIQ1OnIEPAKQqh8UjBUc0ghuf2V4FP6 2Gdy8Xwt4EC6JLIq8vg8/zQOlw881Risr9RTBD/j16XytUoAFE7uQaeq2oMvFDpVzGwg rFUA== X-Gm-Message-State: AOAM530Us0LbBgn4JBKLq08AHWUBdj5gsIBIhprTn3jnsQS7cKkGVu0B DOoVLYEXsksxeQN2aaRo8USKACMsg9fy6dWvqNY= X-Google-Smtp-Source: ABdhPJzbM+ERYLAt2H3fxGgdW4jJgjNLIKnHBnoHDRo0SfL7na09rjAyUilpsPkvBfuszsm/jzRc/smso1HH9R/7LUM= X-Received: by 2002:a9d:5388:: with SMTP id w8mr18962424otg.311.1606779247247; Mon, 30 Nov 2020 15:34:07 -0800 (PST) MIME-Version: 1.0 References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-14-lee.jones@linaro.org> In-Reply-To: <20201126134240.3214176-14-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 30 Nov 2020 18:33:55 -0500 Message-ID: Subject: Re: [PATCH 13/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move 'smu7_init_function_pointers()'s prototype to header To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 8:43 AM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:5696:5: wa= rning: no previous prototype for =E2=80=98smu7_init_function_pointers=E2=80= =99 [-Wmissing-prototypes] > 5696 | int smu7_init_function_pointers(struct pp_hwmgr *hwmgr) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Cc: Evan Quan > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/pm/inc/hwmgr.h | 1 + > drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c | 1 - > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/inc/hwmgr.h b/drivers/gpu/drm/amd/pm/= inc/hwmgr.h > index 0e22cba3ce3a6..393e4e76a8961 100644 > --- a/drivers/gpu/drm/amd/pm/inc/hwmgr.h > +++ b/drivers/gpu/drm/amd/pm/inc/hwmgr.h > @@ -828,6 +828,7 @@ int hwmgr_handle_task(struct pp_hwmgr *hwmgr, > > #define PHM_ENTIRE_REGISTER_MASK 0xFFFFFFFFU > > +int smu7_init_function_pointers(struct pp_hwmgr *hwmgr); > int smu8_init_function_pointers(struct pp_hwmgr *hwmgr); > > #endif /* _HWMGR_H_ */ > diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c b/drivers/gpu= /drm/amd/pm/powerplay/hwmgr/hwmgr.c > index ec17a3e63ea02..7999091cca16e 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c > +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hwmgr.c > @@ -46,7 +46,6 @@ extern const struct pp_smumgr_func vega12_smu_funcs; > extern const struct pp_smumgr_func smu10_smu_funcs; > extern const struct pp_smumgr_func vega20_smu_funcs; > > -extern int smu7_init_function_pointers(struct pp_hwmgr *hwmgr); > extern int vega10_hwmgr_init(struct pp_hwmgr *hwmgr); > extern int vega12_hwmgr_init(struct pp_hwmgr *hwmgr); > extern int vega20_hwmgr_init(struct pp_hwmgr *hwmgr); > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel