From: Alex Deucher <alexdeucher@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "David Airlie" <airlied@linux.ie>,
LKML <linux-kernel@vger.kernel.org>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Evan Quan" <evan.quan@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 27/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix worthy function headers, demote barely documented one
Date: Fri, 8 Jan 2021 16:15:33 -0500 [thread overview]
Message-ID: <CADnq5_P=6PbbOLYE6PiXP1_J9weqZgrKRwGU3Q7ZsRnx7BX2eA@mail.gmail.com> (raw)
In-Reply-To: <20210108201457.3078600-28-lee.jones@linaro.org>
On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1556: warning: Function parameter or member 'acg_freq' not described in 'vega10_populate_single_gfx_level'
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: warning: Function parameter or member 'current_soc_did' not described in 'vega10_populate_single_soc_level'
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: warning: Function parameter or member 'current_vol_index' not described in 'vega10_populate_single_soc_level'
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: warning: Excess function parameter 'current_socclk_level' description in 'vega10_populate_single_soc_level'
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: warning: Function parameter or member 'current_mem_vid' not described in 'vega10_populate_single_memory_level'
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: warning: Function parameter or member 'current_memclk_level' not described in 'vega10_populate_single_memory_level'
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: warning: Function parameter or member 'current_mem_soc_vind' not described in 'vega10_populate_single_memory_level'
> drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:2871: warning: Function parameter or member 'bitmap' not described in 'vega10_start_dpm'
>
> Cc: Evan Quan <evan.quan@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian König" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> index da470462d6e2c..29c99642d22d4 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> @@ -1549,6 +1549,7 @@ static int vega10_populate_smc_link_levels(struct pp_hwmgr *hwmgr)
> * @hwmgr: the address of the hardware manager
> * @gfx_clock: the GFX clock to use to populate the structure.
> * @current_gfxclk_level: location in PPTable for the SMC GFXCLK structure.
> + * @acg_freq: ACG frequenty to return (MHz)
> */
> static int vega10_populate_single_gfx_level(struct pp_hwmgr *hwmgr,
> uint32_t gfx_clock, PllSetting_t *current_gfxclk_level,
> @@ -1612,7 +1613,8 @@ static int vega10_populate_single_gfx_level(struct pp_hwmgr *hwmgr,
> *
> * @hwmgr: the address of the hardware manager.
> * @soc_clock: the SOC clock to use to populate the structure.
> - * @current_socclk_level: location in PPTable for the SMC SOCCLK structure.
> + * @current_soc_did: DFS divider to pass back to caller
> + * @current_vol_index: index of current VDD to pass back to caller
> * return: 0 on success
> */
> static int vega10_populate_single_soc_level(struct pp_hwmgr *hwmgr,
> @@ -1744,7 +1746,7 @@ static void vega10_populate_vddc_soc_levels(struct pp_hwmgr *hwmgr)
> }
> }
>
> -/**
> +/*
> * Populates single SMC GFXCLK structure using the provided clock.
> *
> * @hwmgr: the address of the hardware manager.
> @@ -2863,8 +2865,8 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap)
> /**
> * Tell SMC to enabled the supported DPMs.
> *
> - * @hwmgr: the address of the powerplay hardware manager.
> - * @bitmap bitmap for the features to enabled.
> + * @hwmgr: the address of the powerplay hardware manager.
> + * @bitmap: bitmap for the features to enabled.
> * return: 0 on at least one DPM is successfully enabled.
> */
> static int vega10_start_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap)
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-08 21:16 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 20:14 [PATCH 00/40] [Set 11] Rid W=1 warnings from GPU Lee Jones
2021-01-08 20:14 ` [PATCH 01/40] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc Lee Jones
2021-01-08 20:14 ` [PATCH 02/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' Lee Jones
2021-01-08 20:14 ` [PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd' Lee Jones
2021-01-08 20:14 ` [PATCH 04/40] drm/amd/amdgpu/amdgpu_ih: Update 'amdgpu_ih_decode_iv_helper()'s function header Lee Jones
2021-01-08 20:30 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 05/40] drm/amd/amdgpu/vega20_ih: Add missing descriptions for 'ih' and fix spelling error Lee Jones
2021-01-08 20:31 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 06/40] drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0: Provide description of 'call_back_func' Lee Jones
2021-01-08 20:32 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 07/40] drm/amd/pm/powerplay/hwmgr/ppatomctrl: Fix documentation for 'mpll_param' Lee Jones
2021-01-08 20:33 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 08/40] drm/amd/pm/powerplay/hwmgr/vega12_hwmgr: Fix legacy function header formatting Lee Jones
2021-01-08 20:34 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 09/40] drm/amd/pm/powerplay/hwmgr/vega20_hwmgr: " Lee Jones
2021-01-08 20:34 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 10/40] drm/amd/pm/powerplay/hwmgr/smu7_hwmgr: Fix formatting and spelling issues Lee Jones
2021-01-08 20:35 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 11/40] drm/amd/pm/powerplay/hwmgr/hwmgr: Move prototype into shared header Lee Jones
2021-01-08 20:36 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 12/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix a bunch of kernel-doc formatting issues Lee Jones
2021-01-08 20:37 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 13/40] drm/amd/display/dc/basics/conversion: Demote obvious kernel-doc abuse Lee Jones
2021-01-08 20:38 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 14/40] drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs: Demote non-kernel-doc comment blocks Lee Jones
2021-01-08 20:39 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 15/40] drm/amd/display/dc/bios/command_table_helper: Fix kernel-doc formatting Lee Jones
2021-01-08 20:39 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 16/40] drm/amd/display/dc/bios/command_table_helper2: Fix legacy formatting problems Lee Jones
2021-01-08 20:40 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 17/40] drm/amd/display/dc/bios/bios_parser: Make local functions static Lee Jones
2021-01-08 20:40 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 18/40] drm/amd/display/dc/bios/bios_parser: Fix a whole bunch of legacy doc formatting Lee Jones
2021-01-08 20:41 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 19/40] drm/amd/display/dc/bios/command_table: Remove unused variable Lee Jones
2021-01-08 21:00 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 20/40] include: drm: drm_atomic: Make use of 'new_plane_state' Lee Jones
2021-01-08 20:14 ` [PATCH 21/40] drm/amd/display/dc/calcs/dce_calcs: Remove unused variables 'v_filter_init_mode' and 'sclk_lvl' Lee Jones
2021-01-08 21:07 ` Alex Deucher
2021-01-14 16:50 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 22/40] drm/amd/display/dc/bios/bios_parser2: Fix some formatting issues and missing parameter docs Lee Jones
2021-01-08 21:08 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 23/40] drm/amd/display/dc/dce/dce_audio: Make function invoked by reference static Lee Jones
2021-01-08 21:08 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 24/40] drm/amd/display/dc/dce/dce_stream_encoder: Remove unused variable 'regval' Lee Jones
2021-01-08 21:12 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 25/40] drm/amd/display/dc/dce/dce_link_encoder: Make functions invoked by reference static Lee Jones
2021-01-08 21:13 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 26/40] drm/amd/display/dc/dce/dce_clock_source: Fix formatting/spelling of worthy function headers Lee Jones
2021-01-08 21:14 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 27/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix worthy function headers, demote barely documented one Lee Jones
2021-01-08 21:15 ` Alex Deucher [this message]
2021-01-08 20:14 ` [PATCH 28/40] drm/amd/display/dc/dce/dce_transform: Remove 3 unused/legacy variables Lee Jones
2021-01-08 21:17 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 29/40] drm/amd/display/dc/dce/dce_dmcu: Staticify local function call 'dce_dmcu_load_iram' Lee Jones
2021-01-08 21:17 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 30/40] drm/amd/display/dc/dce/dce_dmcu: Move 'abm_gain_stepsize' to only source file it's used in Lee Jones
2021-01-08 21:18 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 31/40] drm/amd/display/dc/dce/dce_opp: Make local functions and ones invoked by reference static Lee Jones
2021-01-08 21:19 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 32/40] drm/amd/display/dc/dce/dce_aux: Remove unused function 'get_engine_type' Lee Jones
2021-01-08 21:21 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 33/40] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers Lee Jones
2021-01-08 20:14 ` [PATCH 34/40] drm/amd/display/dc/bios/bios_parser: Fix misspelling of function parameter Lee Jones
2021-01-08 21:21 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 35/40] drm/amd/display/dc/bios/command_table: Remove unused variable and associated comment Lee Jones
2021-01-08 21:22 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 36/40] drm/amd/display/dc/dce/dce_i2c_hw: Make functions called by reference static Lee Jones
2021-01-08 21:23 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 37/40] drm/amd/display/dc/dce/dce_i2c_sw: Make a bunch of local functions static Lee Jones
2021-01-08 21:24 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 38/40] drm/amd/display/dc/dce/dce_panel_cntl: Remove unused variables 'bl_pwm_cntl' and 'pwm_period_cntl' Lee Jones
2021-01-08 21:25 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 39/40] drm/amd/display/dc/dce/dmub_psr: Demote non-conformant kernel-doc headers Lee Jones
2021-01-08 21:26 ` Alex Deucher
2021-01-08 20:14 ` [PATCH 40/40] drm/amd/display/dc/gpio/hw_factory: Delete unused function 'dal_hw_factory_destroy' Lee Jones
2021-01-08 21:27 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_P=6PbbOLYE6PiXP1_J9weqZgrKRwGU3Q7ZsRnx7BX2eA@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=evan.quan@amd.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).