From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,TVD_SPACE_RATIO,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE973C433E0 for ; Tue, 12 Jan 2021 22:04:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75002223E0 for ; Tue, 12 Jan 2021 22:04:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394150AbhALWEe (ORCPT ); Tue, 12 Jan 2021 17:04:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393964AbhALWEM (ORCPT ); Tue, 12 Jan 2021 17:04:12 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D909BC061575 for ; Tue, 12 Jan 2021 14:03:31 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id x13so4020502oic.5 for ; Tue, 12 Jan 2021 14:03:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/H028Wwjfvv9ucACM/DZ/rVBlomdfpbrk8WUZizz2Vs=; b=aHzNGV51B70g68q+osW4guQZlA2SPBmfpEfOkq7fZkXQoakwzlr6xu6YhmCMjJnjkM VtqaetZFw7ntjVk3o8watdpn0CN9ObBziXNCLskyRTcv3ylwFfov+alT8XTKxCsbdm7k 30NfnkHx0zYv8zD2AIpj0jLPRkt4W9Wor2BAIbgaPWwRMWHsh4xit369viFPJ9GYuRcM 0cd5LBcwNAYsQt5AFcp4xqa87LhvbXLukxjkG3nXDUAGYQicqCUo/J9aZy4KsUrH5g8x WlGyqSIaUV9liOnpvvUzHrW3WtEDSor/Re56fdaUbgg0fRWxgsHhqBfaW0j5NB9ivZ19 6uqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/H028Wwjfvv9ucACM/DZ/rVBlomdfpbrk8WUZizz2Vs=; b=cYsaWycAtEsLRPpKfQ0dqGeEBtfnx3c93t3OhyIQ2bzFTU2sG0v9VAQGQAWRH77HkI YUbQVcA4CwpTSI9RE6PwKoI5kdtn6sUdE/TzOyoU7/VOk5EJuALKeJqmNexEU50x5rdd FG1xs7TUeCkWgMsMBFO2NktuiMo0EkYOT5DxIhQeUQilJJQQByUWdAsQpJHi6Ylpi1HW uewbO8EZm+4Wa+HqyI4EPlvfUWQz9xUPOU/UmbTpxWs5EowkV858LewsC32XicoWoRN6 F68upmZO+xUbRPdWCIzGA6pQdnuSEEsWrfIT74Nd8ZoXno9AEh7D5yNDKLctEnIaWw0q qqiA== X-Gm-Message-State: AOAM531E3VJ8n+0u677QQnsVsyiY48MGC2ZgWvFyqwUtCjNhkDFzqjoP yV6aqI0xPY7yJIHXGSY9RikbVtkn5h9vP4Rscfs= X-Google-Smtp-Source: ABdhPJwKnqQekjYfdmWGfwn2owS4YfLiNSbIsA3whxDogbBuG2uZywR7fQBh87ZLY3GC3QoavsICftjeeyBcrFoVQo0= X-Received: by 2002:aca:4f97:: with SMTP id d145mr760461oib.123.1610489011339; Tue, 12 Jan 2021 14:03:31 -0800 (PST) MIME-Version: 1.0 References: <20210111191926.3688443-1-lee.jones@linaro.org> <20210111191926.3688443-9-lee.jones@linaro.org> In-Reply-To: <20210111191926.3688443-9-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 12 Jan 2021 17:03:20 -0500 Message-ID: Subject: Re: [PATCH 08/40] drm/amd/display/dc/gpio/diagnostics/hw_factory_diag: Fix struct declared inside parameter list error To: Lee Jones Cc: Leo Li , LKML , amd-gfx list , David Airlie , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 2:19 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia= g.h:30:43: warning: =E2=80=98struct hw_factory=E2=80=99 declared inside par= ameter list will not be visible outside of this definition or declaration > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia= g.h:30:6: note: previous declaration of =E2=80=98dal_hw_factory_diag_fpga_i= nit=E2=80=99 was here > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia= g.h:30:43: warning: =E2=80=98struct hw_factory=E2=80=99 declared inside par= ameter list will not be visible outside of this definition or declaration > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia= g.h:30:6: note: previous declaration of =E2=80=98dal_hw_factory_diag_fpga_i= nit=E2=80=99 was here > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia= g.h:30:43: warning: =E2=80=98struct hw_factory=E2=80=99 declared inside par= ameter list will not be visible outside of this definition or declaration > drivers/gpu/drm/amd/amdgpu/../display/dc/gpio/diagnostics/hw_factory_dia= g.h:30:6: note: previous declaration of =E2=80=98dal_hw_factory_diag_fpga_i= nit=E2=80=99 was here > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > .../gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_d= iag.h b/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h > index 8a74f6adb8eee..bf68eb1d9a1d2 100644 > --- a/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h > +++ b/drivers/gpu/drm/amd/display/dc/gpio/diagnostics/hw_factory_diag.h > @@ -26,6 +26,8 @@ > #ifndef __DAL_HW_FACTORY_DIAG_FPGA_H__ > #define __DAL_HW_FACTORY_DIAG_FPGA_H__ > > +struct hw_factory; > + > /* Initialize HW factory function pointers and pin info */ > void dal_hw_factory_diag_fpga_init(struct hw_factory *factory); > > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel