From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC244C4338F for ; Mon, 23 Aug 2021 20:32:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9413861357 for ; Mon, 23 Aug 2021 20:32:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232582AbhHWUcs (ORCPT ); Mon, 23 Aug 2021 16:32:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232706AbhHWUcm (ORCPT ); Mon, 23 Aug 2021 16:32:42 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9EE6C061796 for ; Mon, 23 Aug 2021 13:31:53 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id o16-20020a9d2210000000b0051b1e56c98fso24940304ota.8 for ; Mon, 23 Aug 2021 13:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YztTrgwvM/nmj6MMrgNrjzMlI5AYchZazMGR/sdkBds=; b=BMyImnscdvSRsb5ejTiZG2NMR0fN+ONhbsHfOHRSF7zffkLBfyD+T0p/hJNUaZdKx5 ng4yZWA1PQ5RB/dZpK9LiuqpEXBeYc6FbISJ4DF0K2k7IW31SF4jzyyBQ7Zro1Q/tXjH tzofHxJ0N1fIngWsfH/upkJagIVkqHnG65nBAg9oi11ytHZCZMWK5HMdbgBE7UYD9l7L dDSJLfQV0ZbZZ2tVWfT0vB8lZhaFj1k0mlJ34zQKSwfEr1ynk9CYS9Pf6s96jiWEIne/ AglcdATRxi0rc+jbTrPfRTLMHgJinUqGKTyAz5aVtAEbvZmqjzwYPg59aMFP9KO3kSLz /5yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YztTrgwvM/nmj6MMrgNrjzMlI5AYchZazMGR/sdkBds=; b=Z7qgHHAbiC/4/F+tY6O833m5Uy0JHQMVTEowDZJC5LBEKK6PTWvdhbfU1GRHpoKkxC Y2SPzdtdGJ/gCQFEF5C8KVXq7hqa1Aqlh/06GsVSiLSFjKc1vaGUT/267cT8sQhv8ym2 ZbUkF8Rc/ebBt4wEAuizYRShDArCzv2cP5JnlUcltUZ+NqIlGMDEAJ1hmMhnCoq69D15 isQvM0yJgLuXPW1NKtTrlKcrNGFZuH2EiIAq5A72PKps3T+g5OSI5oC3GQ0jz6BEHsnb 1lcJItMzvcz859W6k3cmFgKAxotcKDL+nFNb1D6GZlfXxN4K9NFdi1b0S/uFeSg55wgT tF+A== X-Gm-Message-State: AOAM532rjSBH7hheX08f6FIqtVqqqDtAu6vzPlGw5rHr9F1z67SDz2L4 TO3MDDqtCzyD/x36GBELdSy2vBOjjZcY9KbYllnEKlXP X-Google-Smtp-Source: ABdhPJxwVaCFmOhToGFrcJFOSAqw2KkSEEg6DfejiKYf8Ch06ZIbpv3b7VSinrTGBbVS5Deb+BYQ4MLKp5xAcj8k14E= X-Received: by 2002:a05:6830:4:: with SMTP id c4mr29208288otp.23.1629750713165; Mon, 23 Aug 2021 13:31:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Mon, 23 Aug 2021 16:31:42 -0400 Message-ID: Subject: Re: ERROR: modpost: "pm_suspend_target_state" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! To: Borislav Petkov Cc: Alex Deucher , Lijo Lazar , Pratik Vishwakarma , amd-gfx list , lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2021 at 4:27 PM Borislav Petkov wrote: > > On Mon, Aug 23, 2021 at 03:49:39PM -0400, Alex Deucher wrote: > > Maybe fixed with this patch? > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5706cb3c910cc8283f344bc37a889a8d523a2c6d > > Nope, this one is already in: > > $ git tag --contains 5706cb3c910cc8283f344bc37a889a8d523a2c6d > v5.14-rc5 > v5.14-rc6 > v5.14-rc7 > > also, from only a quick poke so IMHO, the error says: > > ERROR: modpost: "pm_suspend_target_state" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > > which means you need the > > EXPORT_SYMBOL_GPL(pm_suspend_target_state); > > which is in kernel/power/suspend.c which gets enabled with > > obj-$(CONFIG_SUSPEND) += suspend.o > > and if you look at PM_SLEEP: > > config PM_SLEEP > def_bool y > depends on SUSPEND || HIBERNATE_CALLBACKS > > (notice the ||) > > and my randconfig has: > > $ grep -E "(HIBERNATE_CALLBACKS|SUSPEND)" .config > # CONFIG_SUSPEND is not set > CONFIG_HIBERNATE_CALLBACKS=y > > which means, you need: > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c > index 4137e848f6a2..a9ce3b20d371 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c > @@ -1040,7 +1040,7 @@ void amdgpu_acpi_detect(void) > */ > bool amdgpu_acpi_is_s0ix_supported(struct amdgpu_device *adev) > { > -#if IS_ENABLED(CONFIG_AMD_PMC) && IS_ENABLED(CONFIG_PM_SLEEP) > +#if IS_ENABLED(CONFIG_AMD_PMC) && IS_ENABLED(CONFIG_SUSPEND) > if (acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0) { > if (adev->flags & AMD_IS_APU) > return pm_suspend_target_state == PM_SUSPEND_TO_IDLE; > > > but whether that gives you what you want for amdgpu, you probably need > to ponder on a bit. > > I sincerely hope that helps a little. Thanks. I think that should do the trick. Care to send that as a formal patch? Alex