From: Alex Deucher <alexdeucher@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Oded Gabbay <oded.gabbay@gmail.com>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
Chunming Zhou <David1.Zhou@amd.com>,
Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdkfd: remove set but not used variable 'pdd'
Date: Wed, 21 Aug 2019 22:43:31 -0400 [thread overview]
Message-ID: <CADnq5_PcbKZDsqmoL2wK061sL=KfCedmEafn_hpbFZ9tNGrNdA@mail.gmail.com> (raw)
In-Reply-To: <20190726140054.31388-1-yuehaibing@huawei.com>
Applied. thanks!
Alex
On Fri, Jul 26, 2019 at 11:58 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c: In function restore_process_worker:
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_process.c:949:29: warning:
> variable pdd set but not used [-Wunused-but-set-variable]
>
> It is not used since
> commit 5b87245faf57 ("drm/amdkfd: Simplify kfd2kgd interface")
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_process.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index 8f1076c..240bf68 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -1042,7 +1042,6 @@ static void restore_process_worker(struct work_struct *work)
> {
> struct delayed_work *dwork;
> struct kfd_process *p;
> - struct kfd_process_device *pdd;
> int ret = 0;
>
> dwork = to_delayed_work(work);
> @@ -1051,16 +1050,6 @@ static void restore_process_worker(struct work_struct *work)
> * lifetime of this thread, kfd_process p will be valid
> */
> p = container_of(dwork, struct kfd_process, restore_work);
> -
> - /* Call restore_process_bos on the first KGD device. This function
> - * takes care of restoring the whole process including other devices.
> - * Restore can fail if enough memory is not available. If so,
> - * reschedule again.
> - */
> - pdd = list_first_entry(&p->per_device_data,
> - struct kfd_process_device,
> - per_device_list);
> -
> pr_debug("Started restoring pasid %d\n", p->pasid);
>
> /* Setting last_restore_timestamp before successful restoration.
> --
> 2.7.4
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2019-08-22 2:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 14:00 [PATCH] drm/amdkfd: remove set but not used variable 'pdd' YueHaibing
2019-08-22 2:43 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_PcbKZDsqmoL2wK061sL=KfCedmEafn_hpbFZ9tNGrNdA@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oded.gabbay@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).