From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 210A4C433F5 for ; Thu, 17 Feb 2022 16:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243314AbiBQQcD (ORCPT ); Thu, 17 Feb 2022 11:32:03 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239801AbiBQQb5 (ORCPT ); Thu, 17 Feb 2022 11:31:57 -0500 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CBCA1A3AD for ; Thu, 17 Feb 2022 08:31:42 -0800 (PST) Received: by mail-oi1-x232.google.com with SMTP id p15so181264oip.3 for ; Thu, 17 Feb 2022 08:31:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bElm5YilB/9jblKEU64fD/ESvy8c+wLEV4cgX1XhWn4=; b=Eq1tUKgqg59a4QA5ulUqAVWGJmM7UV+1lWzQXL+zegdCS5/d4qsDlC5deH1OCwWstU +C+uqqiZW2o3xKjbO23EnJl0d5uDvEe0lBrIH9PC5UwZ/u7Ts/hHBW7kzkx3yt4hxJ2M rw3a0q7ng+L5mm+KXKUAhVfwJoa1z3hmwUV7t8JtlBRa9fIOEL68OVNeV4kmYlgnkITW EO5lyysg+u3N2lBo8T8NUN78/kNWlDRnW35krNMGCsbBxLBuhxTgjQcvYJZ0rVp2HesJ QStSRNSpghG4F6RXqxSrxcLIbzpF0KewldPbmspmkxAT1On4cwLlW2PHhXBBIHEFLBVn 5PNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bElm5YilB/9jblKEU64fD/ESvy8c+wLEV4cgX1XhWn4=; b=E2gs3v1A8/8qfoFObOYve2h4kUz8fXNl23L/JbZsrbgvp20s4l7B/nLWCN/aFdtY3M Ge8AEzjUVh/5jm+YAxhqg//U0MmXjPgapZIuDoZXU0oieFlxE7BpVQcdEufy9eQxlbfR hN/zAg7tgY3fqQoevXLYldvtelSi1jX4plWVe7YV1SZjRCe+MuXFN1NPpOke1J/r92pP lN8k4JvvWb0KT3TO+vPw3ZPR4wkXA1xG5pvaTMqxrWhEOp0Kz+zlF354EGDRoG+7ztua rSXJJh1nNZLNHgwVgDqja5VCBDMRho5OCg4cHBOEyhA4RWSrNPllAEEMYd/hf7duJwc4 PC5A== X-Gm-Message-State: AOAM531DufcP8gVzXfsdIh9tfET2N7gMWnLtVfQjPQNks60YOcsRbIwI d9xsUntirHAFIfamQBuNlrtyt4Zd9BgFX6x33ESPMwek X-Google-Smtp-Source: ABdhPJx6a+RRNxIK4nxCa4AWmBuTIaxNxYd6UitmMWxs/iXH4phTUwHGWoWwQkdU27X2KXRi4tD18lfFTVADnZA347A= X-Received: by 2002:a05:6808:f8b:b0:2ce:6ee7:2c99 with SMTP id o11-20020a0568080f8b00b002ce6ee72c99mr3205163oiw.199.1645115501464; Thu, 17 Feb 2022 08:31:41 -0800 (PST) MIME-Version: 1.0 References: <20220217162142.1828990-1-nathan@kernel.org> In-Reply-To: <20220217162142.1828990-1-nathan@kernel.org> From: Alex Deucher Date: Thu, 17 Feb 2022 11:31:30 -0500 Message-ID: Subject: Re: [PATCH] drm/amdkfd: Use proper enum in pm_unmap_queues_v9() To: Nathan Chancellor Cc: Felix Kuehling , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Jonathan Kim , llvm@lists.linux.dev, Nick Desaulniers , LKML , Maling list - DRI developers , amd-gfx list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 17, 2022 at 11:22 AM Nathan Chancellor wrote: > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_packet_manager_v9.c:267:3: > error: implicit conversion from enumeration type 'enum > mes_map_queues_extended_engine_sel_enum' to different enumeration type > 'enum mes_unmap_queues_extended_engine_sel_enum' > [-Werror,-Wenum-conversion] > extended_engine_sel__mes_map_queues__sdma0_to_7_sel : > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > Use 'extended_engine_sel__mes_unmap_queues__sdma0_to_7_sel' to eliminate > the warning, which is the same numeric value of the proper type. > > Fixes: 009e9a158505 ("drm/amdkfd: navi2x requires extended engines to map and unmap sdma queues") > Link: https://github.com/ClangBuiltLinux/linux/issues/1596 > Signed-off-by: Nathan Chancellor Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c > index 806a03566a24..18250845a989 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c > @@ -264,7 +264,7 @@ static int pm_unmap_queues_v9(struct packet_manager *pm, uint32_t *buffer, > sizeof(struct pm4_mes_unmap_queues)); > > packet->bitfields2.extended_engine_sel = pm_use_ext_eng(pm->dqm->dev) ? > - extended_engine_sel__mes_map_queues__sdma0_to_7_sel : > + extended_engine_sel__mes_unmap_queues__sdma0_to_7_sel : > extended_engine_sel__mes_unmap_queues__legacy_engine_sel; > > packet->bitfields2.engine_sel = > > base-commit: 3c30cf91b5ecc7272b3d2942ae0505dd8320b81c > -- > 2.35.1 >