linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leonardo Bras <leobras.c@gmail.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	lkcamp@lists.libreplanetbr.org,
	Matthew Wilcox <willy6545@gmail.com>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Michal Marek <michal.lkml@markovi.net>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 1/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS
Date: Wed, 17 Oct 2018 21:40:53 -0300	[thread overview]
Message-ID: <CADvQ+rFa=XEuxLb=yPmtJE2QepBNjCVzjEY5urVzCaSF1tJBYw@mail.gmail.com> (raw)
In-Reply-To: <20181017083126.GB22535@zn.tnic>

Hello Boris,


> Next question: why not -Wshadow simply?

Good question. I can change it to -Wshadow and fix stuff for v2.

>
> Also, -Wshadow for the target compiler is an extra warning (W=2). Why is
> it enabled by default here?

The idea was to put it as default and fix all the shadowing warnings.
What do you think?  I am open to suggestions.

Thank you,
Leonardo Bras


> --
> Regards/Gruss,
>     Boris.
>
> Good mailing practices for 400: avoid top-posting and trim the reply.

  reply	other threads:[~2018-10-18  0:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-17  0:08 [PATCH 1/4] Adds -Wshadow=local on KBUILD_HOSTCFLAGS Leonardo Brás
2018-10-17  4:32 ` [Lkcamp] " Helen Koike
2018-10-17 23:18   ` Leonardo Bras
2018-10-17  8:11 ` Borislav Petkov
2018-10-17  8:21   ` Masahiro Yamada
2018-10-17  8:31     ` Borislav Petkov
2018-10-18  0:40       ` Leonardo Bras [this message]
2018-10-18  9:16         ` Borislav Petkov
2018-10-18 16:39           ` Masahiro Yamada
2018-10-18 16:50             ` Borislav Petkov
2018-10-19  2:41               ` Masahiro Yamada
2018-10-19  2:50                 ` Leonardo Bras
2018-10-19  8:08                 ` Borislav Petkov
2018-10-19 11:28             ` David Laight
2018-10-28 16:54               ` Masahiro Yamada
2018-10-18  0:36     ` Leonardo Bras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADvQ+rFa=XEuxLb=yPmtJE2QepBNjCVzjEY5urVzCaSF1tJBYw@mail.gmail.com' \
    --to=leobras.c@gmail.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkcamp@lists.libreplanetbr.org \
    --cc=luto@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=willy6545@gmail.com \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).