From: James Hilliard <james.hilliard1@gmail.com>
To: Lars Melin <larsm17@gmail.com>
Cc: Oliver Neukum <oneukum@suse.de>,
linux-usb@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Russ Dill <Russ.Dill@gmail.com>,
Hector Martin <hector@marcansoft.com>
Subject: Re: [PATCH v2] usb: serial: Repair FTDI FT232R bricked eeprom
Date: Thu, 10 Sep 2020 00:48:07 -0600 [thread overview]
Message-ID: <CADvTj4q+b6nLBV6LEdd6K-daNbhTf6rUMOYnj+p0FO6+NTCg7A@mail.gmail.com> (raw)
In-Reply-To: <a1161f77-5b37-39ea-eb91-7b0b59278960@gmail.com>
On Wed, Sep 9, 2020 at 11:34 PM Lars Melin <larsm17@gmail.com> wrote:
>
> On 9/10/2020 10:02, Oliver Neukum wrote:
> > Am Mittwoch, den 09.09.2020, 13:34 -0600 schrieb James Hilliard:
> >> This patch detects and reverses the effects of the malicious FTDI
> >> Windows driver version 2.12.00(FTDIgate).
> >
> > Hi,
> >
> > this raises questions.
> > Should we do this unconditionally without asking?
> > Does this belong into kernel space?
> >
>
> My answer to both of those question is a strong NO.
>
> The patch author tries to justify the patch with egoistical arguments
> (easier for him and his customers) without thinking of all other users
> of memory constrained embedded hardware that doesn't need the patch code
> but have to carry it.
If that's a concern it would not be difficult to add a kconfig option to allow
disabling it.
>
> The bricked PID is btw already supported by the linux ftdi driver so
> there is no functionality gain in the patch.
By the kernel driver sure, but userspace is where things get messed up
without something like this.
>
> br
> Lars
>
>
>
next prev parent reply other threads:[~2020-09-10 6:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 19:34 [PATCH v2] usb: serial: Repair FTDI FT232R bricked eeprom James Hilliard
2020-09-10 3:02 ` Oliver Neukum
2020-09-10 3:17 ` Hector Martin "marcan"
2020-09-10 3:46 ` James Hilliard
2020-09-10 3:49 ` Hector Martin "marcan"
2020-09-10 4:39 ` James Hilliard
2020-09-10 3:40 ` James Hilliard
2020-09-10 3:46 ` Hector Martin "marcan"
2020-09-10 4:07 ` James Hilliard
2020-09-10 5:33 ` Lars Melin
2020-09-10 6:48 ` James Hilliard [this message]
2020-09-10 8:01 ` James Hilliard
2020-09-10 8:08 ` Johan Hovold
2020-09-10 8:17 ` James Hilliard
2020-09-10 8:55 ` Greg Kroah-Hartman
2020-09-10 9:52 ` James Hilliard
2020-09-10 9:57 ` Hector Martin
2020-09-10 18:51 ` James Hilliard
2020-09-10 19:54 ` Hector Martin
2020-09-11 6:09 ` Greg Kroah-Hartman
2020-09-10 5:49 ` Greg Kroah-Hartman
2020-09-10 6:45 ` James Hilliard
2020-09-10 8:10 ` Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADvTj4q+b6nLBV6LEdd6K-daNbhTf6rUMOYnj+p0FO6+NTCg7A@mail.gmail.com \
--to=james.hilliard1@gmail.com \
--cc=Russ.Dill@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hector@marcansoft.com \
--cc=johan@kernel.org \
--cc=larsm17@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).