From: Menglong Dong <menglong8.dong@gmail.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Kees Cook <keescook@chromium.org>,
Sami Tolvanen <samitolvanen@google.com>,
johan@kernel.org, ojeda@kernel.org, jeyu@kernel.org,
masahiroy@kernel.org, joe@perches.com, Jan Kara <jack@suse.cz>,
hare@suse.de, Jens Axboe <axboe@kernel.dk>,
tj@kernel.org, gregkh@linuxfoundation.org, song@kernel.org,
NeilBrown <neilb@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Barret Rhoden <brho@google.com>,
f.fainelli@gmail.com, palmerdabbelt@google.com,
wangkefeng.wang@huawei.com,
Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
vbabka@suse.cz, Alexander Potapenko <glider@google.com>,
Petr Mladek <pmladek@suse.com>,
johannes.berg@intel.com,
"Eric W. Biederman" <ebiederm@xmission.com>,
jojing64@gmail.com, terrelln@fb.com, geert@linux-m68k.org,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
arnd@arndb.de, Chris Down <chris@chrisdown.name>,
mingo@kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH v6 2/2] init/do_mounts.c: create second mount for initramfs
Date: Fri, 17 Sep 2021 09:58:04 +0800 [thread overview]
Message-ID: <CADxym3YxBAJmXr1qmJ+3ELrT6RKY-UoFmpaPH5iYmbEa1H+03Q@mail.gmail.com> (raw)
In-Reply-To: <20210727123701.zlcrrf4p2fsmeeas@wittgenstein>
Hello,
On Tue, Jul 27, 2021 at 8:37 PM Christian Brauner
<christian.brauner@ubuntu.com> wrote:
[...]
>
> Yep, sorry.
> When I tested this early during the merge window it regressed booting a
> regular system for me meaning if I compiled a kernel with this feature
> enabled it complained about not being being able to open an initial
> console and it dropped me right into initramfs instead of successfully
> booting. I haven't looked into what this is caused or how to fix it for
> lack of time.
Our team has fully tested this feature, and no abnormalities have been
found yet.
What's more, this feature has been used in the product of our company. So if
there is any potential bug, as you mentioned above, I'd appreciate it if you can
spend some time on looking into it.
What's more, besides the problem that this feature solved, it has some more
benefits: saving memory. The amount of 'mnt_cache' is up to 50k when 180 docker
containers are created without this feature. However, only 15k 'mnt_cache' are
used with this feature enabled. Each 'mnt_cache' eats 320 bytes, so about 11M
memory is saved in this situation.
Please let me know if this feature is illogical or if there is any
better solution, thanks~
Best Wishes!
Menglong Dong
next prev parent reply other threads:[~2021-09-17 1:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 3:44 [PATCH v6 0/2] init/initramfs.c: make initramfs support pivot_root menglong8.dong
2021-06-05 3:44 ` [PATCH v6 1/2] init/main.c: introduce function ramdisk_exec_exist() menglong8.dong
2021-06-05 3:44 ` [PATCH v6 2/2] init/do_mounts.c: create second mount for initramfs menglong8.dong
2021-06-05 11:50 ` Christian Brauner
2021-06-05 14:47 ` Menglong Dong
2021-06-07 10:31 ` Christian Brauner
2021-06-07 12:15 ` menglong8.dong
2021-06-17 3:57 ` Menglong Dong
2021-06-17 14:38 ` Christian Brauner
2021-07-27 12:24 ` Menglong Dong
2021-07-27 12:37 ` Christian Brauner
2021-07-28 8:07 ` Petr Mladek
2021-07-29 13:25 ` Menglong Dong
2021-09-17 1:58 ` Menglong Dong [this message]
2021-06-09 14:03 ` [PATCH v6 0/2] init/initramfs.c: make initramfs support pivot_root Masami Hiramatsu
2021-06-10 6:36 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADxym3YxBAJmXr1qmJ+3ELrT6RKY-UoFmpaPH5iYmbEa1H+03Q@mail.gmail.com \
--to=menglong8.dong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=brho@google.com \
--cc=chris@chrisdown.name \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=johan@kernel.org \
--cc=johannes.berg@intel.com \
--cc=jojing64@gmail.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=neilb@suse.de \
--cc=ojeda@kernel.org \
--cc=palmerdabbelt@google.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=song@kernel.org \
--cc=terrelln@fb.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).