From: Menglong Dong <menglong8.dong@gmail.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Kees Cook <keescook@chromium.org>,
Sami Tolvanen <samitolvanen@google.com>,
johan@kernel.org, ojeda@kernel.org, jeyu@kernel.org,
joe@perches.com, Menglong Dong <dong.menglong@zte.com.cn>,
masahiroy@kernel.org, Jan Kara <jack@suse.cz>,
Jens Axboe <axboe@kernel.dk>,
hare@suse.de, gregkh@linuxfoundation.org, tj@kernel.org,
song@kernel.org, NeilBrown <neilb@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Barret Rhoden <brho@google.com>,
f.fainelli@gmail.com, wangkefeng.wang@huawei.com, arnd@arndb.de,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
mhiramat@kernel.org, Steven Rostedt <rostedt@goodmis.org>,
vbabka@suse.cz, Alexander Potapenko <glider@google.com>,
pmladek@suse.com, ebiederm@xmission.com, jojing64@gmail.com,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] init/main.c: introduce function ramdisk_exec_exist()
Date: Tue, 25 May 2021 11:43:31 +0800 [thread overview]
Message-ID: <CADxym3asj97wATjGthOyMzosg=dHY-bfk5pqLPYLSCa2Sub73Q@mail.gmail.com> (raw)
In-Reply-To: <YKxMjPOrHfb1uaA+@localhost>
On Tue, May 25, 2021 at 9:02 AM Josh Triplett <josh@joshtriplett.org> wrote:
>
......
>
> As far as I can tell, this will break if the user wants to use
> ".mybinary" or ".mydir/mybinary" as the name of their init program.
>
> For that matter, it would break "...prog" or "...somedir/prog", which
> would be strange but not something the kernel should prevent.
>
Wow, seems I didn't give enough thought to it.
> I don't think this code should be attempting to recreate
> relative-to-absolute filename resolution.
Trust me, I don't want to do it either. However, I need to check if
ramdisk_execute_command exist before chroot while the cpio is unpacked
to '/root'.
Maybe I can check it after chroot, but I need to chroot back if it not
exist. Can I chroot back in a nice way?
I tried to move the mount on '/root' to '/' before I do this check in
absolute path, but seems '/' is special, the lookup of '/init' never
follow the mount on '/' and it can't be found. However, if I lookup
'/../init', it can be found!
Is there any one have a good idea? Or I have to dig into the code
of 'kern_path()' and figure out the reason.
Thanks!
Menglong Dong
next prev parent reply other threads:[~2021-05-25 3:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 11:31 [PATCH 0/3] init/initramfs.c: make initramfs support pivot_root menglong8.dong
2021-05-22 11:31 ` [PATCH 1/3] init/main.c: introduce function ramdisk_exec_exist() menglong8.dong
2021-05-25 1:02 ` Josh Triplett
2021-05-25 3:43 ` Menglong Dong [this message]
2021-05-25 8:04 ` Menglong Dong
2021-05-22 11:31 ` [PATCH 2/3] init/do_cmounts.c: introduce 'user_root' for initramfs menglong8.dong
2021-05-25 0:44 ` Luis Chamberlain
2021-05-25 3:28 ` Menglong Dong
2021-05-22 11:31 ` [PATCH 3/3] init/do_mounts.c: fix rootfs_fs_type with ramfs menglong8.dong
2021-05-24 21:47 ` Luis Chamberlain
2021-05-25 0:52 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADxym3asj97wATjGthOyMzosg=dHY-bfk5pqLPYLSCa2Sub73Q@mail.gmail.com' \
--to=menglong8.dong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=brho@google.com \
--cc=dong.menglong@zte.com.cn \
--cc=ebiederm@xmission.com \
--cc=f.fainelli@gmail.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=johan@kernel.org \
--cc=jojing64@gmail.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=neilb@suse.de \
--cc=ojeda@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=song@kernel.org \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).