From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78706C04AA5 for ; Thu, 25 Aug 2022 02:29:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232285AbiHYC3k (ORCPT ); Wed, 24 Aug 2022 22:29:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233228AbiHYC3h (ORCPT ); Wed, 24 Aug 2022 22:29:37 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ADB8923CC; Wed, 24 Aug 2022 19:29:37 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id f4so14818503pgc.12; Wed, 24 Aug 2022 19:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=WBu8LmrRIK+SDkVgV6rJt4O1S6Q3tUu803Yb2Y/vIow=; b=a0FyiuDPR7RV5jJ9oRUOpgFn1LmdXdCeo0MVMd+Oh6mv8pV0QmkkFNjOCEQXwVgWQ3 vvFRAyTxKm/MeBKl3h7oMlkZgtAjqAtwLCn/SguIxamHqHzl8HJ0Ncmps6RZzttUUicm q9eGpJiZDNkuwpUQY0fZ2NnOU8bPM2YTszpf3Gjwero7TBf/sN9jQi806jzl8Y3QnVUT 17cKHqlWU3FajGbk4nq4sq1ABlxNv7u8AFUv6JLyK8K+iHLiS5Uk4ShttSBeHpHQnd58 cHotG1udn/Q/1Su5bJOFzBgToOUzdjckTra/ApNZgeQTceIbCc3smxJjeM4SiYSr8cg9 MyzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=WBu8LmrRIK+SDkVgV6rJt4O1S6Q3tUu803Yb2Y/vIow=; b=VP17OATRdQoQWFDoEygk8QT9+vQqeze9GcZfLCeUPxQb21BSuIQ+CdnflGrkjVB/on 0Lmx9PqfLuZ0XUQbKTmKNdD/Tkl9aEG+f3O/GfpV3MtFzsfKt1jwuyxlhWcuMP5YXJjd iKiTsfhQOx8b4qDjMnl34vwKQ6AOOD+xwIYY+yTo309eDeZ+EfocpuoYe28Tqm6uVNVf I9BQYmBEONq3/vZku43DGgSBz3gzq/zQfF5FQgzYmU923+GGSipZ+h7NIA6Z9DWJzk4r IZmaxcij1fuDaeJU7SiHDh7CaDJec1o87KYsS7JTLOw46bAr6gdT7MobOCzaNfljOkQd kRig== X-Gm-Message-State: ACgBeo0TGT8Te8axPTTEfB0lvD+2DcPU4J+p0yB/49Uk69tD0NP4L1H2 ilE9e/J67iW4Z7KlsY01mZzEvQhBze/9BDZoaDk= X-Google-Smtp-Source: AA6agR4YLgnYTXuG0xNeI1QEYwv15AKD5FH1WMvHRYSMEzxLBwlSug14r2fpyI94iip/mFs/hevvNr+qgHSxAYu69ds= X-Received: by 2002:a05:6a00:a05:b0:534:b1ad:cfac with SMTP id p5-20020a056a000a0500b00534b1adcfacmr1938835pfh.35.1661394576605; Wed, 24 Aug 2022 19:29:36 -0700 (PDT) MIME-Version: 1.0 References: <20220606022436.331005-1-imagedong@tencent.com> <20220606022436.331005-3-imagedong@tencent.com> <20220824181040.57ec009e@kernel.org> In-Reply-To: <20220824181040.57ec009e@kernel.org> From: Menglong Dong Date: Thu, 25 Aug 2022 10:29:25 +0800 Message-ID: Subject: Re: [PATCH net-next v4 2/3] net: skb: use auto-generation to convert skb drop reason to string To: Jakub Kicinski , Eric Dumazet Cc: Steven Rostedt , Ingo Molnar , David Miller , Paolo Abeni , Neil Horman , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Menglong Dong , David Ahern , Talal Ahmad , Kees Cook , LKML , netdev , bpf Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 25, 2022 at 9:10 AM Jakub Kicinski wrote: > > On Wed, 24 Aug 2022 17:45:15 -0700 Eric Dumazet wrote: > > After this patch, I no longer have strings added after the reason: tag > > Hm, using a kernel address (drop_reasons) as an argument to TP_printk() > definitely does not look right, but how to tickle whatever magic > __print_symbolic was providing I do not know :S > > TP_printk("skbaddr=%p protocol=%u location=%p reason: %s", > __entry->skbaddr, __entry->protocol, __entry->location, > - __print_symbolic(__entry->reason, > - TRACE_SKB_DROP_REASON)) > + drop_reasons[__entry->reason]) it seems that TP_printk is not as simple as I thought....... Sorry for the problem I brought, I'm looking for a solution. Thanks! Menglong Dong