From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423396AbcFMNSO (ORCPT ); Mon, 13 Jun 2016 09:18:14 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:35227 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423115AbcFMNSM (ORCPT ); Mon, 13 Jun 2016 09:18:12 -0400 MIME-Version: 1.0 In-Reply-To: <20160613075928.511131190@linutronix.de> References: <20160613070440.950649741@linutronix.de> <20160613075928.511131190@linutronix.de> From: Arjan van de Ven Date: Mon, 13 Jun 2016 06:18:11 -0700 Message-ID: Subject: Re: [patch 04/20] cpufreq/powernv: Initialize timer as pinned To: Thomas Gleixner Cc: LKML , Ingo Molnar , Peter Zijlstra , "Paul E. McKenney" , Eric Dumazet , Frederic Weisbecker , Chris Mason , Arjan van de Ven , rt@linutronix.de Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2016 at 1:40 AM, Thomas Gleixner wrote: > mod_timer(&gpstates->timer, jiffies + msecs_to_jiffies(timer_interval)); are you sure this is right? the others did not get replaced by mod_timer().. (and this is more evidence that a relative API in msecs is what drivers really want)