From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758236AbcIMKVZ (ORCPT ); Tue, 13 Sep 2016 06:21:25 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:34236 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754837AbcIMKVY (ORCPT ); Tue, 13 Sep 2016 06:21:24 -0400 MIME-Version: 1.0 In-Reply-To: References: <1473168352-5156-1-git-send-email-fu.wei@linaro.org> <1473168352-5156-6-git-send-email-fu.wei@linaro.org> From: Fu Wei Date: Tue, 13 Sep 2016 18:21:22 +0800 Message-ID: Subject: Re: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code. To: Mark Rutland , Marc Zyngier Cc: "Rafael J. Wysocki" , Len Brown , Lorenzo Pieralisi , Sudeep Holla , Hanjun Guo , linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , Wei Huang , Arnd Bergmann , Wim Van Sebroeck , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , Leo Duran , Guenter Roeck , linux-watchdog@vger.kernel.org, Daniel Lezcano , Thomas Gleixner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8DALZa1022094 Hi Mark, Marc, Sorry for missing you in the cc list Do you have any suggestion for the arm_arch_timer patches? Could you help me to review these patches ? Great thanks ! On 13 September 2016 at 17:22, Fu Wei wrote: > Hi Thomas, Daniel, > > For these arm_arch_timer patches, do you have any other suggestion or comment? > I have deleted "skipping" in the error message. > > I have prepared v12 (rebase to rc6 and on the top of IORT v11), > should I send it now (if you are OK with my arm_arch_timer patches ), > or anything I can do to improve this patchset ? > > Thanks. > > On 7 September 2016 at 17:23, Fu Wei wrote: >> Hi Thomas >> >> On 6 September 2016 at 22:36, Thomas Gleixner wrote: >>> On Tue, 6 Sep 2016, fu.wei@linaro.org wrote: >>>> + if (timer_count < 0) >>>> + pr_err("Failed to get platform timer info, skipping.\n"); >>> >>> So this prints something about skipping. But then it continues as if >>> nothing went wrong. That's either wrong or confusing or both. >> >> yes, you are right, this info is confusing. >> maybe we just delete the "skipping" ? >> >> “timer_count < 0” is caused by some firmware bug, in gtdt.c: >> ---- >> int __init acpi_gtdt_init(struct acpi_table_header *table) >> { >> ...... >> if (start < (void *)table + sizeof(struct acpi_table_gtdt)) { >> pr_err(FW_BUG "Failed to retrieve timer info from firmware: >> invalid data.\n"); >> return -EINVAL; >> ...... >> } >> ---- >> >> But in this situation( without platform timers ), system still can work. >> So I thing we just need to print a error. >> >>> >>>> - arch_timer_init(); >>>> - return 0; >>>> + return arch_timer_init(); >>> >>> Thanks, >>> >>> tglx >> >> >> >> -- >> Best regards, >> >> Fu Wei >> Software Engineer >> Red Hat > > > > -- > Best regards, > > Fu Wei > Software Engineer > Red Hat -- Best regards, Fu Wei Software Engineer Red Hat