From: Stephen Boyd <swboyd@chromium.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
agross@kernel.org, andersson@kernel.org, broonie@kernel.org,
konrad.dybcio@somainline.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
quic_plai@quicinc.com, quic_rohkumar@quicinc.com,
robh+dt@kernel.org
Subject: Re: [PATCH v6 6/6] clk: qcom: lpassaudiocc-sc7280: Skip lpass_aon_cc_pll config
Date: Mon, 30 Jan 2023 17:06:25 -0800 [thread overview]
Message-ID: <CAE-0n504ZhYcm73e1kxg0OnOKbUUaU46SKE8JMpwCd-WKh3mTg@mail.gmail.com> (raw)
In-Reply-To: <1674728065-24955-7-git-send-email-quic_srivasam@quicinc.com>
Quoting Srinivasa Rao Mandadapu (2023-01-26 02:14:25)
> diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> index 8e2f433..1511337 100644
> --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c
> +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c
> @@ -847,7 +847,8 @@ static int lpass_aon_cc_sc7280_probe(struct platform_device *pdev)
> goto exit;
> }
>
> - clk_lucid_pll_configure(&lpass_aon_cc_pll, regmap, &lpass_aon_cc_pll_config);
> + if (!of_property_read_bool(pdev->dev.of_node, "qcom,adsp-pil-mode"))
Please add a comment like
/*
* ADSP firmware is in control of this PLL frequency when
* remoteproc is used. Skip frequency configuration in that
* case.
*/
> + clk_lucid_pll_configure(&lpass_aon_cc_pll, regmap, &lpass_aon_cc_pll_config);
>
> ret = qcom_cc_really_probe(pdev, &lpass_aon_cc_sc7280_desc, regmap);
> if (ret) {
next prev parent reply other threads:[~2023-01-31 1:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 10:14 [PATCH v6 0/6] Add resets for ADSP based audio clock controller driver Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 1/6] dt-bindings: clock: qcom,sc7280-lpasscc: Add qcom,adsp-pil-mode property Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 2/6] dt-bindings: clock: lpassaudiocc-sc7280: Add binding headers for lpasscc Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 3/6] clk: qcom: lpasscc-sc7280: Skip qdsp6ss clock registration Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 4/6] clk: qcom: lpasscorecc-sc7280: Skip lpasscorecc registration Srinivasa Rao Mandadapu
2023-01-31 0:54 ` Stephen Boyd
2023-01-31 6:35 ` Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 5/6] clk: qcom: lpassaudiocc-sc7280: Merge lpasscc into lpass_aon Srinivasa Rao Mandadapu
2023-01-31 1:04 ` Stephen Boyd
2023-01-31 9:29 ` Srinivasa Rao Mandadapu
2023-01-31 20:26 ` Stephen Boyd
2023-02-01 7:07 ` Srinivasa Rao Mandadapu
2023-01-26 10:14 ` [PATCH v6 6/6] clk: qcom: lpassaudiocc-sc7280: Skip lpass_aon_cc_pll config Srinivasa Rao Mandadapu
2023-01-31 1:06 ` Stephen Boyd [this message]
2023-01-31 6:36 ` Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n504ZhYcm73e1kxg0OnOKbUUaU46SKE8JMpwCd-WKh3mTg@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).