From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D39A0C12002 for ; Fri, 16 Jul 2021 19:31:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDF58613FD for ; Fri, 16 Jul 2021 19:31:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232226AbhGPTek (ORCPT ); Fri, 16 Jul 2021 15:34:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232897AbhGPTei (ORCPT ); Fri, 16 Jul 2021 15:34:38 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECAD6C061760 for ; Fri, 16 Jul 2021 12:31:42 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id t4-20020a05683014c4b02904cd671b911bso2932769otq.1 for ; Fri, 16 Jul 2021 12:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=/XzjQ3hrT1h6mwJfiVdsgdMHQh30ZOTfHqhe4pDPAFc=; b=Z6K1RaVI1ceFMzC3AvNoZAO+R2p/p6Ol+5P6/qyYUGWKuVBe20+XeDO5Qnhae3Ll3E jvep7E0deaHxTY37gGGEPNQTZwlJBY3AL3rzot/zzhpGXe90sOKfybg4z34EO8fTzxKx 2GPnei4KDxACl8dt1yCV8ev2UNDGvZ2pZ73Fg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=/XzjQ3hrT1h6mwJfiVdsgdMHQh30ZOTfHqhe4pDPAFc=; b=SPPV8ABZHtniMgldcod8IaHG06taXsnlKRF+4y/B9xhtGu4M0Cr05Eewmmxfzqm8bQ EGaN8ySvIPCkW8CWedrRO0UazsCYw1VBjvknKlx7VMH8axjeli2ieifxM+hT9Pa33Uhz axdBuzlCBGCCCuUiUkjeVnkhx6NgfF7pYHgm17ZppdCbGXSo43iNHtw5m6fUSaq/qUvp ehD/O3etOy1TCBGuc2+ub862hZNuWpC53qs/mjy+M1cd2H3GtnJtIXqIXg30u29x1hzN PLJ1cECEdB1kKo/+el140Qe95B04SkJcRBZmmqjJ5UO0OEhNbpqSJfIgLuY0PoWL3amG fteA== X-Gm-Message-State: AOAM531HRVNgoww2Hkwzvs/V2qQVOzu+6M8NIv+fzSkoUl0W7aoEbWAi 9GD/gbfMnSF4m5qV327wMyAx9QMqbg8fGpHiG9/HrA== X-Google-Smtp-Source: ABdhPJzQwM5RPFiII+LtE0CwZjRVpF8zxHa5i+kGr1DzmTt77SNBsgiIRAwe0LeNJBUpuSEMP64BgD4Ps/ZjjhoJ2M0= X-Received: by 2002:a9d:650e:: with SMTP id i14mr9386454otl.233.1626463902381; Fri, 16 Jul 2021 12:31:42 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 16 Jul 2021 21:31:42 +0200 MIME-Version: 1.0 In-Reply-To: <1626443927-32028-3-git-send-email-pmaliset@codeaurora.org> References: <1626443927-32028-1-git-send-email-pmaliset@codeaurora.org> <1626443927-32028-3-git-send-email-pmaliset@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Fri, 16 Jul 2021 21:31:41 +0200 Message-ID: Subject: Re: [PATCH v4 2/4] arm64: dts: qcom: sc7280: Add PCIe and PHY related nodes To: Prasad Malisetty , agross@kernel.org, bhelgaas@google.com, bjorn.andersson@linaro.org, lorenzo.pieralisi@arm.com, robh+dt@kernel.org, svarbanov@mm-sol.com Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, mka@chromium.org, vbadigan@codeaurora.org, sallenki@codeaurora.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Prasad Malisetty (2021-07-16 06:58:45) > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index a8c274a..06baf88 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > > / { > interrupt-parent = <&intc>; > @@ -546,6 +547,118 @@ > #power-domain-cells = <1>; Is this the gpucc node? At address 3d90000? Please sort the nodes based on their address, so this would be 1c08000 which comes before gpucc and some others in this file. > }; > > + pcie1: pci@1c08000 { > + compatible = "qcom,pcie-sc7280", "qcom,pcie-sm8250", "snps,dw-pcie"; > + reg = <0 0x01c08000 0 0x3000>, > + <0 0x40000000 0 0xf1d>, > + <0 0x40000f20 0 0xa8>, > + <0 0x40001000 0 0x1000>, > + <0 0x40100000 0 0x100000>; > +