From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D81FC47087 for ; Tue, 25 May 2021 21:34:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2819D613AD for ; Tue, 25 May 2021 21:34:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232201AbhEYVgO (ORCPT ); Tue, 25 May 2021 17:36:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231164AbhEYVgN (ORCPT ); Tue, 25 May 2021 17:36:13 -0400 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CD53C061756 for ; Tue, 25 May 2021 14:34:43 -0700 (PDT) Received: by mail-oi1-x229.google.com with SMTP id s19so31661532oic.7 for ; Tue, 25 May 2021 14:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=AV1x4xY7BNlvbADnTNrQXi/pFbf3brHLvoWH+DisJu8=; b=TVv/M+CITgXJfBorA0YOq7+hshFN1qCmyi7/acuHDjIxa5rN4/3A6i2PsmL5+17oV2 S+cCUc9QAtjPKA1TU++KXfTwbEPFGfcYc8H/W0Wd844tGn+fT6ZgcjK3Pvjho31P8dTZ Zld23f9YNBRYC3Xo68O6dW7FMZ2eny1a2GHAE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=AV1x4xY7BNlvbADnTNrQXi/pFbf3brHLvoWH+DisJu8=; b=ETJeoyoHxXBcjWTfaj4hV8rtBwEaeVFn0YNW4QrseXDLngeUF3IkBGPn9IZpFmgKx4 qfvaXJtwCyuHZoHj4HQ/d6/3b2lLcPS3Pgy0jYpEpY62zVB/QjpO3wEH8mk2qxAmzCl5 D3pQtL4CkxhuLe2a2ShRtX95+ekVAB5gNkaDCL86/ySurrQinlM/vfe2Zx+NoJySNVhA Fw3xbRzJp9qUmAONAZ9RocWsmycUXKUjEp8T/1xu9pFrq4ycEA8TsaXOI2YANab++8U+ BK8BXNvhFLv3TNiSiGjXoBY3ZFvkQL6zGeFGCoPqgKue1jjUJ419TY7k6J1oFH5ADNrI kL8w== X-Gm-Message-State: AOAM533TnUpUuK+11815+lszJQg6C4bdizV+dZkYOKEMtPj7w9bIz7R7 1lWbqSOjzbxN82Jwv/tmbKovoqJE3I1rllDhBDqxmQ== X-Google-Smtp-Source: ABdhPJyDalNERHMC9OBcejmrwU3aDmCi5jtvRGCgbJT4ryJX3N8M2IpQuBdgh2aLEnO1vLHG6HGVTjg0vZ5ikvYn7LU= X-Received: by 2002:aca:654d:: with SMTP id j13mr262572oiw.125.1621978482401; Tue, 25 May 2021 14:34:42 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 25 May 2021 17:34:41 -0400 MIME-Version: 1.0 In-Reply-To: <20210525131051.31250-2-rojay@codeaurora.org> References: <20210525131051.31250-1-rojay@codeaurora.org> <20210525131051.31250-2-rojay@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 25 May 2021 17:34:41 -0400 Message-ID: Subject: Re: [PATCH V11 1/2] i2c: i2c-qcom-geni: Add shutdown callback for i2c To: Roja Rani Yarubandi , wsa@kernel.org Cc: dianders@chromium.org, saiprakash.ranjan@codeaurora.org, gregkh@linuxfoundation.org, mka@chromium.org, skananth@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org, rnayak@codeaurora.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Roja Rani Yarubandi (2021-05-25 06:10:50) > If the hardware is still accessing memory after SMMU translation > is disabled (as part of smmu shutdown callback), then the > IOVAs (I/O virtual address) which it was using will go on the bus > as the physical addresses which will result in unknown crashes > like NoC/interconnect errors. > > So, implement shutdown callback for i2c driver to suspend the bus > during system "reboot" or "shutdown". > > Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller") > Signed-off-by: Roja Rani Yarubandi > --- Reviewed-by: Stephen Boyd