linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Wolfram Sang <wsa-dev@sang-engineering.com>,
	kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: core: Disable client irq on reboot/shutdown
Date: Fri, 4 Jun 2021 23:09:21 +0000	[thread overview]
Message-ID: <CAE-0n50aeyb4g8f4aGhFWB4JFNue__CL8OPM0m3bUdEhMV1UCw@mail.gmail.com> (raw)
In-Reply-To: <202106050612.FyaqyhTf-lkp@intel.com>

Quoting kernel test robot (2021-06-04 16:01:32)
> Hi Stephen,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on 8124c8a6b35386f73523d27eacb71b5364a68c4c]
>
> url:    https://github.com/0day-ci/linux/commits/Stephen-Boyd/i2c-core-Disable-client-irq-on-reboot-shutdown/20210605-052848
> base:   8124c8a6b35386f73523d27eacb71b5364a68c4c
> config: nios2-randconfig-s031-20210604 (attached as .config)
> compiler: nios2-linux-gcc (GCC) 9.3.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # apt-get install sparse
>         # sparse version: v0.6.3-341-g8af24329-dirty
>         # https://github.com/0day-ci/linux/commit/2fb1417bc9d82a335db5ed8a1446be74bffae440
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Stephen-Boyd/i2c-core-Disable-client-irq-on-reboot-shutdown/20210605-052848
>         git checkout 2fb1417bc9d82a335db5ed8a1446be74bffae440
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=nios2
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>    drivers/i2c/i2c-core-base.c: In function 'i2c_device_shutdown':
> >> drivers/i2c/i2c-core-base.c:631:3: error: implicit declaration of function 'disable_irq'; did you mean 'disable_srat'? [-Werror=implicit-function-declaration]

Must need interrupt.h, which I must have got implicitly somehow.

>      631 |   disable_irq(client->irq);
>          |   ^~~~~~~~~~~
>          |   disable_srat

      reply	other threads:[~2021-06-04 23:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 21:27 [PATCH] i2c: core: Disable client irq on reboot/shutdown Stephen Boyd
2021-06-04 23:01 ` kernel test robot
2021-06-04 23:09   ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE-0n50aeyb4g8f4aGhFWB4JFNue__CL8OPM0m3bUdEhMV1UCw@mail.gmail.com \
    --to=swboyd@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=wsa-dev@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).