From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A8CC433F5 for ; Mon, 13 Sep 2021 19:49:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4792061106 for ; Mon, 13 Sep 2021 19:49:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347599AbhIMTuo (ORCPT ); Mon, 13 Sep 2021 15:50:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240911AbhIMTul (ORCPT ); Mon, 13 Sep 2021 15:50:41 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F778C061760 for ; Mon, 13 Sep 2021 12:49:25 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id c8-20020a9d6c88000000b00517cd06302dso14928172otr.13 for ; Mon, 13 Sep 2021 12:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to; bh=yw1b9fZ1lnCtG8cegvzmoiB8uewJHdwQglsWdbmU568=; b=oEi+EQkTL3cI5BWuIOLe986IYt7QuXhKHrWvB2PKhVGBwtcewfViIp+vKPLd5Jh8Ga +SQebu6ypyjpH7bVj9+T7Y+zTjLLpfdff0Gg278iQWfJvD5izP55iv4Q3ODx1PMWuD7r aw8u/G3gjbhXzPyaBPtLRqpJD2AUwiWN1C07M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to; bh=yw1b9fZ1lnCtG8cegvzmoiB8uewJHdwQglsWdbmU568=; b=pdkhig4pWVGoykB1pZViKdfuOGnUuY7d6JWI4Q1xQSyyBSXQYqktP6vuXiMn+QaJw0 leDUsUkECR7v8fHnexRF+EO6WO+0/Ksch8OaIlV7ZAP3Q/p37FvFzwTy9FqnQFLJHrmV Ns+B15EaoaqdFZVdlVhHWULWzgVPfRa7ihH2v6jRDbphUXqU2DtznkryRlj8HiHiR3Fq v7V0Jqt+fKokYQw5K2421eClaVHlSCavKqSCnOR9E7PEcGP8p168ikk0Tu3mEnR+/Wdf 6cE0uWCvxjUEDjHjk9Pgli0oeqFe8/uX4Z3h7AWUbOmFtxPCqO00H/hNFWkspaFDeTbL mJqw== X-Gm-Message-State: AOAM531qH2r50cj6XhvWk681ikgfEK7hnUUB8SuboDaTsxzFz7xQaJWg 8huq0VkjdiDf0MzvZLHBzvbL6qO1NZntR1Je9QmE2w== X-Google-Smtp-Source: ABdhPJz3o79dJM5zC1pjJ+LQMjOTyr1vev2/NGN4jY/c2ZfYnAk+xuiWK8/sXZPYqgI/zUyQOWM/DC8C0/FJ2jSbiDw= X-Received: by 2002:a05:6830:18c7:: with SMTP id v7mr11183152ote.126.1631562564916; Mon, 13 Sep 2021 12:49:24 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 13 Sep 2021 12:49:24 -0700 MIME-Version: 1.0 In-Reply-To: <1631539062-28577-3-git-send-email-srivasam@codeaurora.org> References: <1631539062-28577-1-git-send-email-srivasam@codeaurora.org> <1631539062-28577-3-git-send-email-srivasam@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 13 Sep 2021 12:49:24 -0700 Message-ID: Subject: Re: [PATCH v2 2/2] ASoC: qcom: SC7280: Add machine driver To: Srinivasa Rao Mandadapu , agross@kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, bjorn.andersson@linaro.org, broonie@kernel.org, devicetree@vger.kernel.org, judyhsiao@chromium.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, perex@perex.cz, plai@codeaurora.org, robh+dt@kernel.org, rohitkr@codeaurora.org, srinivas.kandagatla@linaro.org, tiwai@suse.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Srinivasa Rao Mandadapu (2021-09-13 06:17:42) > diff --git a/sound/soc/qcom/sc7280.c b/sound/soc/qcom/sc7280.c > new file mode 100644 > index 0000000..906910c > --- /dev/null > +++ b/sound/soc/qcom/sc7280.c > @@ -0,0 +1,343 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// > +// Copyright (c) 2020-2021, The Linux Foundation. All rights reserved. > +// > +// sc7280.c -- ALSA SoC Machine driver for sc7280 > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Looks like the include should be instead. I see that practically no other code in the kernel is including the uapi header as it's for userspace, not kernel. The uapi header is included in input.h though so it's not actually all that different. > + > +#include > +#include > + > +#include "../codecs/wcd938x.h" > +#include "common.h" > +#include "lpass.h" > + [...] > +static int sc7280_snd_platform_probe(struct platform_device *pdev) > +{ > + struct snd_soc_card *card; > + struct sc7280_snd_data *data; > + struct device *dev = &pdev->dev; > + struct snd_soc_dai_link *link; > + int ret, i; > + > + /* Allocate the private data */ This comment is worthless. > + data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + card = &data->card; > + snd_soc_card_set_drvdata(card, data); > + > + card->owner = THIS_MODULE; > + card->driver_name = "SC7280"; > + card->dev = dev; > + > + ret = qcom_snd_parse_of(card); > + if (ret) > + return ret; > + > + for_each_card_prelinks(card, i, link) { > + link->init = sc7280_init; > + link->ops = &sc7280_ops; > + } Nitpick: Newline here. > + return devm_snd_soc_register_card(dev, card); > +} > +