From: Stephen Boyd <swboyd@chromium.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
agross@kernel.org, alsa-devel@alsa-project.org,
andersson@kernel.org, bgoswami@quicinc.com, broonie@kernel.org,
devicetree@vger.kernel.org, judyhsiao@chromium.org,
lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, perex@perex.cz,
quic_plai@quicinc.com, quic_rohkumar@quicinc.com,
robh+dt@kernel.org, srinivas.kandagatla@linaro.org,
tiwai@suse.com
Subject: Re: [PATCH] ASoC: qcom: lpass-sc7180: Add system suspend/resume PM ops
Date: Mon, 28 Nov 2022 14:40:10 -0500 [thread overview]
Message-ID: <CAE-0n519fURgt4x-4maBGBEm-OWk7rbfRgNJNzR-XDcMB5b4jA@mail.gmail.com> (raw)
In-Reply-To: <1669621742-28524-1-git-send-email-quic_srivasam@quicinc.com>
Quoting Srinivasa Rao Mandadapu (2022-11-27 23:49:02)
> Update lpass sc7180 platform driver with PM ops, such as
> system supend and resume callbacks.
> This update is required to disable clocks during supend and
> avoid XO shutdown issue.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Tested-by: Rahul Ajmeriya <quic_rajmeriy@quicinc.com>
> ---
> sound/soc/qcom/lpass-sc7180.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
> index 77a556b..6ad1c5b 100644
> --- a/sound/soc/qcom/lpass-sc7180.c
> +++ b/sound/soc/qcom/lpass-sc7180.c
> @@ -12,6 +12,7 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
Why is this include needed? Did you mean to include linux/pm.h?
> #include <dt-bindings/sound/sc7180-lpass.h>
> #include <sound/pcm.h>
> #include <sound/soc.h>
> @@ -156,10 +157,34 @@ static int sc7180_lpass_exit(struct platform_device *pdev)
> struct lpass_data *drvdata = platform_get_drvdata(pdev);
>
> clk_bulk_disable_unprepare(drvdata->num_clks, drvdata->clks);
> + return 0;
> +}
> +
> +static int sc7180_lpass_dev_resume(struct device *dev)
> +{
> + int ret = 0;
Please don't assign ret and then assign it again. It hides use before
true assignment bugs.
> + struct lpass_data *drvdata = dev_get_drvdata(dev);
>
> + ret = clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks);
> + if (ret) {
> + dev_err(dev, "sc7180 clk prepare and enable failed\n");
> + return ret;
> + }
> + return ret;
This could be simplified to
ret = clk_bulk_prepare_enable(...);
if (ret)
dev_err(dev, ...);
return ret;
next prev parent reply other threads:[~2022-11-28 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 7:49 [PATCH] ASoC: qcom: lpass-sc7180: Add system suspend/resume PM ops Srinivasa Rao Mandadapu
2022-11-28 16:39 ` Mark Brown
2022-11-28 19:40 ` Stephen Boyd [this message]
2022-11-29 7:53 ` Geert Uytterhoeven
2022-11-29 10:35 ` Srinivasa Rao Mandadapu
2022-11-29 10:53 ` Geert Uytterhoeven
2022-11-29 12:14 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n519fURgt4x-4maBGBEm-OWk7rbfRgNJNzR-XDcMB5b4jA@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).