From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98780C433F5 for ; Mon, 13 Sep 2021 19:42:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77EF060FE6 for ; Mon, 13 Sep 2021 19:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347574AbhIMTnt (ORCPT ); Mon, 13 Sep 2021 15:43:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238011AbhIMTnr (ORCPT ); Mon, 13 Sep 2021 15:43:47 -0400 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FCD7C061760 for ; Mon, 13 Sep 2021 12:42:31 -0700 (PDT) Received: by mail-ot1-x332.google.com with SMTP id m7-20020a9d4c87000000b0051875f56b95so14938386otf.6 for ; Mon, 13 Sep 2021 12:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=BqyiYC70ZQUHHw9//0XYXSrAX8+tnM8/YgezErnlDrU=; b=e/ksqZ8nK4LM8K7qBzx6ztRoNrqG6PH8PC4yEvjbNVYCxAkYDmbjw+IMZbNNQPvF7R fAfXBrgXMcKl+IMNADZbsi5JOMxER5obm4NoKcY/o71HCmbu9xY+Fnt3rDf/PnxozAoe WlqJnz4bjYXgBaQmmKDkmPlCT/C9EH8dwVNhY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=BqyiYC70ZQUHHw9//0XYXSrAX8+tnM8/YgezErnlDrU=; b=M9Yr0P+J/4DbRCmSeOfVRlOIMIsVxsKp0uCEoyJ6pUbciynrKAnIPd7mU6g+a8Hi0e pn34vSXNKbrDIWZYbGRdgh1HwjO7IlY7+ow71uROy2JiOhaaQvnJsYvVR0xyLW/ybiEr 5YX3qMlPy4sawgHWSIUkx8y5sZkRGfSAmRt1CzLzzrbcne2j8XwYg3FP6h1EQO/HzicE ujotU8fBbcexHs3L+0S/gd/9LG3J4cQMiH4xPaIHbc/deBeTUyTfSWkfmwejXt15wy6A eNlZFcH1Zj5q95vZmmNtzpwmnUrqBUtotpbgzNmTq5SL3OP1fRgy1+6nJJ/z7GgPqk8/ w4hA== X-Gm-Message-State: AOAM533X6LtwkY9BiGyM8fDhEOQgkP6ALVi/5DALRDCzTZxKNtpHAXlX fF5BISjzRTHOoWSfcSw4Tl3HC0/aP/WQYhXfVh16BUlqE/Q= X-Google-Smtp-Source: ABdhPJwZ8mXUoFC7htDszmiW3cET2FEd1QCjxSbxY2/mXROYf8yoBexV2QICbOCDGNL/7hR7V6ReQxz2sOFr7dvaHZ8= X-Received: by 2002:a05:6830:1212:: with SMTP id r18mr10734921otp.159.1631562150764; Mon, 13 Sep 2021 12:42:30 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 13 Sep 2021 12:42:30 -0700 MIME-Version: 1.0 In-Reply-To: <4697bec1-af58-53e4-9fd1-293bfd8754be@codeaurora.org> References: <1629108335-23463-1-git-send-email-deesin@codeaurora.org> <4697bec1-af58-53e4-9fd1-293bfd8754be@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 13 Sep 2021 12:42:30 -0700 Message-ID: Subject: Re: [PATCH V2 1/1] soc: qcom: smp2p: Add wakeup capability to SMP2P IRQ To: Deepak Kumar Singh , bjorn.andersson@linaro.org, clew@codeaurora.org, sibis@codeaurora.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, Andy Gross Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Deepak Kumar Singh (2021-09-13 10:45:19) > > On 8/17/2021 1:53 AM, Stephen Boyd wrote: > >> + ret = device_init_wakeup(&pdev->dev, true); > > I still wonder if it's better to leave this off by default and only > > enable it if the kernel is using autosuspend (PM_AUTOSLEEP). Then > > userspace is responsible to decide if it can handle the wakeup with the > > screen off, reload the remoteproc, and go back to suspend if it isn't > > using autosuspend. > > Seems like not all targets use PM_AUTOSLEEP feature, even those targets > may require wakeup to handle > > modem crash so that important modem events are not missed. I think we > can keep wake up as default behavior > > and let the user space disable it through sysfs if it doesn't want it as > wake up source. I don't understand. What if userspace is simple and doesn't use autosleep and will turn the screen on when the kernel resumes? Why do we expect the modem crashing and causing the screen to turn on to be a good user experience?