From: Stephen Boyd <swboyd@chromium.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
agross@kernel.org, bgoswami@quicinc.com,
bjorn.andersson@linaro.org, broonie@kernel.org,
devicetree@vger.kernel.org, judyhsiao@chromium.org,
lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
perex@perex.cz, quic_plai@quicinc.com, quic_rohkumar@quicinc.com,
robh+dt@kernel.org, srinivas.kandagatla@linaro.org,
tiwai@suse.com
Subject: Re: [PATCH v3 3/8] remoteproc: qcom: Add flag in adsp private data structure
Date: Wed, 10 Aug 2022 19:17:32 -0500 [thread overview]
Message-ID: <CAE-0n51a1fUx-JnfgWeyx7JRMW0mWC0QquaA2ex=WhuR1H7esA@mail.gmail.com> (raw)
In-Reply-To: <1660117558-21829-4-git-send-email-quic_srivasam@quicinc.com>
Quoting Srinivasa Rao Mandadapu (2022-08-10 00:45:53)
> Add flag in qcom_adsp private data structure and initialize
> it to distinguish ADSP and WPSS modules.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> ---
> Changes since V2:
> -- Add is_adsp_sb_needed flag instead of is_wpss.
>
> drivers/remoteproc/qcom_q6v5_adsp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c
> index 2f3b9f5..d18ec74 100644
> --- a/drivers/remoteproc/qcom_q6v5_adsp.c
> +++ b/drivers/remoteproc/qcom_q6v5_adsp.c
> @@ -62,6 +62,7 @@ struct adsp_pil_data {
> const char *sysmon_name;
> int ssctl_id;
> bool is_wpss;
> + bool is_adsp_sb_needed;
What does 'sb' mean? Self boot? Can you just write it out? And maybe
drop 'is_' prefix because if (is_*) and if (something_needed) reads the
same.
next prev parent reply other threads:[~2022-08-11 0:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 7:45 [PATCH v3 0/8] Update ADSP pil loader for SC7280 platform Srinivasa Rao Mandadapu
2022-08-10 7:45 ` [PATCH v3 1/8] dt-bindings: remoteproc: qcom: adsp: Make ADSP pil loader as generic Srinivasa Rao Mandadapu
2022-08-14 20:45 ` Rob Herring
2022-08-16 9:52 ` Srinivasa Rao Mandadapu
2022-08-10 7:45 ` [PATCH v3 2/8] dt-bindings: remoteproc: qcom: adsp: Add required bindings for SC7280 Srinivasa Rao Mandadapu
2022-08-10 13:28 ` Rob Herring
2022-08-10 7:45 ` [PATCH v3 3/8] remoteproc: qcom: Add flag in adsp private data structure Srinivasa Rao Mandadapu
2022-08-11 0:17 ` Stephen Boyd [this message]
2022-08-10 7:45 ` [PATCH v3 4/8] remoteproc: qcom: Add compatible name for SC7280 ADSP Srinivasa Rao Mandadapu
2022-08-11 0:15 ` Stephen Boyd
2022-08-10 7:45 ` [PATCH v3 5/8] remoteproc: qcom: Replace hard coded values with macros Srinivasa Rao Mandadapu
2022-08-10 7:45 ` [PATCH v3 6/8] remoteproc: qcom: Add efuse evb selection control Srinivasa Rao Mandadapu
2022-08-10 7:45 ` [PATCH v3 7/8] remoteproc: qcom: Add support for memory sandbox Srinivasa Rao Mandadapu
2022-08-12 5:32 ` Christophe JAILLET
2022-08-12 12:52 ` Srinivasa Rao Mandadapu
2022-08-10 7:45 ` [PATCH v3 8/8] remoteproc: qcom: Update QDSP6 out-of-reset timeout value Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n51a1fUx-JnfgWeyx7JRMW0mWC0QquaA2ex=WhuR1H7esA@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).