From: Stephen Boyd <swboyd@chromium.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Lee Jones <lee.jones@linaro.org>
Cc: Benson Leung <bleung@chromium.org>,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Guenter Roeck <groeck@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Craig Hesling <hesling@chromium.org>,
Tom Hughes <tomhughes@chromium.org>,
Alexandru M Stan <amstan@chromium.org>
Subject: Re: [PATCH 1/2] dt-bindings: mfd: Add ChromeOS fingerprint binding
Date: Tue, 15 Mar 2022 10:41:52 -0500 [thread overview]
Message-ID: <CAE-0n51uDh2Cf_wGpAVH1t=T0A1eTT=+KU3WMtxtyPL3kLDAdA@mail.gmail.com> (raw)
In-Reply-To: <YjB46Sq3IwvgR8MB@google.com>
Quoting Lee Jones (2022-03-15 04:30:49)
> On Tue, 15 Mar 2022, Krzysztof Kozlowski wrote:
>
> > On 15/03/2022 12:10, Lee Jones wrote:
> > > On Tue, 15 Mar 2022, Krzysztof Kozlowski wrote:
> > >
> > >> On 15/03/2022 00:22, Stephen Boyd wrote:
> > >>> Add a binding to describe the fingerprint processor found on Chromeboks
> > >>> with a fingerprint sensor.
> > >>>
> > >>> Cc: Rob Herring <robh+dt@kernel.org>
> > >>> Cc: <devicetree@vger.kernel.org>
> > >>> Cc: Guenter Roeck <groeck@chromium.org>
> > >>> Cc: Douglas Anderson <dianders@chromium.org>
> > >>> Cc: Craig Hesling <hesling@chromium.org>
> > >>> Cc: Tom Hughes <tomhughes@chromium.org>
> > >>> Cc: Alexandru M Stan <amstan@chromium.org>
> > >>> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > >>> ---
> > >>> .../bindings/mfd/google,cros-ec-fp.yaml | 89 +++++++++++++++++++
> > >>> 1 file changed, 89 insertions(+)
> > >>> create mode 100644 Documentation/devicetree/bindings/mfd/google,cros-ec-fp.yaml
> > >>>
> > >>> diff --git a/Documentation/devicetree/bindings/mfd/google,cros-ec-fp.yaml b/Documentation/devicetree/bindings/mfd/google,cros-ec-fp.yaml
> > >>> new file mode 100644
> > >>> index 000000000000..05d2b2b9b713
> > >>> --- /dev/null
> > >>> +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec-fp.yaml
> > >>> @@ -0,0 +1,89 @@
> > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > >>> +%YAML 1.2
> > >>> +---
> > >>> +$id: http://devicetree.org/schemas/mfd/google,cros-ec-fp.yaml#
> > >>
> > >> Why is this in the MFD directory? Is it really a Multi Function Device?
> > >> Description is rather opposite. You also did not CC MFD maintainer.
> > >
> > > A lot of the ChromeOS Embedded Controller support used to be located
> > > in MFD. There are still remnants, but most was moved to
> > > drivers/platform IIRC.
> > >
> > > Please see: drivers/mfd/cros_ec_dev.c
> >
> > Yes, I know, that part is a MFD. But why the fingerprint controller part
> > is MFD? To me it is closer to input device.
>
> It's tough to say from what I was sent above.
>
> But yes, sounds like it.
>
> We do not want any device 'functionality' in MFD ideally.
>
I put it next to the existing cros-ec binding. The existing binding is
there because of historical reasons as far as I know. Otherwise it
didn't seem MFD related so I didn't Cc mfd maintainer/list. New file
additions don't usually conflict with anything and this is in the
bindings directory so the driver side maintainer would be picking up the
binding.
next prev parent reply other threads:[~2022-03-15 15:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 23:22 [PATCH 0/2] Update cros-ec-spi for fingerprint devices Stephen Boyd
2022-03-14 23:22 ` [PATCH 1/2] dt-bindings: mfd: Add ChromeOS fingerprint binding Stephen Boyd
2022-03-15 0:23 ` Alexandru M Stan
2022-03-15 15:50 ` Stephen Boyd
2022-03-15 3:08 ` Tzung-Bi Shih
2022-03-15 15:38 ` Stephen Boyd
2022-03-15 10:41 ` Krzysztof Kozlowski
2022-03-15 11:10 ` Lee Jones
2022-03-15 11:22 ` Krzysztof Kozlowski
2022-03-15 11:30 ` Lee Jones
2022-03-15 15:41 ` Stephen Boyd [this message]
2022-03-15 15:48 ` Lee Jones
2022-03-15 16:19 ` Stephen Boyd
2022-03-16 7:25 ` Lee Jones
2022-03-14 23:22 ` [PATCH 2/2] platform/chrome: cros_ec_spi: Boot fingerprint processor during probe Stephen Boyd
2022-03-15 0:36 ` Alexandru M Stan
2022-03-15 16:16 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n51uDh2Cf_wGpAVH1t=T0A1eTT=+KU3WMtxtyPL3kLDAdA@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=amstan@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=hesling@chromium.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tomhughes@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).